* [PATCH v3] scripts/gdb: fix lx-version
@ 2018-10-17 14:24 Du Changbin
2018-10-25 8:54 ` Kieran Bingham
0 siblings, 1 reply; 3+ messages in thread
From: Du Changbin @ 2018-10-17 14:24 UTC (permalink / raw)
To: jan.kiszka, kbingham; +Cc: linux-kernel, Du Changbin
For current gdb version (has tested with 7.3 and 8.1), 'lx-version'
only prints one character.
(gdb) lx-version
L(gdb)
This can be fixed by casting 'linux_banner' as (char *).
(gdb) lx-version
Linux version 4.19.0-rc1+ (changbin@acer) (gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)) #21 SMP Sat Sep 1 21:43:30 CST 2018
Signed-off-by: Du Changbin <changbin.du@gmail.com>
---
scripts/gdb/linux/proc.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
index 086d27223c0c..0aebd7565b03 100644
--- a/scripts/gdb/linux/proc.py
+++ b/scripts/gdb/linux/proc.py
@@ -41,7 +41,7 @@ class LxVersion(gdb.Command):
def invoke(self, arg, from_tty):
# linux_banner should contain a newline
- gdb.write(gdb.parse_and_eval("linux_banner").string())
+ gdb.write(gdb.parse_and_eval("(char *)linux_banner").string())
LxVersion()
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] scripts/gdb: fix lx-version
2018-10-17 14:24 [PATCH v3] scripts/gdb: fix lx-version Du Changbin
@ 2018-10-25 8:54 ` Kieran Bingham
2018-11-05 9:59 ` Jan Kiszka
0 siblings, 1 reply; 3+ messages in thread
From: Kieran Bingham @ 2018-10-25 8:54 UTC (permalink / raw)
To: Du Changbin, jan.kiszka, kbingham
Cc: linux-kernel, Peter Griffin, Andrew Morton
Hi Du,
Thank you for the updated patch,
On 17/10/2018 15:24, Du Changbin wrote:
> For current gdb version (has tested with 7.3 and 8.1), 'lx-version'
> only prints one character.
> (gdb) lx-version
> L(gdb)
>
> This can be fixed by casting 'linux_banner' as (char *).
> (gdb) lx-version
> Linux version 4.19.0-rc1+ (changbin@acer) (gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)) #21 SMP Sat Sep 1 21:43:30 CST 2018
>
> Signed-off-by: Du Changbin <changbin.du@gmail.com>
I'll update the upstream GDB bugzilla [0] regarding this issue - but I
think we need a workaround here, and this is it.
Fixes: 2d061d999424 ("scripts/gdb: add version command")
Reviewed-by: Kieran Bingham <kbingham@kernel.org>
And for reference, this already has an early LGTM from Jan as well.
[0] https://sourceware.org/bugzilla/show_bug.cgi?id=20077
> ---
> scripts/gdb/linux/proc.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
> index 086d27223c0c..0aebd7565b03 100644
> --- a/scripts/gdb/linux/proc.py
> +++ b/scripts/gdb/linux/proc.py
> @@ -41,7 +41,7 @@ class LxVersion(gdb.Command):
>
> def invoke(self, arg, from_tty):
> # linux_banner should contain a newline
> - gdb.write(gdb.parse_and_eval("linux_banner").string())
> + gdb.write(gdb.parse_and_eval("(char *)linux_banner").string())
>
> LxVersion()
--
Regards
--
Kieran
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] scripts/gdb: fix lx-version
2018-10-25 8:54 ` Kieran Bingham
@ 2018-11-05 9:59 ` Jan Kiszka
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kiszka @ 2018-11-05 9:59 UTC (permalink / raw)
To: kieran.bingham, Du Changbin, kbingham, Andrew Morton
Cc: linux-kernel, Peter Griffin
On 25.10.18 10:54, Kieran Bingham wrote:
> Hi Du,
>
> Thank you for the updated patch,
>
> On 17/10/2018 15:24, Du Changbin wrote:
>> For current gdb version (has tested with 7.3 and 8.1), 'lx-version'
>> only prints one character.
>> (gdb) lx-version
>> L(gdb)
>>
>> This can be fixed by casting 'linux_banner' as (char *).
>> (gdb) lx-version
>> Linux version 4.19.0-rc1+ (changbin@acer) (gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)) #21 SMP Sat Sep 1 21:43:30 CST 2018
>>
>> Signed-off-by: Du Changbin <changbin.du@gmail.com>
>
> I'll update the upstream GDB bugzilla [0] regarding this issue - but I
> think we need a workaround here, and this is it.
>
> Fixes: 2d061d999424 ("scripts/gdb: add version command")
> Reviewed-by: Kieran Bingham <kbingham@kernel.org>
>
> And for reference, this already has an early LGTM from Jan as well.
>
> [0] https://sourceware.org/bugzilla/show_bug.cgi?id=20077
>
Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
Jan
>> ---
>> scripts/gdb/linux/proc.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
>> index 086d27223c0c..0aebd7565b03 100644
>> --- a/scripts/gdb/linux/proc.py
>> +++ b/scripts/gdb/linux/proc.py
>> @@ -41,7 +41,7 @@ class LxVersion(gdb.Command):
>>
>> def invoke(self, arg, from_tty):
>> # linux_banner should contain a newline
>> - gdb.write(gdb.parse_and_eval("linux_banner").string())
>> + gdb.write(gdb.parse_and_eval("(char *)linux_banner").string())
>>
>> LxVersion()
>
>
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-05 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-17 14:24 [PATCH v3] scripts/gdb: fix lx-version Du Changbin
2018-10-25 8:54 ` Kieran Bingham
2018-11-05 9:59 ` Jan Kiszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).