* [PATCH] m68k: allow PM menu options for COMPILE_TEST
@ 2023-02-09 1:06 Randy Dunlap
2023-02-09 14:03 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2023-02-09 1:06 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Arnd Bergmann, Geert Uytterhoeven, linux-m68k
Allow PM options for COMPILE_TEST. This quietens a kconfig
warning.
This is similar to a patch for Sparc32 that was suggested by
Arnd.
WARNING: unmet direct dependencies detected for PM
Depends on [n]: !MMU [=y]
Selected by [y]:
- SUN20I_PPU [=y] && (ARCH_SUNXI || COMPILE_TEST [=y])
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
---
arch/m68k/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/arch/m68k/Kconfig b/arch/m68k/Kconfig
--- a/arch/m68k/Kconfig
+++ b/arch/m68k/Kconfig
@@ -126,7 +126,7 @@ menu "Kernel Features"
endmenu
-if !MMU
+if !MMU || COMPILE_TEST
menu "Power management options"
config PM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] m68k: allow PM menu options for COMPILE_TEST
2023-02-09 1:06 [PATCH] m68k: allow PM menu options for COMPILE_TEST Randy Dunlap
@ 2023-02-09 14:03 ` Geert Uytterhoeven
2023-02-09 17:09 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-02-09 14:03 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Arnd Bergmann, linux-m68k
Hi Randy,
On Thu, Feb 9, 2023 at 2:06 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Allow PM options for COMPILE_TEST. This quietens a kconfig
> warning.
>
> This is similar to a patch for Sparc32 that was suggested by
> Arnd.
>
> WARNING: unmet direct dependencies detected for PM
> Depends on [n]: !MMU [=y]
> Selected by [y]:
> - SUN20I_PPU [=y] && (ARCH_SUNXI || COMPILE_TEST [=y])
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Thanks for your patch!
> --- a/arch/m68k/Kconfig
> +++ b/arch/m68k/Kconfig
> @@ -126,7 +126,7 @@ menu "Kernel Features"
>
> endmenu
>
> -if !MMU
> +if !MMU || COMPILE_TEST
> menu "Power management options"
I think this is the wrong solution.
All other selects of PM are done by architecture/platform-gating
symbols, and none of them can be enabled for compile-testing.
So either SUN20I_PPU should depend on PM, or ARCH_SUNXI
should select PM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] m68k: allow PM menu options for COMPILE_TEST
2023-02-09 14:03 ` Geert Uytterhoeven
@ 2023-02-09 17:09 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-02-09 17:09 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-kernel, Arnd Bergmann, linux-m68k
Hi Geert,
On 2/9/23 06:03, Geert Uytterhoeven wrote:
> Hi Randy,
>
> On Thu, Feb 9, 2023 at 2:06 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> Allow PM options for COMPILE_TEST. This quietens a kconfig
>> warning.
>>
>> This is similar to a patch for Sparc32 that was suggested by
>> Arnd.
>>
>> WARNING: unmet direct dependencies detected for PM
>> Depends on [n]: !MMU [=y]
>> Selected by [y]:
>> - SUN20I_PPU [=y] && (ARCH_SUNXI || COMPILE_TEST [=y])
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks for your patch!
>
>> --- a/arch/m68k/Kconfig
>> +++ b/arch/m68k/Kconfig
>> @@ -126,7 +126,7 @@ menu "Kernel Features"
>>
>> endmenu
>>
>> -if !MMU
>> +if !MMU || COMPILE_TEST
>> menu "Power management options"
>
> I think this is the wrong solution.
> All other selects of PM are done by architecture/platform-gating
Yes, which is where they should be.
> symbols, and none of them can be enabled for compile-testing.
>
> So either SUN20I_PPU should depend on PM, or ARCH_SUNXI
> should select PM.
I'll do the first choice since I shouldn't be the one to make
a platform config change without knowing about the platform.
Thank you.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-09 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-09 1:06 [PATCH] m68k: allow PM menu options for COMPILE_TEST Randy Dunlap
2023-02-09 14:03 ` Geert Uytterhoeven
2023-02-09 17:09 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).