* [PATCH] mm: ifdef Quicklists in /proc/meminfo
@ 2008-09-08 12:57 Hugh Dickins
2008-09-08 13:37 ` Christoph Lameter
2008-09-08 23:43 ` KOSAKI Motohiro
0 siblings, 2 replies; 7+ messages in thread
From: Hugh Dickins @ 2008-09-08 12:57 UTC (permalink / raw)
To: Linus Torvalds
Cc: KOSAKI Motohiro, Keiichiro Tokunaga, Christoph Lameter,
Andrew Morton, linux-kernel
A "Quicklists: 0 kB" line has just started appearing in
/proc/meminfo, but most architectures (including x86) don't have
them configured: may we please #ifdef it, like the highmem lines?
And those architectures which do have quicklists configured are
using them for page tables: so let's place it next to PageTables.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
fs/proc/proc_misc.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
--- 2.6.27-rc5-git/fs/proc/proc_misc.c.0 2008-09-03 07:32:07.000000000 +0100
+++ linux/fs/proc/proc_misc.c 2008-09-08 13:07:41.000000000 +0100
@@ -183,6 +183,9 @@ static int meminfo_read_proc(char *page,
"SReclaimable: %8lu kB\n"
"SUnreclaim: %8lu kB\n"
"PageTables: %8lu kB\n"
+#ifdef CONFIG_QUICKLIST
+ "Quicklists: %8lu kB\n"
+#endif
"NFS_Unstable: %8lu kB\n"
"Bounce: %8lu kB\n"
"WritebackTmp: %8lu kB\n"
@@ -190,8 +193,7 @@ static int meminfo_read_proc(char *page,
"Committed_AS: %8lu kB\n"
"VmallocTotal: %8lu kB\n"
"VmallocUsed: %8lu kB\n"
- "VmallocChunk: %8lu kB\n"
- "Quicklists: %8lu kB\n",
+ "VmallocChunk: %8lu kB\n",
K(i.totalram),
K(i.freeram),
K(i.bufferram),
@@ -216,6 +218,9 @@ static int meminfo_read_proc(char *page,
K(global_page_state(NR_SLAB_RECLAIMABLE)),
K(global_page_state(NR_SLAB_UNRECLAIMABLE)),
K(global_page_state(NR_PAGETABLE)),
+#ifdef CONFIG_QUICKLIST
+ K(quicklist_total_size()),
+#endif
K(global_page_state(NR_UNSTABLE_NFS)),
K(global_page_state(NR_BOUNCE)),
K(global_page_state(NR_WRITEBACK_TEMP)),
@@ -223,8 +228,7 @@ static int meminfo_read_proc(char *page,
K(committed),
(unsigned long)VMALLOC_TOTAL >> 10,
vmi.used >> 10,
- vmi.largest_chunk >> 10,
- K(quicklist_total_size())
+ vmi.largest_chunk >> 10
);
len += hugetlb_report_meminfo(page + len);
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo
2008-09-08 12:57 [PATCH] mm: ifdef Quicklists in /proc/meminfo Hugh Dickins
@ 2008-09-08 13:37 ` Christoph Lameter
2008-09-08 23:43 ` KOSAKI Motohiro
1 sibling, 0 replies; 7+ messages in thread
From: Christoph Lameter @ 2008-09-08 13:37 UTC (permalink / raw)
To: Hugh Dickins
Cc: Linus Torvalds, KOSAKI Motohiro, Keiichiro Tokunaga,
Andrew Morton, linux-kernel
Acked-by: Christoph Lameter <cl@linux-foundation.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo
2008-09-08 12:57 [PATCH] mm: ifdef Quicklists in /proc/meminfo Hugh Dickins
2008-09-08 13:37 ` Christoph Lameter
@ 2008-09-08 23:43 ` KOSAKI Motohiro
2008-09-08 23:57 ` H. Peter Anvin
1 sibling, 1 reply; 7+ messages in thread
From: KOSAKI Motohiro @ 2008-09-08 23:43 UTC (permalink / raw)
To: Hugh Dickins
Cc: kosaki.motohiro, Linus Torvalds, Keiichiro Tokunaga,
Christoph Lameter, Andrew Morton, linux-kernel
> A "Quicklists: 0 kB" line has just started appearing in
> /proc/meminfo, but most architectures (including x86) don't have
> them configured: may we please #ifdef it, like the highmem lines?
>
> And those architectures which do have quicklists configured are
> using them for page tables: so let's place it next to PageTables.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
Oh, I see.
Thanks Hugh.
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo
2008-09-08 23:43 ` KOSAKI Motohiro
@ 2008-09-08 23:57 ` H. Peter Anvin
2008-09-09 12:04 ` Hugh Dickins
2008-09-09 23:48 ` Jeremy Fitzhardinge
0 siblings, 2 replies; 7+ messages in thread
From: H. Peter Anvin @ 2008-09-08 23:57 UTC (permalink / raw)
To: KOSAKI Motohiro
Cc: Hugh Dickins, Linus Torvalds, Keiichiro Tokunaga,
Christoph Lameter, Andrew Morton, linux-kernel
KOSAKI Motohiro wrote:
>> A "Quicklists: 0 kB" line has just started appearing in
>> /proc/meminfo, but most architectures (including x86) don't have
>> them configured: may we please #ifdef it, like the highmem lines?
>>
>> And those architectures which do have quicklists configured are
>> using them for page tables: so let's place it next to PageTables.
>>
>> Signed-off-by: Hugh Dickins <hugh@veritas.com>
>> ---
>
> Oh, I see.
> Thanks Hugh.
>
> Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
x86 *does* use quicklists, at least with PAE.
-hpa
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo
2008-09-08 23:57 ` H. Peter Anvin
@ 2008-09-09 12:04 ` Hugh Dickins
2008-09-09 23:48 ` Jeremy Fitzhardinge
1 sibling, 0 replies; 7+ messages in thread
From: Hugh Dickins @ 2008-09-09 12:04 UTC (permalink / raw)
To: H. Peter Anvin
Cc: KOSAKI Motohiro, Linus Torvalds, Keiichiro Tokunaga,
Christoph Lameter, Andrew Morton, linux-kernel
On Mon, 8 Sep 2008, H. Peter Anvin wrote:
>
> x86 *does* use quicklists, at least with PAE.
Are you harking back to the good old days of 2.6.24?
Or looking ahead to a bright new future?
There was a defect, in the TLB flushing sequence IIRC,
which got them kicked out in a hurry. They might return
- but I think everybody would prefer to have a better way
of applying the existing allocators than this extra pool.
Hugh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo
2008-09-08 23:57 ` H. Peter Anvin
2008-09-09 12:04 ` Hugh Dickins
@ 2008-09-09 23:48 ` Jeremy Fitzhardinge
2008-09-09 23:50 ` H. Peter Anvin
1 sibling, 1 reply; 7+ messages in thread
From: Jeremy Fitzhardinge @ 2008-09-09 23:48 UTC (permalink / raw)
To: H. Peter Anvin
Cc: KOSAKI Motohiro, Hugh Dickins, Linus Torvalds,
Keiichiro Tokunaga, Christoph Lameter, Andrew Morton,
linux-kernel
H. Peter Anvin wrote:
> x86 *does* use quicklists, at least with PAE.
No, not for a while now.
J
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo
2008-09-09 23:48 ` Jeremy Fitzhardinge
@ 2008-09-09 23:50 ` H. Peter Anvin
0 siblings, 0 replies; 7+ messages in thread
From: H. Peter Anvin @ 2008-09-09 23:50 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: KOSAKI Motohiro, Hugh Dickins, Linus Torvalds,
Keiichiro Tokunaga, Christoph Lameter, Andrew Morton,
linux-kernel
Jeremy Fitzhardinge wrote:
> H. Peter Anvin wrote:
>> x86 *does* use quicklists, at least with PAE.
>
> No, not for a while now.
Sorry, stale cache...
-hpa
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-09-09 23:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-08 12:57 [PATCH] mm: ifdef Quicklists in /proc/meminfo Hugh Dickins
2008-09-08 13:37 ` Christoph Lameter
2008-09-08 23:43 ` KOSAKI Motohiro
2008-09-08 23:57 ` H. Peter Anvin
2008-09-09 12:04 ` Hugh Dickins
2008-09-09 23:48 ` Jeremy Fitzhardinge
2008-09-09 23:50 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).