* [PATCH] KVM: x86: Remove a spurious export of a static function
@ 2019-11-22 20:15 Sean Christopherson
2019-11-22 20:37 ` Jim Mattson
2019-11-23 10:28 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Sean Christopherson @ 2019-11-22 20:15 UTC (permalink / raw)
To: Paolo Bonzini, Radim Krčmář
Cc: Sean Christopherson, Vitaly Kuznetsov, Wanpeng Li, Jim Mattson,
Joerg Roedel, kvm, linux-kernel
A recent change inadvertantly exported a static function, which results
in modpost throwing a warning. Fix it.
Fixes: cbbaa2727aa3 ("KVM: x86: fix presentation of TSX feature in ARCH_CAPABILITIES")
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
---
arch/x86/kvm/x86.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index a256e09f321a..3e9ab2d1ea77 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1329,7 +1329,6 @@ static u64 kvm_get_arch_capabilities(void)
return data;
}
-EXPORT_SYMBOL_GPL(kvm_get_arch_capabilities);
static int kvm_get_msr_feature(struct kvm_msr_entry *msr)
{
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: x86: Remove a spurious export of a static function
2019-11-22 20:15 [PATCH] KVM: x86: Remove a spurious export of a static function Sean Christopherson
@ 2019-11-22 20:37 ` Jim Mattson
2019-11-23 10:28 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Jim Mattson @ 2019-11-22 20:37 UTC (permalink / raw)
To: Sean Christopherson
Cc: Paolo Bonzini, Radim Krčmář,
Vitaly Kuznetsov, Wanpeng Li, Joerg Roedel, kvm list, LKML
On Fri, Nov 22, 2019 at 12:15 PM Sean Christopherson
<sean.j.christopherson@intel.com> wrote:
>
> A recent change inadvertantly exported a static function, which results
Nit: inadvertently
> in modpost throwing a warning. Fix it.
>
> Fixes: cbbaa2727aa3 ("KVM: x86: fix presentation of TSX feature in ARCH_CAPABILITIES")
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: x86: Remove a spurious export of a static function
2019-11-22 20:15 [PATCH] KVM: x86: Remove a spurious export of a static function Sean Christopherson
2019-11-22 20:37 ` Jim Mattson
@ 2019-11-23 10:28 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2019-11-23 10:28 UTC (permalink / raw)
To: Sean Christopherson, Radim Krčmář
Cc: Vitaly Kuznetsov, Wanpeng Li, Jim Mattson, Joerg Roedel, kvm,
linux-kernel
On 22/11/19 21:15, Sean Christopherson wrote:
> A recent change inadvertantly exported a static function, which results
> in modpost throwing a warning. Fix it.
>
> Fixes: cbbaa2727aa3 ("KVM: x86: fix presentation of TSX feature in ARCH_CAPABILITIES")
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> ---
> arch/x86/kvm/x86.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index a256e09f321a..3e9ab2d1ea77 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1329,7 +1329,6 @@ static u64 kvm_get_arch_capabilities(void)
>
> return data;
> }
> -EXPORT_SYMBOL_GPL(kvm_get_arch_capabilities);
>
> static int kvm_get_msr_feature(struct kvm_msr_entry *msr)
> {
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-23 10:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 20:15 [PATCH] KVM: x86: Remove a spurious export of a static function Sean Christopherson
2019-11-22 20:37 ` Jim Mattson
2019-11-23 10:28 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).