* [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function
@ 2011-06-07 6:00 Tomoya MORINAGA
2011-06-07 17:22 ` Grant Likely
0 siblings, 1 reply; 7+ messages in thread
From: Tomoya MORINAGA @ 2011-06-07 6:00 UTC (permalink / raw)
To: Grant Likely, linux-kernel, alexander.stein
Cc: qi.wang, yong.y.wang, toshiharu-linux, kok.howg.ewe, joel.clark
Hi Grant,
Let me resend again.
I haven't received your answer the following my question yet.
On Friday, May 27, 2011 4:09 PM, Grant Likely wrote:
> Take a look at the new irq_chip_generic infrastructure. You don't
> need to implement a memory mapped irq controller from scratch anymore.
> Most of the access functions can be taken directly from
> irq_chip_generic instead.
Let me clarify your saying.
a) We shouldn't use request_irq( ) ?
b) Does Your "irq_chip_generic" mean irq_set_handler_data( ) /
irq_set_chained_handler( ) ?
If yes, Using these functions, I saw IRQ shared other function's
interrupt becomes invalid.
--
tomoya
OKI SEMICONDUCTOR CO., LTD.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function
2011-06-07 6:00 [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function Tomoya MORINAGA
@ 2011-06-07 17:22 ` Grant Likely
2011-06-08 2:29 ` Tomoya MORINAGA
2011-06-20 1:07 ` Tomoya MORINAGA
0 siblings, 2 replies; 7+ messages in thread
From: Grant Likely @ 2011-06-07 17:22 UTC (permalink / raw)
To: Tomoya MORINAGA
Cc: linux-kernel, alexander.stein, qi.wang, yong.y.wang,
toshiharu-linux, kok.howg.ewe, joel.clark
On Tue, Jun 07, 2011 at 03:00:48PM +0900, Tomoya MORINAGA wrote:
> Hi Grant,
>
> Let me resend again.
> I haven't received your answer the following my question yet.
>
> On Friday, May 27, 2011 4:09 PM, Grant Likely wrote:
> > Take a look at the new irq_chip_generic infrastructure. You don't
> > need to implement a memory mapped irq controller from scratch anymore.
> > Most of the access functions can be taken directly from
> > irq_chip_generic instead.
>
> Let me clarify your saying.
> a) We shouldn't use request_irq( ) ?
> b) Does Your "irq_chip_generic" mean irq_set_handler_data( ) /
> irq_set_chained_handler( ) ?
> If yes, Using these functions, I saw IRQ shared other function's
> interrupt becomes invalid.
>
No, I'm saying that you don't need to implement new irq_chip
operations if you use the new irq_chip_generic implementation.
g.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function
2011-06-07 17:22 ` Grant Likely
@ 2011-06-08 2:29 ` Tomoya MORINAGA
2011-06-08 14:57 ` Grant Likely
2011-06-20 1:07 ` Tomoya MORINAGA
1 sibling, 1 reply; 7+ messages in thread
From: Tomoya MORINAGA @ 2011-06-08 2:29 UTC (permalink / raw)
To: Grant Likely
Cc: linux-kernel, alexander.stein, qi.wang, yong.y.wang,
toshiharu-linux, kok.howg.ewe, joel.clark
(2011/06/08 2:22), Grant Likely wrote:
> No, I'm saying that you don't need to implement new irq_chip
> operations if you use the new irq_chip_generic implementation.
I understand your saying. It seems "new irq_chip_generic" was
implemented in linux-3.0.
However "irq_chip_generic" is not implemented in stable kernel version.
Right ?
So, first of all, could you accept this patch ?
After the kernel version becomes stable, I will resubmit a patch for
"new irq_chip_generic".
--
tomoya
OKI SEMICONDUCTOR CO., LTD.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function
2011-06-08 2:29 ` Tomoya MORINAGA
@ 2011-06-08 14:57 ` Grant Likely
2011-06-09 1:29 ` Tomoya MORINAGA
0 siblings, 1 reply; 7+ messages in thread
From: Grant Likely @ 2011-06-08 14:57 UTC (permalink / raw)
To: Tomoya MORINAGA
Cc: linux-kernel, alexander.stein, qi.wang, yong.y.wang,
toshiharu-linux, kok.howg.ewe, joel.clark
On Wed, Jun 08, 2011 at 11:29:53AM +0900, Tomoya MORINAGA wrote:
> (2011/06/08 2:22), Grant Likely wrote:
> >No, I'm saying that you don't need to implement new irq_chip
> >operations if you use the new irq_chip_generic implementation.
>
> I understand your saying. It seems "new irq_chip_generic" was
> implemented in linux-3.0.
> However "irq_chip_generic" is not implemented in stable kernel
> version. Right ?
> So, first of all, could you accept this patch ?
> After the kernel version becomes stable, I will resubmit a patch for
> "new irq_chip_generic".
Ah, I understand what you're asking.
Sorry, but I cannot pickup this patch for the stable series. It is a
new feature, not a bug fix. Only bug fixes should be going into the
stable kernel series.
g.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function
2011-06-08 14:57 ` Grant Likely
@ 2011-06-09 1:29 ` Tomoya MORINAGA
0 siblings, 0 replies; 7+ messages in thread
From: Tomoya MORINAGA @ 2011-06-09 1:29 UTC (permalink / raw)
To: Grant Likely
Cc: linux-kernel, alexander.stein, qi.wang, yong.y.wang,
toshiharu-linux, kok.howg.ewe, joel.clark
(2011/06/08 23:57), Grant Likely wrote:
> Ah, I understand what you're asking.
>
> Sorry, but I cannot pickup this patch for the stable series. It is a
> new feature, not a bug fix. Only bug fixes should be going into the
> stable kernel series.
>
My request didn't mean like above.
I meant that I want you to add the patch to next version linux, namely "3.1"
Because "irq_chip_generic" is implemented only RC version, namely "3.0-rcX"
Anyway, I don't think you change your opinion.
Thus, I must re-coding using "irq_chip_generic".
Thanks,
--
tomoya
OKI SEMICONDUCTOR CO., LTD.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function
2011-06-07 17:22 ` Grant Likely
2011-06-08 2:29 ` Tomoya MORINAGA
@ 2011-06-20 1:07 ` Tomoya MORINAGA
2011-06-20 4:25 ` Grant Likely
1 sibling, 1 reply; 7+ messages in thread
From: Tomoya MORINAGA @ 2011-06-20 1:07 UTC (permalink / raw)
To: Grant Likely
Cc: linux-kernel, alexander.stein, qi.wang, yong.y.wang,
toshiharu-linux, kok.howg.ewe, joel.clark
Hi Grant
(2011/06/08 2:22), Grant Likely wrote:
>
> You don't need to implement new irq_chip
> operations if you use the new irq_chip_generic implementation.
>
I have recently started implementing GPIO interrupt using irq_chip_generic.
However, the compile becomes failed.
irq_alloc_generic_chip: undefined reference
irq_setup_generic_chip: undefined reference
It seems irq_chip_generic is only ARM code.(linux-3.0-rc3)
Does X86 support irq_chip_generic ?
--
tomoya
OKI SEMICONDUCTOR CO., LTD.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function
2011-06-20 1:07 ` Tomoya MORINAGA
@ 2011-06-20 4:25 ` Grant Likely
0 siblings, 0 replies; 7+ messages in thread
From: Grant Likely @ 2011-06-20 4:25 UTC (permalink / raw)
To: Tomoya MORINAGA
Cc: linux-kernel, alexander.stein, qi.wang, yong.y.wang,
toshiharu-linux, kok.howg.ewe, joel.clark
On Sun, Jun 19, 2011 at 7:07 PM, Tomoya MORINAGA
<tomoya-linux@dsn.okisemi.com> wrote:
> Hi Grant
>
> (2011/06/08 2:22), Grant Likely wrote:
>>
>> You don't need to implement new irq_chip
>> operations if you use the new irq_chip_generic implementation.
>>
>
> I have recently started implementing GPIO interrupt using irq_chip_generic.
> However, the compile becomes failed.
> irq_alloc_generic_chip: undefined reference
> irq_setup_generic_chip: undefined reference
>
> It seems irq_chip_generic is only ARM code.(linux-3.0-rc3)
> Does X86 support irq_chip_generic ?
Make sure your driver has "select GENERIC_IRQ_CHIP" in the Kconfig entry.
g.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-06-20 4:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-07 6:00 [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function Tomoya MORINAGA
2011-06-07 17:22 ` Grant Likely
2011-06-08 2:29 ` Tomoya MORINAGA
2011-06-08 14:57 ` Grant Likely
2011-06-09 1:29 ` Tomoya MORINAGA
2011-06-20 1:07 ` Tomoya MORINAGA
2011-06-20 4:25 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).