* [PATCH] usbip: change match_busid() to local function
@ 2011-05-30 20:09 Németh Márton
2011-06-07 21:31 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Németh Márton @ 2011-05-30 20:09 UTC (permalink / raw)
To: Greg Kroah-Hartman, Matt Mooney, Endre Kollar, Ilia Mirkin,
usbip-devel, devel
Cc: LKML
From: Márton Németh <nm127@freemail.hu>
The function match_busid() is only referenced in the stub_main.c so it can be changed
to static. This will remove the following warning when compiling with "make W=1 ...":
* drivers/staging/usbip/stub_main.c:40: warning: no previous prototype for ‘match_busid’
Signed-off-by: Márton Németh <nm127@freemail.hu>
---
diff --git a/drivers/staging/usbip/stub_main.c b/drivers/staging/usbip/stub_main.c
index e9085d6..fc5b829 100644
--- a/drivers/staging/usbip/stub_main.c
+++ b/drivers/staging/usbip/stub_main.c
@@ -37,7 +37,7 @@ struct kmem_cache *stub_priv_cache;
static struct bus_id_priv busid_table[MAX_BUSID];
static spinlock_t busid_table_lock;
-int match_busid(const char *busid)
+static int match_busid(const char *busid)
{
int i;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usbip: change match_busid() to local function
2011-05-30 20:09 [PATCH] usbip: change match_busid() to local function Németh Márton
@ 2011-06-07 21:31 ` Greg KH
2011-06-08 4:53 ` Németh Márton
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2011-06-07 21:31 UTC (permalink / raw)
To: Németh Márton
Cc: Greg Kroah-Hartman, Matt Mooney, Endre Kollar, Ilia Mirkin,
usbip-devel, devel, LKML
On Mon, May 30, 2011 at 10:09:39PM +0200, Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
>
> The function match_busid() is only referenced in the stub_main.c so it can be changed
> to static. This will remove the following warning when compiling with "make W=1 ...":
>
> * drivers/staging/usbip/stub_main.c:40: warning: no previous prototype for ‘match_busid’
>
> Signed-off-by: Márton Németh <nm127@freemail.hu>
This no longer applies, care to redo it against the next linux-next tree
that comes out?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usbip: change match_busid() to local function
2011-06-07 21:31 ` Greg KH
@ 2011-06-08 4:53 ` Németh Márton
2011-06-08 5:05 ` Németh Márton
0 siblings, 1 reply; 4+ messages in thread
From: Németh Márton @ 2011-06-08 4:53 UTC (permalink / raw)
To: Greg KH
Cc: Greg Kroah-Hartman, Matt Mooney, Endre Kollar, Ilia Mirkin,
usbip-devel, devel, LKML
From: Márton Németh <nm127@freemail.hu>
The function match_busid() is only referenced in the stub_main.c so it can be changed
to static. This will remove the following warning when compiling with "make W=1 ...":
* drivers/staging/usbip/stub_main.c:40: warning: no previous prototype for ‘match_busid’
Signed-off-by: Márton Németh <nm127@freemail.hu>
---
diff --git a/drivers/staging/usbip/stub_main.c b/drivers/staging/usbip/stub_main.c
index e9085d6..fc5b829 100644
--- a/drivers/staging/usbip/stub_main.c
+++ b/drivers/staging/usbip/stub_main.c
@@ -37,7 +37,7 @@ struct kmem_cache *stub_priv_cache;
static struct bus_id_priv busid_table[MAX_BUSID];
static spinlock_t busid_table_lock;
-int match_busid(const char *busid)
+static int match_busid(const char *busid)
{
int i;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usbip: change match_busid() to local function
2011-06-08 4:53 ` Németh Márton
@ 2011-06-08 5:05 ` Németh Márton
0 siblings, 0 replies; 4+ messages in thread
From: Németh Márton @ 2011-06-08 5:05 UTC (permalink / raw)
To: Greg KH
Cc: Greg Kroah-Hartman, Matt Mooney, Endre Kollar, Ilia Mirkin,
usbip-devel, devel, LKML
Forget it, this change is already there in the
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6.git ,
on staging-next branch. I just forget to switch the branch from master
after cloning the staging-2.6 repository.
Regards,
Márton Németh
Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
>
> The function match_busid() is only referenced in the stub_main.c so it can be changed
> to static. This will remove the following warning when compiling with "make W=1 ...":
> * drivers/staging/usbip/stub_main.c:40: warning: no previous prototype for ‘match_busid’
>
> Signed-off-by: Márton Németh <nm127@freemail.hu>
> ---
> diff --git a/drivers/staging/usbip/stub_main.c b/drivers/staging/usbip/stub_main.c
> index e9085d6..fc5b829 100644
> --- a/drivers/staging/usbip/stub_main.c
> +++ b/drivers/staging/usbip/stub_main.c
> @@ -37,7 +37,7 @@ struct kmem_cache *stub_priv_cache;
> static struct bus_id_priv busid_table[MAX_BUSID];
> static spinlock_t busid_table_lock;
>
> -int match_busid(const char *busid)
> +static int match_busid(const char *busid)
> {
> int i;
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-06-08 5:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-30 20:09 [PATCH] usbip: change match_busid() to local function Németh Márton
2011-06-07 21:31 ` Greg KH
2011-06-08 4:53 ` Németh Márton
2011-06-08 5:05 ` Németh Márton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).