From: Guenter Roeck <linux@roeck-us.net>
To: Zev Weiss <zev@bewilderbeest.net>, linux-hwmon@vger.kernel.org
Cc: Renze Nicolai <renze@rnplus.nl>, Jean Delvare <jdelvare@suse.com>,
Denis Pauk <pauk.denis@gmail.com>,
Bernhard Seibold <mail@bernhard-seibold.de>,
Oleksandr Natalenko <oleksandr@natalenko.name>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (nct6775) add support for TSI temperature registers
Date: Fri, 10 Dec 2021 12:58:29 -0800 [thread overview]
Message-ID: <50008074-7dbf-2521-8e75-caf97a85b38e@roeck-us.net> (raw)
In-Reply-To: <YbMM63VKYBTmZYiX@hatter.bewilderbeest.net>
On 12/10/21 12:16 AM, Zev Weiss wrote:
> On Wed, Nov 10, 2021 at 03:14:39PM PST, Zev Weiss wrote:
>> These registers report CPU temperatures (and, depending on the system,
>> sometimes chipset temperatures) via the TSI interface on AMD systems.
>> They're distinct from most of the other Super-IO temperature readings
>> (CPUTIN, SYSTIN, etc.) in that they're not a selectable source for
>> monitoring and are in a different (higher resolution) format, but can
>> still provide useful temperature data.
>>
>> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
>> Tested-by: Renze Nicolai <renze@rnplus.nl>
>> ---
>>
>> This patch has been tested on NCT6779 and NCT6798[1] hardware on
>> (respectively) ASRock Rack ROMED8HM3 and X570D4U boards, and seems to
>> work as expected; the implementation for the other chips supported by
>> the driver is purely based on the datasheets and has not been tested
>> (for lack of available hardware).
>>
>> [1] Or at least, its chip ID registers identify it as an NCT6798 and
>> it seems to behave consistently with that, though it's actually
>> physically labeled as an NCT6796.
>>
>> drivers/hwmon/nct6775.c | 136 ++++++++++++++++++++++++++++++++++++++--
>> 1 file changed, 130 insertions(+), 6 deletions(-)
>>
>
> Ping...any thoughts/feedback on this patch?
>
I don't want to apply the patch without testing it first, and I did
not find the time to do that.
Guenter
next prev parent reply other threads:[~2021-12-10 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 23:14 [PATCH] hwmon: (nct6775) add support for TSI temperature registers Zev Weiss
2021-12-10 8:16 ` Zev Weiss
2021-12-10 20:58 ` Guenter Roeck [this message]
2021-12-17 21:40 ` Guenter Roeck
2021-12-19 6:29 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50008074-7dbf-2521-8e75-caf97a85b38e@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@bernhard-seibold.de \
--cc=oleksandr@natalenko.name \
--cc=pauk.denis@gmail.com \
--cc=renze@rnplus.nl \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).