From: Zev Weiss <zev@bewilderbeest.net>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, Renze Nicolai <renze@rnplus.nl>,
Jean Delvare <jdelvare@suse.com>,
Denis Pauk <pauk.denis@gmail.com>,
Bernhard Seibold <mail@bernhard-seibold.de>,
Oleksandr Natalenko <oleksandr@natalenko.name>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (nct6775) add support for TSI temperature registers
Date: Sat, 18 Dec 2021 22:29:42 -0800 [thread overview]
Message-ID: <Yb7RVu6fQc+tLIAg@hatter.bewilderbeest.net> (raw)
In-Reply-To: <20211217214043.GA489498@roeck-us.net>
On Fri, Dec 17, 2021 at 01:40:43PM PST, Guenter Roeck wrote:
>On Wed, Nov 10, 2021 at 03:14:39PM -0800, Zev Weiss wrote:
>> @@ -1490,6 +1516,7 @@ static bool is_word_sized(struct nct6775_data
>> *data, u16 reg)
>> (reg & 0x00ff) == 0x55)) ||
>> (reg & 0xfff0) == 0x630 ||
>> reg == 0x402 ||
>> + (reg >= 0x409 && reg <= 0x419 && (reg & 1)) ||
>> reg == 0x640 || reg == 0x642 ||
>> ((reg & 0xfff0) == 0x650 && (reg & 0x000f) >= 0x06) ||
>> reg == 0x73 || reg == 0x75 || reg == 0x77;
>> @@ -1497,13 +1524,18 @@ static bool is_word_sized(struct nct6775_data *data, u16 reg)
>> case nct6791:
>> case nct6792:
>> case nct6793:
>> + num_tsi_regs = ARRAY_SIZE(NCT6776_REG_TSI_TEMP);
>> + goto check;
>
>This is unnecessarily pendantic. We did not do that for other chips
>with different array sizes, and we should not start doing it for this
>unless there is evidence that the same registers are 8-bit wide for
>some of the chips (instead of being unused).
>
Ack, will fix in v2 -- thanks for the review.
Zev
prev parent reply other threads:[~2021-12-19 6:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 23:14 [PATCH] hwmon: (nct6775) add support for TSI temperature registers Zev Weiss
2021-12-10 8:16 ` Zev Weiss
2021-12-10 20:58 ` Guenter Roeck
2021-12-17 21:40 ` Guenter Roeck
2021-12-19 6:29 ` Zev Weiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yb7RVu6fQc+tLIAg@hatter.bewilderbeest.net \
--to=zev@bewilderbeest.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mail@bernhard-seibold.de \
--cc=oleksandr@natalenko.name \
--cc=pauk.denis@gmail.com \
--cc=renze@rnplus.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).