* [RESEND PATCH v2] dt: bindings: as3645a: Fix the example node
@ 2017-12-08 15:55 Dan Murphy
2017-12-08 15:56 ` Dan Murphy
0 siblings, 1 reply; 3+ messages in thread
From: Dan Murphy @ 2017-12-08 15:55 UTC (permalink / raw)
To: robh+dt, mark.rutland, rpurdie, jacek.anaszewski, pavel
Cc: devicetree, linux-kernel, linux-leds, Dan Murphy
Fix the address-cells and size-cells example node
to reflect to the correct representation.
Signed-off-by: Dan Murphy <dmurphy@ti.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
v2 - Moved compatible to be first in the node - https://patchwork.kernel.org/patch/10092937/
Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
index fdc40e354a64..fc7f5f9f234c 100644
--- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
+++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
@@ -59,10 +59,10 @@ Example
=======
as3645a@30 {
- #address-cells: 1
- #size-cells: 0
- reg = <0x30>;
compatible = "ams,as3645a";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x30>;
flash@0 {
reg = <0x0>;
flash-timeout-us = <150000>;
--
2.15.0.124.g7668cbc60
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH v2] dt: bindings: as3645a: Fix the example node
2017-12-08 15:55 [RESEND PATCH v2] dt: bindings: as3645a: Fix the example node Dan Murphy
@ 2017-12-08 15:56 ` Dan Murphy
2017-12-15 20:26 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Dan Murphy @ 2017-12-08 15:56 UTC (permalink / raw)
To: robh+dt, mark.rutland, rpurdie, jacek.anaszewski, pavel
Cc: devicetree, linux-kernel, linux-leds
Resent to include DT maintainers
On 12/08/2017 09:55 AM, Dan Murphy wrote:
> Fix the address-cells and size-cells example node
> to reflect to the correct representation.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
>
> v2 - Moved compatible to be first in the node - https://patchwork.kernel.org/patch/10092937/
>
> Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> index fdc40e354a64..fc7f5f9f234c 100644
> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> @@ -59,10 +59,10 @@ Example
> =======
>
> as3645a@30 {
Rob
Here is an example of the device name being part of the node name.
Should this be changed as well to leds@30?
Dan
> - #address-cells: 1
> - #size-cells: 0
> - reg = <0x30>;
> compatible = "ams,as3645a";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x30>;
> flash@0 {
> reg = <0x0>;
> flash-timeout-us = <150000>;
>
--
------------------
Dan Murphy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH v2] dt: bindings: as3645a: Fix the example node
2017-12-08 15:56 ` Dan Murphy
@ 2017-12-15 20:26 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2017-12-15 20:26 UTC (permalink / raw)
To: Dan Murphy
Cc: mark.rutland, rpurdie, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds
On Fri, Dec 08, 2017 at 09:56:18AM -0600, Dan Murphy wrote:
> Resent to include DT maintainers
>
> On 12/08/2017 09:55 AM, Dan Murphy wrote:
> > Fix the address-cells and size-cells example node
> > to reflect to the correct representation.
> >
> > Signed-off-by: Dan Murphy <dmurphy@ti.com>
> > Acked-by: Pavel Machek <pavel@ucw.cz>
> > ---
> >
> > v2 - Moved compatible to be first in the node - https://patchwork.kernel.org/patch/10092937/
> >
> > Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> > index fdc40e354a64..fc7f5f9f234c 100644
> > --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> > +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> > @@ -59,10 +59,10 @@ Example
> > =======
> >
> > as3645a@30 {
>
> Rob
>
> Here is an example of the device name being part of the node name.
>
> Should this be changed as well to leds@30?
Yes, but I misspoke earlier and it should be "led-controller@30"
That can be a separate patch though, so for this one:
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-15 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-08 15:55 [RESEND PATCH v2] dt: bindings: as3645a: Fix the example node Dan Murphy
2017-12-08 15:56 ` Dan Murphy
2017-12-15 20:26 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).