[PATCH 0/3] HID: hid-input: Simplify expression and suppress gcc warning

[PATCH 0/3] HID: hid-input: Simplify expression and suppress gcc warning

[James C Boyd]

This patch set simplifies and formats an expression
as well as suppress a gcc warning.

James C Boyd (3):
  HID: hid-input: Add parenthesis to suppress gcc warning
  HID: hid-input: Simplified conditional expression
  HID: hid-input: Fix coding style issue

 drivers/hid/hid-input.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
--

[PATCH 1/3] HID: hid-input: Add parentheses to quell gcc warning

[James C Boyd]

GCC reports a -Wlogical-not-parentheses warning here; therefore
add parentheses to shut it up and to express our intent more.

Signed-off-by: James C Boyd <jcboyd.dev@gmail.com>
---
 drivers/hid/hid-input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 008e89b..714b758 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -1157,7 +1157,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
 		return;
 
 	/* report the usage code as scancode if the key status has changed */
-	if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value)
+	if (usage->type == EV_KEY && (!!test_bit(usage->code, input->key)) != value)
 		input_event(input, EV_MSC, MSC_SCAN, usage->hid);
 
 	input_event(input, usage->type, usage->code, value);
--

[PATCH 2/3] HID: hid-input: Simplify conditional expression

[James C Boyd]

There are too many bangs in this conditional; therefore
remove them while still maintaining the same logic.

Signed-off-by: James C Boyd <jcboyd.dev@gmail.com>
---
 drivers/hid/hid-input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 714b758..abf4fc6 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -1157,7 +1157,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
 		return;
 
 	/* report the usage code as scancode if the key status has changed */
-	if (usage->type == EV_KEY && (!!test_bit(usage->code, input->key)) != value)
+	if (usage->type == EV_KEY && (!test_bit(usage->code, input->key)) == value)
 		input_event(input, EV_MSC, MSC_SCAN, usage->hid);
 
 	input_event(input, usage->type, usage->code, value);
-- 

[PATCH 3/3] HID: hid-input: Fix coding style issue

[James C Boyd]

This line is too long; split it up.

Signed-off-by: James C Boyd <jcboyd.dev@gmail.com>
---
 drivers/hid/hid-input.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index abf4fc6..3511bbab 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -1157,7 +1157,8 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
 		return;
 
 	/* report the usage code as scancode if the key status has changed */
-	if (usage->type == EV_KEY && (!test_bit(usage->code, input->key)) == value)
+	if (usage->type == EV_KEY &&
+	    (!test_bit(usage->code, input->key)) == value)
 		input_event(input, EV_MSC, MSC_SCAN, usage->hid);
 
 	input_event(input, usage->type, usage->code, value);
-- 

Re: [PATCH 0/3] HID: hid-input: Simplify expression and suppress gcc warning

[James C Boyd]

On Wed, May 27, 2015 at 07:17:17PM -0500, James C Boyd wrote:
>   HID: hid-input: Add parenthesis to suppress gcc warning

I suppose I should also mention that gcc-5.1 was reporting
this dumb warning. I'll resend the patch set with that detail
mentioned if you'd like.

Re: [PATCH 0/3] HID: hid-input: Simplify expression and suppress gcc warning

[Jiri Kosina]

On Wed, 27 May 2015, James C Boyd wrote:

> This patch set simplifies and formats an expression
> as well as suppress a gcc warning.

Applied to for-4.2/upstream. Thanks,

-- 
Jiri Kosina
SUSE Labs