From: Nathan Chancellor <nathan@kernel.org>
To: Bill Wendling <morbo@google.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
clang-built-linux@googlegroups.com,
Nick Desaulniers <ndesaulniers@google.com>,
Nilesh Javali <njavali@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v2 3/3] scsi: qla2xxx: remove unused variable 'status'
Date: Mon, 26 Jul 2021 13:40:10 -0700 [thread overview]
Message-ID: <52726cd7-48d0-4600-aac1-bc39fc60bf66@kernel.org> (raw)
In-Reply-To: <20210726201924.3202278-4-morbo@google.com>
On 7/26/2021 1:19 PM, 'Bill Wendling' via Clang Built Linux wrote:
> Fix the clang build warning:
>
> drivers/scsi/qla2xxx/qla_nx.c:2209:6: error: variable 'status' set but not used [-Werror,-Wunused-but-set-variable]
> int status = 0;
>
> Signed-off-by: Bill Wendling <morbo@google.com>
It has been unused since the function's introduction in commit
a9083016a531 ("[SCSI] qla2xxx: Add ISP82XX support.").
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/scsi/qla2xxx/qla_nx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c
> index 615e44af1ca6..11aad97dfca8 100644
> --- a/drivers/scsi/qla2xxx/qla_nx.c
> +++ b/drivers/scsi/qla2xxx/qla_nx.c
> @@ -2166,7 +2166,6 @@ qla82xx_poll(int irq, void *dev_id)
> struct qla_hw_data *ha;
> struct rsp_que *rsp;
> struct device_reg_82xx __iomem *reg;
> - int status = 0;
> uint32_t stat;
> uint32_t host_int = 0;
> uint16_t mb[8];
> @@ -2195,7 +2194,6 @@ qla82xx_poll(int irq, void *dev_id)
> case 0x10:
> case 0x11:
> qla82xx_mbx_completion(vha, MSW(stat));
> - status |= MBX_INTERRUPT;
> break;
> case 0x12:
> mb[0] = MSW(stat);
>
next prev parent reply other threads:[~2021-07-26 20:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 9:17 [PATCH 0/3] Fix clang -Wunused-but-set-variable warnings Bill Wendling
2021-07-14 9:17 ` [PATCH 1/3] base: remove unused variable 'no_warn' Bill Wendling
2021-07-14 12:15 ` kernel test robot
2021-07-14 9:17 ` [PATCH 2/3] bnx2x: remove unused variable 'cur_data_offset' Bill Wendling
2021-07-14 9:17 ` [PATCH 3/3] scsi: qla2xxx: remove unused variable 'status' Bill Wendling
2021-07-26 20:19 ` [PATCH v2 0/3] Fix clang -Wunused-but-set-variable warnings Bill Wendling
2021-07-26 20:19 ` [PATCH v2 1/3] base: mark 'no_warn' as unused Bill Wendling
2021-07-26 20:47 ` Nathan Chancellor
2021-07-26 21:01 ` Bill Wendling
2021-07-27 5:27 ` Greg Kroah-Hartman
2021-07-27 6:15 ` Bill Wendling
2021-07-27 6:41 ` Greg Kroah-Hartman
2021-07-27 7:08 ` Bill Wendling
2021-07-27 7:12 ` Greg Kroah-Hartman
2021-07-27 7:15 ` Bill Wendling
2021-07-27 17:39 ` Nick Desaulniers
2021-07-27 17:42 ` Nick Desaulniers
2021-07-27 17:59 ` Greg Kroah-Hartman
2021-07-27 18:31 ` Nick Desaulniers
2021-07-27 18:44 ` Greg Kroah-Hartman
2021-07-27 19:02 ` Nick Desaulniers
2021-07-27 19:23 ` Bill Wendling
2021-07-27 20:13 ` Segher Boessenkool
2021-07-27 20:22 ` Bill Wendling
2021-07-27 20:24 ` Bill Wendling
2021-07-27 18:32 ` Nathan Chancellor
2021-07-27 19:04 ` Nick Desaulniers
2021-07-27 19:10 ` Nathan Chancellor
2021-07-27 19:12 ` Bill Wendling
2021-07-26 20:19 ` [PATCH v2 2/3] bnx2x: remove unused variable 'cur_data_offset' Bill Wendling
2021-07-26 20:36 ` Nathan Chancellor
2021-07-26 20:19 ` [PATCH v2 3/3] scsi: qla2xxx: remove unused variable 'status' Bill Wendling
2021-07-26 20:40 ` Nathan Chancellor [this message]
2021-07-27 3:14 ` Martin K. Petersen
2021-07-29 3:38 ` [PATCH v2 0/3] Fix clang -Wunused-but-set-variable warnings Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52726cd7-48d0-4600-aac1-bc39fc60bf66@kernel.org \
--to=nathan@kernel.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=clang-built-linux@googlegroups.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).