From: Nathan Chancellor <nathan@kernel.org>
To: Bill Wendling <morbo@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] base: mark 'no_warn' as unused
Date: Mon, 26 Jul 2021 13:47:33 -0700 [thread overview]
Message-ID: <c965006c-88e1-3265-eb9c-76dc0bbcb733@kernel.org> (raw)
In-Reply-To: <20210726201924.3202278-2-morbo@google.com>
+ Greg and Rafael as the maintainer and reviewer of
drivers/base/module.c respectively, drop everyone else.
Original post:
https://lore.kernel.org/r/20210726201924.3202278-2-morbo@google.com/
On 7/26/2021 1:19 PM, 'Bill Wendling' via Clang Built Linux wrote:
> Fix the following build warning:
>
> drivers/base/module.c:36:6: error: variable 'no_warn' set but not used [-Werror,-Wunused-but-set-variable]
> int no_warn;
>
> This variable is used to remove another warning, but causes a warning
> itself. Mark it as 'unused' to avoid that.
>
> Signed-off-by: Bill Wendling <morbo@google.com>
Even though they evaluate to the same thing, it might be worth using
"__always_unused" here because it is :)
Regardless:
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/base/module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/module.c b/drivers/base/module.c
> index 46ad4d636731..10494336d601 100644
> --- a/drivers/base/module.c
> +++ b/drivers/base/module.c
> @@ -33,7 +33,7 @@ static void module_create_drivers_dir(struct module_kobject *mk)
> void module_add_driver(struct module *mod, struct device_driver *drv)
> {
> char *driver_name;
> - int no_warn;
> + int __maybe_unused no_warn;
> struct module_kobject *mk = NULL;
>
> if (!drv)
>
next prev parent reply other threads:[~2021-07-26 20:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 9:17 [PATCH 0/3] Fix clang -Wunused-but-set-variable warnings Bill Wendling
2021-07-14 9:17 ` [PATCH 1/3] base: remove unused variable 'no_warn' Bill Wendling
2021-07-14 12:15 ` kernel test robot
2021-07-14 9:17 ` [PATCH 2/3] bnx2x: remove unused variable 'cur_data_offset' Bill Wendling
2021-07-14 9:17 ` [PATCH 3/3] scsi: qla2xxx: remove unused variable 'status' Bill Wendling
2021-07-26 20:19 ` [PATCH v2 0/3] Fix clang -Wunused-but-set-variable warnings Bill Wendling
2021-07-26 20:19 ` [PATCH v2 1/3] base: mark 'no_warn' as unused Bill Wendling
2021-07-26 20:47 ` Nathan Chancellor [this message]
2021-07-26 21:01 ` Bill Wendling
2021-07-27 5:27 ` Greg Kroah-Hartman
2021-07-27 6:15 ` Bill Wendling
2021-07-27 6:41 ` Greg Kroah-Hartman
2021-07-27 7:08 ` Bill Wendling
2021-07-27 7:12 ` Greg Kroah-Hartman
2021-07-27 7:15 ` Bill Wendling
2021-07-27 17:39 ` Nick Desaulniers
2021-07-27 17:42 ` Nick Desaulniers
2021-07-27 17:59 ` Greg Kroah-Hartman
2021-07-27 18:31 ` Nick Desaulniers
2021-07-27 18:44 ` Greg Kroah-Hartman
2021-07-27 19:02 ` Nick Desaulniers
2021-07-27 19:23 ` Bill Wendling
2021-07-27 20:13 ` Segher Boessenkool
2021-07-27 20:22 ` Bill Wendling
2021-07-27 20:24 ` Bill Wendling
2021-07-27 18:32 ` Nathan Chancellor
2021-07-27 19:04 ` Nick Desaulniers
2021-07-27 19:10 ` Nathan Chancellor
2021-07-27 19:12 ` Bill Wendling
2021-07-26 20:19 ` [PATCH v2 2/3] bnx2x: remove unused variable 'cur_data_offset' Bill Wendling
2021-07-26 20:36 ` Nathan Chancellor
2021-07-26 20:19 ` [PATCH v2 3/3] scsi: qla2xxx: remove unused variable 'status' Bill Wendling
2021-07-26 20:40 ` Nathan Chancellor
2021-07-27 3:14 ` Martin K. Petersen
2021-07-29 3:38 ` [PATCH v2 0/3] Fix clang -Wunused-but-set-variable warnings Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c965006c-88e1-3265-eb9c-76dc0bbcb733@kernel.org \
--to=nathan@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).