* [PATCH] staging: comedi: Kconfig: make COMEDI_BOND select COMEDI_KCOMEDILIB
@ 2014-08-27 19:19 Ian Abbott
2014-08-27 19:26 ` Randy Dunlap
2014-08-27 19:37 ` [PATCH v2] " Ian Abbott
0 siblings, 2 replies; 3+ messages in thread
From: Ian Abbott @ 2014-08-27 19:19 UTC (permalink / raw)
To: devel; +Cc: Greg Kroah-Hartman, H Hartley Sweeten, linux-kernel, Ian Abbott
Currently, to select the "comedi_bond" driver, the "kcomedilib" support
has to be selected first. It seems more natural to allow the
"comedi_bond" driver to be selected on its own and to automatically
select the "kcomedilib" module as a result of that. Change the
dependency/select relationship between the two configuration options to
do that.
Also, make "kcomedilib" a module that can be selected independently,
perhaps for use by out-of-tree modules, although it is not terribly
useful for anything other than "comedi_bond" currently.
Also, improve the help text for the config options.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
---
drivers/staging/comedi/Kconfig | 25 ++++++++++++++++++-------
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index 7d6cebc..c18e6e9 100644
--- a/drivers/staging/comedi/Kconfig
+++ b/drivers/staging/comedi/Kconfig
@@ -42,18 +42,15 @@ menuconfig COMEDI_MISC_DRIVERS
if COMEDI_MISC_DRIVERS
-config COMEDI_KCOMEDILIB
- tristate "Comedi kcomedilib"
- ---help---
- Build the kcomedilib
-
config COMEDI_BOND
- tristate "Device bonding support"
- depends on COMEDI_KCOMEDILIB
+ tristate "Comedi device bonding support"
+ select COMEDI_KCOMEDILIB
---help---
Enable support for a driver to 'bond' (merge) multiple subdevices
from multiple devices together as one.
+ Currently, it only handles digital I/O subdevices.
+
To compile this driver as a module, choose M here: the module will be
called comedi_bond.
@@ -1272,6 +1269,20 @@ config COMEDI_8255
To compile this driver as a module, choose M here: the module will be
called 8255.
+config COMEDI_KCOMEDILIB
+ tristate "Comedi kcomedilib"
+ ---help---
+ Build the kcomedilib.
+
+ This is a kernel module used to open and manipulate Comedi devices
+ from within kernel code. It is currently only used by the
+ comedi_bond driver, and it's functionality has been stripped
+ down to the needs of that driver, so is currently not very useful
+ for anything else.
+
+ To compile kcomedilib as a module, choose M here: the module will be
+ called kcomedilib.
+
config COMEDI_FC
tristate
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: comedi: Kconfig: make COMEDI_BOND select COMEDI_KCOMEDILIB
2014-08-27 19:19 [PATCH] staging: comedi: Kconfig: make COMEDI_BOND select COMEDI_KCOMEDILIB Ian Abbott
@ 2014-08-27 19:26 ` Randy Dunlap
2014-08-27 19:37 ` [PATCH v2] " Ian Abbott
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2014-08-27 19:26 UTC (permalink / raw)
To: Ian Abbott, devel; +Cc: Greg Kroah-Hartman, H Hartley Sweeten, linux-kernel
On 08/27/14 12:19, Ian Abbott wrote:
> Currently, to select the "comedi_bond" driver, the "kcomedilib" support
> has to be selected first. It seems more natural to allow the
> "comedi_bond" driver to be selected on its own and to automatically
> select the "kcomedilib" module as a result of that. Change the
> dependency/select relationship between the two configuration options to
> do that.
>
> Also, make "kcomedilib" a module that can be selected independently,
> perhaps for use by out-of-tree modules, although it is not terribly
> useful for anything other than "comedi_bond" currently.
>
> Also, improve the help text for the config options.
>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> ---
> drivers/staging/comedi/Kconfig | 25 ++++++++++++++++++-------
> 1 file changed, 18 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
> index 7d6cebc..c18e6e9 100644
> --- a/drivers/staging/comedi/Kconfig
> +++ b/drivers/staging/comedi/Kconfig
> @@ -42,18 +42,15 @@ menuconfig COMEDI_MISC_DRIVERS
>
> if COMEDI_MISC_DRIVERS
>
> -config COMEDI_KCOMEDILIB
> - tristate "Comedi kcomedilib"
> - ---help---
> - Build the kcomedilib
> -
> config COMEDI_BOND
> - tristate "Device bonding support"
> - depends on COMEDI_KCOMEDILIB
> + tristate "Comedi device bonding support"
> + select COMEDI_KCOMEDILIB
> ---help---
> Enable support for a driver to 'bond' (merge) multiple subdevices
> from multiple devices together as one.
>
> + Currently, it only handles digital I/O subdevices.
> +
> To compile this driver as a module, choose M here: the module will be
> called comedi_bond.
>
> @@ -1272,6 +1269,20 @@ config COMEDI_8255
> To compile this driver as a module, choose M here: the module will be
> called 8255.
>
> +config COMEDI_KCOMEDILIB
> + tristate "Comedi kcomedilib"
> + ---help---
> + Build the kcomedilib.
> +
> + This is a kernel module used to open and manipulate Comedi devices
> + from within kernel code. It is currently only used by the
> + comedi_bond driver, and it's functionality has been stripped
its
> + down to the needs of that driver, so is currently not very useful
> + for anything else.
> +
> + To compile kcomedilib as a module, choose M here: the module will be
> + called kcomedilib.
> +
> config COMEDI_FC
> tristate
>
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] staging: comedi: Kconfig: make COMEDI_BOND select COMEDI_KCOMEDILIB
2014-08-27 19:19 [PATCH] staging: comedi: Kconfig: make COMEDI_BOND select COMEDI_KCOMEDILIB Ian Abbott
2014-08-27 19:26 ` Randy Dunlap
@ 2014-08-27 19:37 ` Ian Abbott
1 sibling, 0 replies; 3+ messages in thread
From: Ian Abbott @ 2014-08-27 19:37 UTC (permalink / raw)
To: devel; +Cc: Greg Kroah-Hartman, H Hartley Sweeten, linux-kernel, Ian Abbott
Currently, to select the "comedi_bond" driver, the "kcomedilib" support
has to be selected first. It seems more natural to allow the
"comedi_bond" driver to be selected on its own and to automatically
select the "kcomedilib" module as a result of that. Change the
dependency/select relationship between the two configuration options to
do that.
Also, make "kcomedilib" a module that can be selected independently,
perhaps for use by out-of-tree modules, although it is not terribly
useful for anything other than "comedi_bond" currently.
Also, improve the help text for the config options.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
---
v2: Fix a spelling/grammer issue in config description reported by Randy
Dunlap.
---
drivers/staging/comedi/Kconfig | 25 ++++++++++++++++++-------
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index 7d6cebc..beb5704 100644
--- a/drivers/staging/comedi/Kconfig
+++ b/drivers/staging/comedi/Kconfig
@@ -42,18 +42,15 @@ menuconfig COMEDI_MISC_DRIVERS
if COMEDI_MISC_DRIVERS
-config COMEDI_KCOMEDILIB
- tristate "Comedi kcomedilib"
- ---help---
- Build the kcomedilib
-
config COMEDI_BOND
- tristate "Device bonding support"
- depends on COMEDI_KCOMEDILIB
+ tristate "Comedi device bonding support"
+ select COMEDI_KCOMEDILIB
---help---
Enable support for a driver to 'bond' (merge) multiple subdevices
from multiple devices together as one.
+ Currently, it only handles digital I/O subdevices.
+
To compile this driver as a module, choose M here: the module will be
called comedi_bond.
@@ -1272,6 +1269,20 @@ config COMEDI_8255
To compile this driver as a module, choose M here: the module will be
called 8255.
+config COMEDI_KCOMEDILIB
+ tristate "Comedi kcomedilib"
+ ---help---
+ Build the kcomedilib.
+
+ This is a kernel module used to open and manipulate Comedi devices
+ from within kernel code. It is currently only used by the
+ comedi_bond driver, and its functionality has been stripped down to
+ the needs of that driver, so is currently not very useful for
+ anything else.
+
+ To compile kcomedilib as a module, choose M here: the module will be
+ called kcomedilib.
+
config COMEDI_FC
tristate
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-27 19:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-27 19:19 [PATCH] staging: comedi: Kconfig: make COMEDI_BOND select COMEDI_KCOMEDILIB Ian Abbott
2014-08-27 19:26 ` Randy Dunlap
2014-08-27 19:37 ` [PATCH v2] " Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).