[PATCH] staging: comedi: fix coding style issues

[PATCH] staging: comedi: fix coding style issues

[Geliang Tang]

1) Fixed an error found by checkpatch.pl.
   ERROR: space required after that ',' (ctx:VxV)
   ./drivers/ni_mio_common.c:3764
2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
   of this file.
3) The kernel version is next-20150515, 4.1.0-rc3.

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
index 9dfd4e6..6cc304a 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
 	if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
 		regmap = &ni_gpct_to_stc_regmap[reg];
 	} else {
-		dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
+		dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
 			 __func__, reg);
 		return 0;
 	}
-- 
2.3.4

Re: [PATCH] staging: comedi: fix coding style issues

[Ian Abbott]

On 16/05/15 05:16, Geliang Tang wrote:
> 1) Fixed an error found by checkpatch.pl.
>     ERROR: space required after that ',' (ctx:VxV)
>     ./drivers/ni_mio_common.c:3764
> 2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
>     of this file.
> 3) The kernel version is next-20150515, 4.1.0-rc3.

You shouldn't mention point 3 in the commit message as it will look a 
bit strange when it ends up in the commit log.  If you need to mention 
that, it should go after the commit message, separated from the patch by 
a "---" line like this:

Body of commit message goes here.

Signed off by and Cc lines go here.
---
Additional patch commentary goes here.
---
Actual patch goes here.

Git will ignore the additional commentary when the patch is applied.

>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
>   drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> index 9dfd4e6..6cc304a 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_common.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> @@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
>   	if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
>   		regmap = &ni_gpct_to_stc_regmap[reg];
>   	} else {
> -		dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
> +		dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
>   			 __func__, reg);
>   		return 0;
>   	}
>

Apart from that niggle, the patch looks good!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

[PATCH v2] staging: comedi: fix coding style issues

[Geliang Tang]

[-- Attachment #1: Type: text/plain, Size: 2009 bytes --]

On Mon, May 18, 2015 at 12:37:09PM +0100, Ian Abbott wrote:
> On 16/05/15 05:16, Geliang Tang wrote:
> >1) Fixed an error found by checkpatch.pl.
> >    ERROR: space required after that ',' (ctx:VxV)
> >    ./drivers/ni_mio_common.c:3764
> >2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
> >    of this file.
> >3) The kernel version is next-20150515, 4.1.0-rc3.
> 
> You shouldn't mention point 3 in the commit message as it will look a bit
> strange when it ends up in the commit log.  If you need to mention that, it
> should go after the commit message, separated from the patch by a "---" line
> like this:
> 
> Body of commit message goes here.
> 
> Signed off by and Cc lines go here.
> ---
> Additional patch commentary goes here.
> ---
> Actual patch goes here.
> 
> Git will ignore the additional commentary when the patch is applied.
> 
> >
> >Signed-off-by: Geliang Tang <geliangtang@163.com>
> >---
> >  drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> >index 9dfd4e6..6cc304a 100644
> >--- a/drivers/staging/comedi/drivers/ni_mio_common.c
> >+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> >@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
> >  	if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
> >  		regmap = &ni_gpct_to_stc_regmap[reg];
> >  	} else {
> >-		dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
> >+		dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
> >  			 __func__, reg);
> >  		return 0;
> >  	}
> >
> 
> Apart from that niggle, the patch looks good!
> 
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
> 
> -- 
> -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
> -=(                          Web: http://www.mev.co.uk/  )=-

Thank you for your review. I revised the patch as you suggested.
Here it is.

[-- Attachment #2: 0001-staging-comedi-fix-coding-style-issues.patch --]
[-- Type: text/plain, Size: 1309 bytes --]

>From d864f6af18a44031a241e10e64d98f9e6b8c0660 Mon Sep 17 00:00:00 2001
From: Geliang Tang <geliangtang@163.com>
Date: Wed, 20 May 2015 14:26:13 +0000
Subject: [PATCH v2] staging: comedi: fix coding style issues

1) Fixed an error found by checkpatch.pl.
   ERROR: space required after that ',' (ctx:VxV)
   ./drivers/ni_mio_common.c:3764
2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
   of this file.

Signed-off-by: Geliang Tang <geliangtang@163.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
---
Changes in v2:
  - remove the kernel version in the commit message.
---
 drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
index 9dfd4e6..6cc304a 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
 	if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
 		regmap = &ni_gpct_to_stc_regmap[reg];
 	} else {
-		dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
+		dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
 			 __func__, reg);
 		return 0;
 	}
-- 
2.3.4

Re: [PATCH v2] staging: comedi: fix coding style issues

[Greg KH]

On Wed, May 20, 2015 at 02:54:16PM +0000, Geliang Tang wrote:
> On Mon, May 18, 2015 at 12:37:09PM +0100, Ian Abbott wrote:
> > On 16/05/15 05:16, Geliang Tang wrote:
> > >1) Fixed an error found by checkpatch.pl.
> > >    ERROR: space required after that ',' (ctx:VxV)
> > >    ./drivers/ni_mio_common.c:3764
> > >2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
> > >    of this file.
> > >3) The kernel version is next-20150515, 4.1.0-rc3.
> > 
> > You shouldn't mention point 3 in the commit message as it will look a bit
> > strange when it ends up in the commit log.  If you need to mention that, it
> > should go after the commit message, separated from the patch by a "---" line
> > like this:
> > 
> > Body of commit message goes here.
> > 
> > Signed off by and Cc lines go here.
> > ---
> > Additional patch commentary goes here.
> > ---
> > Actual patch goes here.
> > 
> > Git will ignore the additional commentary when the patch is applied.
> > 
> > >
> > >Signed-off-by: Geliang Tang <geliangtang@163.com>
> > >---
> > >  drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> > >index 9dfd4e6..6cc304a 100644
> > >--- a/drivers/staging/comedi/drivers/ni_mio_common.c
> > >+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> > >@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
> > >  	if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
> > >  		regmap = &ni_gpct_to_stc_regmap[reg];
> > >  	} else {
> > >-		dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
> > >+		dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
> > >  			 __func__, reg);
> > >  		return 0;
> > >  	}
> > >
> > 
> > Apart from that niggle, the patch looks good!
> > 
> > Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
> > 
> > -- 
> > -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
> > -=(                          Web: http://www.mev.co.uk/  )=-
> 
> Thank you for your review. I revised the patch as you suggested.
> Here it is.

> >From d864f6af18a44031a241e10e64d98f9e6b8c0660 Mon Sep 17 00:00:00 2001
> From: Geliang Tang <geliangtang@163.com>
> Date: Wed, 20 May 2015 14:26:13 +0000
> Subject: [PATCH v2] staging: comedi: fix coding style issues
> 
> 1) Fixed an error found by checkpatch.pl.
>    ERROR: space required after that ',' (ctx:VxV)
>    ./drivers/ni_mio_common.c:3764
> 2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
>    of this file.

That's multiple things in one patch :(

Also, this is an attachment, which I can't apply, please resend it as a
proper email.

thanks,

greg k-h

[PATCH v3 0/2] staging: comedi: fix coding style issues

[Geliang Tang]

On Sun, May 24, 2015 at 01:11:08PM -0700, Greg KH wrote:
> That's multiple things in one patch :(
> 
> Also, this is an attachment, which I can't apply, please resend it as a
> proper email.

Thanks for your reply. I split it into two patches, as you suggested.
Here are them.

---
Changes in v3: 
  - split it into two patches.

Changes in v2: 
  - remove the kernel version in the commit message.
---

Geliang Tang (2):
  staging: comedi: fix checkpatch error
  staging: comedi: keep the consistency

 drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.3.4

[PATCH v3 1/2] staging: comedi: fix checkpatch error

[Geliang Tang]

Fixed an error found by checkpatch.pl.
ERROR: space required after that ',' (ctx:VxV)
./drivers/ni_mio_common.c:3764

Signed-off-by: Geliang Tang <geliangtang@163.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
---
 drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
index 9dfd4e6..f01ef89 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
 	if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
 		regmap = &ni_gpct_to_stc_regmap[reg];
 	} else {
-		dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n",
+		dev_warn(dev->class_dev, "%s: unhandled register 0x%x\n",
 			 __func__, reg);
 		return 0;
 	}
-- 
2.3.4

[PATCH v3 2/2] staging: comedi: keep the consistency

[Geliang Tang]

Changed "register 0x%x" to "register=0x%x" to keep the consistency
of this file.

Signed-off-by: Geliang Tang <geliangtang@163.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
---
 drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
index f01ef89..6cc304a 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev,
 	if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) {
 		regmap = &ni_gpct_to_stc_regmap[reg];
 	} else {
-		dev_warn(dev->class_dev, "%s: unhandled register 0x%x\n",
+		dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n",
 			 __func__, reg);
 		return 0;
 	}
-- 
2.3.4

Re: [PATCH] Staging: comedi: Fix coding style issues

[punit vara]

On Sun, Sep 20, 2015 at 6:50 AM, Jaime Arrocha <jarr@innercoder.com> wrote:
>
> On 09/19/2015 01:13 PM, punit vara wrote:
>>
>> [PATCH] Staging: comedi: Fix block comment warning
>
>
> [PATCH] Staging: comedi: Coding style warnings fix for block comments
>


Thank you for suggestion sir .I would appreciate your help.

Re: [PATCH] Staging: comedi: Fix coding style issues

[Jaime Arrocha]

On 09/19/2015 01:13 PM, punit vara wrote:
> [PATCH] Staging: comedi: Fix block comment warning

[PATCH] Staging: comedi: Coding style warnings fix for block comments

Re: [PATCH] Staging: comedi: Fix coding style issues

[punit vara]

On Fri, Sep 18, 2015 at 10:22 PM, Punit Vara <punitvara@gmail.com> wrote:
> This patch is to comedidev.h file that fixes up following warnings
> reported by checkpatch.pl :
>
> -Block comments use a trailing */ on a separate line
> -Block comments use * on subsequent lines
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
>  drivers/staging/comedi/comedidev.h | 62 ++++++++++++++++++++------------------
>  1 file changed, 32 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 28a5d3a..5b0ab03 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -1,20 +1,20 @@
>  /*
> -    include/linux/comedidev.h
> -    header file for kernel-only structures, variables, and constants
> -
> -    COMEDI - Linux Control and Measurement Device Interface
> -    Copyright (C) 1997-2000 David A. Schleef <ds@schleef.org>
> -
> -    This program is free software; you can redistribute it and/or modify
> -    it under the terms of the GNU General Public License as published by
> -    the Free Software Foundation; either version 2 of the License, or
> -    (at your option) any later version.
> -
> -    This program is distributed in the hope that it will be useful,
> -    but WITHOUT ANY WARRANTY; without even the implied warranty of
> -    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> -    GNU General Public License for more details.
> -*/
> + * include/linux/comedidev.h
> + * header file for kernel-only structures, variables, and constants
> + *
> + * COMEDI - Linux Control and Measurement Device Interface
> + * Copyright (C) 1997-2000 David A. Schleef <ds@schleef.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
>
>  #ifndef _COMEDIDEV_H
>  #define _COMEDIDEV_H
> @@ -105,7 +105,7 @@ struct comedi_buf_map {
>         struct kref refcount;
>  };
>
> -/**
> +/*
>   * struct comedi_async - control data for asynchronous comedi commands
>   * @prealloc_buf:      preallocated buffer
>   * @prealloc_bufsz:    buffer size (in bytes)
> @@ -215,7 +215,7 @@ struct comedi_async {
>                        unsigned int x);
>  };
>
> -/**
> +/*
>   * comedi_async callback "events"
>   * @COMEDI_CB_EOS:             end-of-scan
>   * @COMEDI_CB_EOA:             end-of-acquisition/output
> @@ -262,9 +262,11 @@ struct comedi_device {
>         struct device *class_dev;
>         int minor;
>         unsigned int detach_count;
> -       /* hw_dev is passed to dma_alloc_coherent when allocating async buffers
> +       /*
> +        * hw_dev is passed to dma_alloc_coherent when allocating async buffers
>          * for subdevices that have async_dma_dir set to something other than
> -        * DMA_NONE */
> +        * DMA_NONE
> +        */
>         struct device *hw_dev;
>
>         const char *board_name;
> @@ -391,7 +393,7 @@ static inline unsigned int comedi_offset_munge(struct comedi_subdevice *s,
>         return val ^ s->maxdata ^ (s->maxdata >> 1);
>  }
>
> -/**
> +/*
>   * comedi_bytes_per_sample - determine subdevice sample size
>   * @s:         comedi_subdevice struct
>   *
> @@ -405,7 +407,7 @@ static inline unsigned int comedi_bytes_per_sample(struct comedi_subdevice *s)
>         return s->subdev_flags & SDF_LSAMPL ? sizeof(int) : sizeof(short);
>  }
>
> -/**
> +/*
>   * comedi_sample_shift - determine log2 of subdevice sample size
>   * @s:         comedi_subdevice struct
>   *
> @@ -421,7 +423,7 @@ static inline unsigned int comedi_sample_shift(struct comedi_subdevice *s)
>         return s->subdev_flags & SDF_LSAMPL ? 2 : 1;
>  }
>
> -/**
> +/*
>   * comedi_bytes_to_samples - converts a number of bytes to a number of samples
>   * @s:         comedi_subdevice struct
>   * @nbytes:    number of bytes
> @@ -434,7 +436,7 @@ static inline unsigned int comedi_bytes_to_samples(struct comedi_subdevice *s,
>         return nbytes >> comedi_sample_shift(s);
>  }
>
> -/**
> +/*
>   * comedi_samples_to_bytes - converts a number of samples to a number of bytes
>   * @s:         comedi_subdevice struct
>   * @nsamples:  number of samples
> @@ -448,7 +450,7 @@ static inline unsigned int comedi_samples_to_bytes(struct comedi_subdevice *s,
>         return nsamples << comedi_sample_shift(s);
>  }
>
> -/**
> +/*
>   * comedi_check_trigger_src() - trivially validate a comedi_cmd trigger source
>   * @src: pointer to the trigger source to validate
>   * @flags: bitmask of valid TRIG_* for the trigger
> @@ -469,7 +471,7 @@ static inline int comedi_check_trigger_src(unsigned int *src,
>         return 0;
>  }
>
> -/**
> +/*
>   * comedi_check_trigger_is_unique() - make sure a trigger source is unique
>   * @src: the trigger source to check
>   */
> @@ -481,7 +483,7 @@ static inline int comedi_check_trigger_is_unique(unsigned int src)
>         return 0;
>  }
>
> -/**
> +/*
>   * comedi_check_trigger_arg_is() - trivially validate a trigger argument
>   * @arg: pointer to the trigger arg to validate
>   * @val: the value the argument should be
> @@ -496,7 +498,7 @@ static inline int comedi_check_trigger_arg_is(unsigned int *arg,
>         return 0;
>  }
>
> -/**
> +/*
>   * comedi_check_trigger_arg_min() - trivially validate a trigger argument
>   * @arg: pointer to the trigger arg to validate
>   * @val: the minimum value the argument should be
> @@ -511,7 +513,7 @@ static inline int comedi_check_trigger_arg_min(unsigned int *arg,
>         return 0;
>  }
>
> -/**
> +/*
>   * comedi_check_trigger_arg_max() - trivially validate a trigger argument
>   * @arg: pointer to the trigger arg to validate
>   * @val: the maximum value the argument should be
> @@ -604,7 +606,7 @@ void comedi_auto_unconfig(struct device *);
>  int comedi_driver_register(struct comedi_driver *);
>  void comedi_driver_unregister(struct comedi_driver *);
>
> -/**
> +/*
>   * module_comedi_driver() - Helper macro for registering a comedi driver
>   * @__comedi_driver: comedi_driver struct
>   *
> --
> 2.5.2
>


[PATCH] Staging: comedi: Fix block comment according to preferred style

[PATCH] Staging: comedi: Fix block comment warning

which would be the better subject for my patch ? anybody can suggest please ?

Re: [PATCH] Staging: comedi: Fix coding style issues

[punit vara]

[PATCH] Staging: comedi: Fix block comment according to preferred style

[PATCH] Staging: comedi: Fix block comment warning

which would be the better subject for my patch ? anybody can suggest please ?

regards,
punitvara

Re: [PATCH] Staging: comedi: Fix coding style issues

[Greg KH]

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Sat, Sep 19, 2015 at 09:57:43PM +0530, punit vara wrote:
> For this patch can I put subject like
> 
> [PATCH] Staging: comedi: Fix trailing */ and * comment warning
> 
> ??

Yes, that would be much better thanks.

greg k-h

Re: [PATCH] Staging: comedi: Fix coding style issues

[punit vara]

For this patch can I put subject like

[PATCH] Staging: comedi: Fix trailing */ and * comment warning

??
Kindly suggest me as this is my first patch and i am trying to
contribute to linux kernel .

On Fri, Sep 18, 2015 at 10:22 PM, Punit Vara <punitvara@gmail.com> wrote:
> This patch is to comedidev.h file that fixes up following warnings
> reported by checkpatch.pl :
>
> -Block comments use a trailing */ on a separate line
> -Block comments use * on subsequent lines
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
>  drivers/staging/comedi/comedidev.h | 62 ++++++++++++++++++++------------------
>  1 file changed, 32 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 28a5d3a..5b0ab03 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -1,20 +1,20 @@
>  /*
> -    include/linux/comedidev.h
> -    header file for kernel-only structures, variables, and constants
> -
> -    COMEDI - Linux Control and Measurement Device Interface
> -    Copyright (C) 1997-2000 David A. Schleef <ds@schleef.org>
> -
> -    This program is free software; you can redistribute it and/or modify
> -    it under the terms of the GNU General Public License as published by
> -    the Free Software Foundation; either version 2 of the License, or
> -    (at your option) any later version.
> -
> -    This program is distributed in the hope that it will be useful,
> -    but WITHOUT ANY WARRANTY; without even the implied warranty of
> -    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> -    GNU General Public License for more details.
> -*/
> + * include/linux/comedidev.h
> + * header file for kernel-only structures, variables, and constants
> + *
> + * COMEDI - Linux Control and Measurement Device Interface
> + * Copyright (C) 1997-2000 David A. Schleef <ds@schleef.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
>
>  #ifndef _COMEDIDEV_H
>  #define _COMEDIDEV_H
> @@ -105,7 +105,7 @@ struct comedi_buf_map {
>         struct kref refcount;
>  };
>
> -/**
> +/*
>   * struct comedi_async - control data for asynchronous comedi commands
>   * @prealloc_buf:      preallocated buffer
>   * @prealloc_bufsz:    buffer size (in bytes)
> @@ -215,7 +215,7 @@ struct comedi_async {
>                        unsigned int x);
>  };
>
> -/**
> +/*
>   * comedi_async callback "events"
>   * @COMEDI_CB_EOS:             end-of-scan
>   * @COMEDI_CB_EOA:             end-of-acquisition/output
> @@ -262,9 +262,11 @@ struct comedi_device {
>         struct device *class_dev;
>         int minor;
>         unsigned int detach_count;
> -       /* hw_dev is passed to dma_alloc_coherent when allocating async buffers
> +       /*
> +        * hw_dev is passed to dma_alloc_coherent when allocating async buffers
>          * for subdevices that have async_dma_dir set to something other than
> -        * DMA_NONE */
> +        * DMA_NONE
> +        */
>         struct device *hw_dev;
>
>         const char *board_name;
> @@ -391,7 +393,7 @@ static inline unsigned int comedi_offset_munge(struct comedi_subdevice *s,
>         return val ^ s->maxdata ^ (s->maxdata >> 1);
>  }
>
> -/**
> +/*
>   * comedi_bytes_per_sample - determine subdevice sample size
>   * @s:         comedi_subdevice struct
>   *
> @@ -405,7 +407,7 @@ static inline unsigned int comedi_bytes_per_sample(struct comedi_subdevice *s)
>         return s->subdev_flags & SDF_LSAMPL ? sizeof(int) : sizeof(short);
>  }
>
> -/**
> +/*
>   * comedi_sample_shift - determine log2 of subdevice sample size
>   * @s:         comedi_subdevice struct
>   *
> @@ -421,7 +423,7 @@ static inline unsigned int comedi_sample_shift(struct comedi_subdevice *s)
>         return s->subdev_flags & SDF_LSAMPL ? 2 : 1;
>  }
>
> -/**
> +/*
>   * comedi_bytes_to_samples - converts a number of bytes to a number of samples
>   * @s:         comedi_subdevice struct
>   * @nbytes:    number of bytes
> @@ -434,7 +436,7 @@ static inline unsigned int comedi_bytes_to_samples(struct comedi_subdevice *s,
>         return nbytes >> comedi_sample_shift(s);
>  }
>
> -/**
> +/*
>   * comedi_samples_to_bytes - converts a number of samples to a number of bytes
>   * @s:         comedi_subdevice struct
>   * @nsamples:  number of samples
> @@ -448,7 +450,7 @@ static inline unsigned int comedi_samples_to_bytes(struct comedi_subdevice *s,
>         return nsamples << comedi_sample_shift(s);
>  }
>
> -/**
> +/*
>   * comedi_check_trigger_src() - trivially validate a comedi_cmd trigger source
>   * @src: pointer to the trigger source to validate
>   * @flags: bitmask of valid TRIG_* for the trigger
> @@ -469,7 +471,7 @@ static inline int comedi_check_trigger_src(unsigned int *src,
>         return 0;
>  }
>
> -/**
> +/*
>   * comedi_check_trigger_is_unique() - make sure a trigger source is unique
>   * @src: the trigger source to check
>   */
> @@ -481,7 +483,7 @@ static inline int comedi_check_trigger_is_unique(unsigned int src)
>         return 0;
>  }
>
> -/**
> +/*
>   * comedi_check_trigger_arg_is() - trivially validate a trigger argument
>   * @arg: pointer to the trigger arg to validate
>   * @val: the value the argument should be
> @@ -496,7 +498,7 @@ static inline int comedi_check_trigger_arg_is(unsigned int *arg,
>         return 0;
>  }
>
> -/**
> +/*
>   * comedi_check_trigger_arg_min() - trivially validate a trigger argument
>   * @arg: pointer to the trigger arg to validate
>   * @val: the minimum value the argument should be
> @@ -511,7 +513,7 @@ static inline int comedi_check_trigger_arg_min(unsigned int *arg,
>         return 0;
>  }
>
> -/**
> +/*
>   * comedi_check_trigger_arg_max() - trivially validate a trigger argument
>   * @arg: pointer to the trigger arg to validate
>   * @val: the maximum value the argument should be
> @@ -604,7 +606,7 @@ void comedi_auto_unconfig(struct device *);
>  int comedi_driver_register(struct comedi_driver *);
>  void comedi_driver_unregister(struct comedi_driver *);
>
> -/**
> +/*
>   * module_comedi_driver() - Helper macro for registering a comedi driver
>   * @__comedi_driver: comedi_driver struct
>   *
> --
> 2.5.2
>



-- 
Regards,
Punit Vara
9033553488

Re: [PATCH] Staging: comedi: Fix coding style issues

[Greg KH]

On Fri, Sep 18, 2015 at 10:22:59PM +0530, Punit Vara wrote:
> This patch is to comedidev.h file that fixes up following warnings
> reported by checkpatch.pl :
> 
> -Block comments use a trailing */ on a separate line
> -Block comments use * on subsequent lines

Your subject needs to be very specific, please fix up.

thanks,

greg k-h

[PATCH] Staging: comedi: Fix coding style issues

[Punit Vara]

This patch is to comedidev.h file that fixes up following warnings
reported by checkpatch.pl :

-Block comments use a trailing */ on a separate line
-Block comments use * on subsequent lines

Signed-off-by: Punit Vara <punitvara@gmail.com>
---
 drivers/staging/comedi/comedidev.h | 62 ++++++++++++++++++++------------------
 1 file changed, 32 insertions(+), 30 deletions(-)

diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index 28a5d3a..5b0ab03 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -1,20 +1,20 @@
 /*
-    include/linux/comedidev.h
-    header file for kernel-only structures, variables, and constants
-
-    COMEDI - Linux Control and Measurement Device Interface
-    Copyright (C) 1997-2000 David A. Schleef <ds@schleef.org>
-
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-*/
+ * include/linux/comedidev.h
+ * header file for kernel-only structures, variables, and constants
+ *
+ * COMEDI - Linux Control and Measurement Device Interface
+ * Copyright (C) 1997-2000 David A. Schleef <ds@schleef.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
 
 #ifndef _COMEDIDEV_H
 #define _COMEDIDEV_H
@@ -105,7 +105,7 @@ struct comedi_buf_map {
 	struct kref refcount;
 };
 
-/**
+/*
  * struct comedi_async - control data for asynchronous comedi commands
  * @prealloc_buf:	preallocated buffer
  * @prealloc_bufsz:	buffer size (in bytes)
@@ -215,7 +215,7 @@ struct comedi_async {
 		       unsigned int x);
 };
 
-/**
+/*
  * comedi_async callback "events"
  * @COMEDI_CB_EOS:		end-of-scan
  * @COMEDI_CB_EOA:		end-of-acquisition/output
@@ -262,9 +262,11 @@ struct comedi_device {
 	struct device *class_dev;
 	int minor;
 	unsigned int detach_count;
-	/* hw_dev is passed to dma_alloc_coherent when allocating async buffers
+	/*
+	 * hw_dev is passed to dma_alloc_coherent when allocating async buffers
 	 * for subdevices that have async_dma_dir set to something other than
-	 * DMA_NONE */
+	 * DMA_NONE
+	 */
 	struct device *hw_dev;
 
 	const char *board_name;
@@ -391,7 +393,7 @@ static inline unsigned int comedi_offset_munge(struct comedi_subdevice *s,
 	return val ^ s->maxdata ^ (s->maxdata >> 1);
 }
 
-/**
+/*
  * comedi_bytes_per_sample - determine subdevice sample size
  * @s:		comedi_subdevice struct
  *
@@ -405,7 +407,7 @@ static inline unsigned int comedi_bytes_per_sample(struct comedi_subdevice *s)
 	return s->subdev_flags & SDF_LSAMPL ? sizeof(int) : sizeof(short);
 }
 
-/**
+/*
  * comedi_sample_shift - determine log2 of subdevice sample size
  * @s:		comedi_subdevice struct
  *
@@ -421,7 +423,7 @@ static inline unsigned int comedi_sample_shift(struct comedi_subdevice *s)
 	return s->subdev_flags & SDF_LSAMPL ? 2 : 1;
 }
 
-/**
+/*
  * comedi_bytes_to_samples - converts a number of bytes to a number of samples
  * @s:		comedi_subdevice struct
  * @nbytes:	number of bytes
@@ -434,7 +436,7 @@ static inline unsigned int comedi_bytes_to_samples(struct comedi_subdevice *s,
 	return nbytes >> comedi_sample_shift(s);
 }
 
-/**
+/*
  * comedi_samples_to_bytes - converts a number of samples to a number of bytes
  * @s:		comedi_subdevice struct
  * @nsamples:	number of samples
@@ -448,7 +450,7 @@ static inline unsigned int comedi_samples_to_bytes(struct comedi_subdevice *s,
 	return nsamples << comedi_sample_shift(s);
 }
 
-/**
+/*
  * comedi_check_trigger_src() - trivially validate a comedi_cmd trigger source
  * @src: pointer to the trigger source to validate
  * @flags: bitmask of valid TRIG_* for the trigger
@@ -469,7 +471,7 @@ static inline int comedi_check_trigger_src(unsigned int *src,
 	return 0;
 }
 
-/**
+/*
  * comedi_check_trigger_is_unique() - make sure a trigger source is unique
  * @src: the trigger source to check
  */
@@ -481,7 +483,7 @@ static inline int comedi_check_trigger_is_unique(unsigned int src)
 	return 0;
 }
 
-/**
+/*
  * comedi_check_trigger_arg_is() - trivially validate a trigger argument
  * @arg: pointer to the trigger arg to validate
  * @val: the value the argument should be
@@ -496,7 +498,7 @@ static inline int comedi_check_trigger_arg_is(unsigned int *arg,
 	return 0;
 }
 
-/**
+/*
  * comedi_check_trigger_arg_min() - trivially validate a trigger argument
  * @arg: pointer to the trigger arg to validate
  * @val: the minimum value the argument should be
@@ -511,7 +513,7 @@ static inline int comedi_check_trigger_arg_min(unsigned int *arg,
 	return 0;
 }
 
-/**
+/*
  * comedi_check_trigger_arg_max() - trivially validate a trigger argument
  * @arg: pointer to the trigger arg to validate
  * @val: the maximum value the argument should be
@@ -604,7 +606,7 @@ void comedi_auto_unconfig(struct device *);
 int comedi_driver_register(struct comedi_driver *);
 void comedi_driver_unregister(struct comedi_driver *);
 
-/**
+/*
  * module_comedi_driver() - Helper macro for registering a comedi driver
  * @__comedi_driver: comedi_driver struct
  *
-- 
2.5.2