* [PATCH] phy: add dm816x dependency on USB_PHY
@ 2015-05-19 13:02 Arnd Bergmann
2015-05-19 13:29 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-05-19 13:02 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: linux-kernel, Tony Lindgren, Bin Liu, Brian Hutchinson,
Felipe Balbi, Matthijs van Duin, linux-omap, linux-arm-kernel
The newly added phy-dm816x-usb driver depends on the
usb phy API and fails to link if that is disabled:
drivers/built-in.o: In function `dm816x_usb_phy_remove':
:(.text+0x3a28): undefined reference to `usb_remove_phy'
drivers/built-in.o: In function `dm816x_usb_phy_probe':
:(.text+0x3c18): undefined reference to `usb_add_phy_dev'
This adds an explicit dependency in Kconfig to avoid the
build error in randconfig tests.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 609adde838f4 ("phy: Add a driver for dm816x USB PHY")
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index fceac96c2a31..1b5c235562c9 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -37,7 +37,7 @@ config ARMADA375_USBCLUSTER_PHY
config PHY_DM816X_USB
tristate "TI dm816x USB PHY driver"
- depends on ARCH_OMAP2PLUS
+ depends on ARCH_OMAP2PLUS && USB_PHY
select GENERIC_PHY
help
Enable this for dm816x USB to work.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: add dm816x dependency on USB_PHY
2015-05-19 13:02 [PATCH] phy: add dm816x dependency on USB_PHY Arnd Bergmann
@ 2015-05-19 13:29 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 2+ messages in thread
From: Kishon Vijay Abraham I @ 2015-05-19 13:29 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-kernel, Tony Lindgren, Bin Liu, Brian Hutchinson,
Felipe Balbi, Matthijs van Duin, linux-omap, linux-arm-kernel
Hi Arnd,
On Tuesday 19 May 2015 06:32 PM, Arnd Bergmann wrote:
> The newly added phy-dm816x-usb driver depends on the
> usb phy API and fails to link if that is disabled:
>
> drivers/built-in.o: In function `dm816x_usb_phy_remove':
> :(.text+0x3a28): undefined reference to `usb_remove_phy'
> drivers/built-in.o: In function `dm816x_usb_phy_probe':
> :(.text+0x3c18): undefined reference to `usb_add_phy_dev'
A patch to fix this has already been queued in the fixes branch
https://git.kernel.org/cgit/linux/kernel/git/kishon/linux-phy.git/commit/?h=fixes&id=7f7a4d306ff87502dc26860f54e798693cf9b1e1
Thanks
Kishon
>
> This adds an explicit dependency in Kconfig to avoid the
> build error in randconfig tests.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 609adde838f4 ("phy: Add a driver for dm816x USB PHY")
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index fceac96c2a31..1b5c235562c9 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -37,7 +37,7 @@ config ARMADA375_USBCLUSTER_PHY
>
> config PHY_DM816X_USB
> tristate "TI dm816x USB PHY driver"
> - depends on ARCH_OMAP2PLUS
> + depends on ARCH_OMAP2PLUS && USB_PHY
> select GENERIC_PHY
> help
> Enable this for dm816x USB to work.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-19 13:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-19 13:02 [PATCH] phy: add dm816x dependency on USB_PHY Arnd Bergmann
2015-05-19 13:29 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).