* [PATCH] NVMe: removed unused nn var from nvme_dev_add
@ 2015-07-30 9:23 Matias Bjørling
2015-08-04 11:28 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Matias Bjørling @ 2015-07-30 9:23 UTC (permalink / raw)
To: linux-kernel, linux-nvme; +Cc: Matias Bjørling
The logic in nvme_dev_add to enumerate namespaces was moved to
nvme_dev_scan. When moved, the nn variable is no longer used. This patch
removes it.
Fixes: a5768aai ("NVMe: Automatic namespace rescan")
Signed-off-by: Matias Bjørling <m@bjorling.me>
---
drivers/block/nvme-core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index d844ec4..82a3241 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -2344,7 +2344,6 @@ static int nvme_dev_add(struct nvme_dev *dev)
{
struct pci_dev *pdev = to_pci_dev(dev->dev);
int res;
- unsigned nn;
struct nvme_id_ctrl *ctrl;
int shift = NVME_CAP_MPSMIN(readq(&dev->bar->cap)) + 12;
@@ -2354,7 +2353,6 @@ static int nvme_dev_add(struct nvme_dev *dev)
return -EIO;
}
- nn = le32_to_cpup(&ctrl->nn);
dev->oncs = le16_to_cpup(&ctrl->oncs);
dev->abort_limit = ctrl->acl + 1;
dev->vwc = ctrl->vwc;
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] NVMe: removed unused nn var from nvme_dev_add
2015-07-30 9:23 [PATCH] NVMe: removed unused nn var from nvme_dev_add Matias Bjørling
@ 2015-08-04 11:28 ` Christoph Hellwig
2015-08-17 23:19 ` Matias Bjørling
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2015-08-04 11:28 UTC (permalink / raw)
To: Matias Bj??rling; +Cc: linux-kernel, linux-nvme
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] NVMe: removed unused nn var from nvme_dev_add
2015-08-04 11:28 ` Christoph Hellwig
@ 2015-08-17 23:19 ` Matias Bjørling
2015-08-18 16:14 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Matias Bjørling @ 2015-08-17 23:19 UTC (permalink / raw)
To: Christoph Hellwig, Jens Axboe; +Cc: LKML, linux-nvme
Can this be picked up?
Thanks
On Tue, Aug 4, 2015 at 1:28 PM, Christoph Hellwig <hch@infradead.org> wrote:
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] NVMe: removed unused nn var from nvme_dev_add
2015-08-17 23:19 ` Matias Bjørling
@ 2015-08-18 16:14 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2015-08-18 16:14 UTC (permalink / raw)
To: Matias Bjørling, Christoph Hellwig; +Cc: LKML, linux-nvme
On 08/17/2015 05:19 PM, Matias Bjørling wrote:
> Can this be picked up?
Applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-18 16:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-30 9:23 [PATCH] NVMe: removed unused nn var from nvme_dev_add Matias Bjørling
2015-08-04 11:28 ` Christoph Hellwig
2015-08-17 23:19 ` Matias Bjørling
2015-08-18 16:14 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).