linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Francis Laniel <laniel_francis@privacyrequired.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-hardening@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, dja@axtens.net,
	keescook@chromium.org
Subject: Re: [PATCH v6 0/5] Fortify strscpy()
Date: Fri, 20 Nov 2020 10:40:38 +0100	[thread overview]
Message-ID: <5676804.6kI0aEeX2c@machine> (raw)
In-Reply-To: <20201119173543.8821881942022fc4f39c4c73@linux-foundation.org>

Le vendredi 20 novembre 2020, 02:35:43 CET Andrew Morton a écrit :
> On Thu, 19 Nov 2020 17:49:10 +0100 laniel_francis@privacyrequired.com wrote:
> > From: Francis Laniel <laniel_francis@privacyrequired.com>
> > 
> > Hi.
> > 
> > 
> > I hope your families, friends and yourselves are fine.
> 
> Thanks.  You too ;)

Thank you!

> > This patch set answers to this issue:
> > https://github.com/KSPP/linux/issues/46
> 
> I fail to understand what this patchset has to do with that
> one-element-array issue :(

I think I linked another issue totally not related with that one...

> > I based my modifications on top of two patches from Daniel Axtens which
> > modify calls to __builtin_object_size to ensure the true size of char *
> > are returned and not the surrounding structure size.
> > 
> > To sum up, in my first patch I implemented a fortified version of strscpy.
> > This new version ensures the following before calling vanilla strscpy:
> > 1. There is no read overflow because either size is smaller than src
> > length
> > or we shrink size to src length by calling fortified strnlen.
> > 2. There is no write overflow because we either failed during compilation
> > or at runtime by checking that size is smaller than dest size.
> > The second patch brings a new file in LKDTM driver to test this new
> > version. The test ensures the fortified version still returns the same
> > value as the vanilla one while panic'ing when there is a write overflow.
> > The third just corrects some typos in LKDTM related file.
> > 
> > If you see any problem or way to improve the code, feel free to share it.
> 
> Could you please send along a reworked [0/n] cover letter?  Explain in
> your own words, without requiring that readers go off and read web
> pages
> 
> - What problem the patchset solves
> - How it solves it
> - The value of the patchset (to kernel developers or to end-users) so that
> we can understand why it should be merged.
> 
> Thanks.

I will do it, moreover Kees Cook already told me that cover letter should 
suffices itself (e.g. if the issue disappeared on GitHub).
So I will rework the cover letter for the v7!




  reply	other threads:[~2020-11-20  9:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 16:49 [PATCH v6 0/5] Fortify strscpy() laniel_francis
2020-11-19 16:49 ` [PATCH v6 1/5] string.h: detect intra-object overflow in fortified string functions laniel_francis
2020-11-20  1:38   ` Andrew Morton
2020-11-20  9:41     ` Francis Laniel
2020-11-19 16:49 ` [PATCH v6 2/5] lkdtm: tests for FORTIFY_SOURCE laniel_francis
2020-11-19 16:49 ` [PATCH v6 3/5] string.h: Add FORTIFY coverage for strscpy() laniel_francis
2020-11-19 16:49 ` [PATCH v6 4/5] Add new file in LKDTM to test fortified strscpy laniel_francis
2020-11-19 16:49 ` [PATCH v6 5/5] Correct wrong filenames in comment laniel_francis
2020-11-20  1:35 ` [PATCH v6 0/5] Fortify strscpy() Andrew Morton
2020-11-20  9:40   ` Francis Laniel [this message]
2020-11-20 19:52     ` Kees Cook
2020-11-22 16:28       ` Francis Laniel
2020-11-20 13:33   ` David Laight
2020-11-20 15:51     ` Francis Laniel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5676804.6kI0aEeX2c@machine \
    --to=laniel_francis@privacyrequired.com \
    --cc=akpm@linux-foundation.org \
    --cc=dja@axtens.net \
    --cc=keescook@chromium.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).