* [PATCH] Revert "netpoll: Fix extra refcount release in netpoll_cleanup()"
@ 2016-04-05 20:58 Bjorn Helgaas
2016-04-06 13:48 ` Neil Horman
2016-04-06 14:13 ` Bart Van Assche
0 siblings, 2 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2016-04-05 20:58 UTC (permalink / raw)
To: David S. Miller
Cc: Neil Horman, Nikolay Aleksandrov, netdev, linux-kernel,
Alexander Duyck, Bart Van Assche
This reverts commit 543e3a8da5a4c453e992d5351ef405d5e32f27d7.
Direct callers of __netpoll_setup() depend on it to set np->dev,
so we can't simply move that assignment up to netpoll_stup().
Reported-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
net/core/netpoll.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index a57bd17..94acfc8 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -603,6 +603,7 @@ int __netpoll_setup(struct netpoll *np, struct net_device *ndev)
const struct net_device_ops *ops;
int err;
+ np->dev = ndev;
strlcpy(np->dev_name, ndev->name, IFNAMSIZ);
INIT_WORK(&np->cleanup_work, netpoll_async_cleanup);
@@ -669,7 +670,6 @@ int netpoll_setup(struct netpoll *np)
goto unlock;
}
dev_hold(ndev);
- np->dev = ndev;
if (netdev_master_upper_dev_get(ndev)) {
np_err(np, "%s is a slave device, aborting\n", np->dev_name);
@@ -770,7 +770,6 @@ int netpoll_setup(struct netpoll *np)
return 0;
put:
- np->dev = NULL;
dev_put(ndev);
unlock:
rtnl_unlock();
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "netpoll: Fix extra refcount release in netpoll_cleanup()"
2016-04-05 20:58 [PATCH] Revert "netpoll: Fix extra refcount release in netpoll_cleanup()" Bjorn Helgaas
@ 2016-04-06 13:48 ` Neil Horman
2016-04-06 14:13 ` Bart Van Assche
1 sibling, 0 replies; 3+ messages in thread
From: Neil Horman @ 2016-04-06 13:48 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: David S. Miller, Nikolay Aleksandrov, netdev, linux-kernel,
Alexander Duyck, Bart Van Assche
On Tue, Apr 05, 2016 at 03:58:22PM -0500, Bjorn Helgaas wrote:
> This reverts commit 543e3a8da5a4c453e992d5351ef405d5e32f27d7.
>
> Direct callers of __netpoll_setup() depend on it to set np->dev,
> so we can't simply move that assignment up to netpoll_stup().
>
> Reported-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> net/core/netpoll.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> index a57bd17..94acfc8 100644
> --- a/net/core/netpoll.c
> +++ b/net/core/netpoll.c
> @@ -603,6 +603,7 @@ int __netpoll_setup(struct netpoll *np, struct net_device *ndev)
> const struct net_device_ops *ops;
> int err;
>
> + np->dev = ndev;
> strlcpy(np->dev_name, ndev->name, IFNAMSIZ);
> INIT_WORK(&np->cleanup_work, netpoll_async_cleanup);
>
> @@ -669,7 +670,6 @@ int netpoll_setup(struct netpoll *np)
> goto unlock;
> }
> dev_hold(ndev);
> - np->dev = ndev;
>
> if (netdev_master_upper_dev_get(ndev)) {
> np_err(np, "%s is a slave device, aborting\n", np->dev_name);
> @@ -770,7 +770,6 @@ int netpoll_setup(struct netpoll *np)
> return 0;
>
> put:
> - np->dev = NULL;
> dev_put(ndev);
> unlock:
> rtnl_unlock();
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "netpoll: Fix extra refcount release in netpoll_cleanup()"
2016-04-05 20:58 [PATCH] Revert "netpoll: Fix extra refcount release in netpoll_cleanup()" Bjorn Helgaas
2016-04-06 13:48 ` Neil Horman
@ 2016-04-06 14:13 ` Bart Van Assche
1 sibling, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2016-04-06 14:13 UTC (permalink / raw)
To: Bjorn Helgaas, David S. Miller
Cc: Neil Horman, Nikolay Aleksandrov, netdev, linux-kernel, Alexander Duyck
On 04/05/16 13:58, Bjorn Helgaas wrote:
> This reverts commit 543e3a8da5a4c453e992d5351ef405d5e32f27d7.
>
> Direct callers of __netpoll_setup() depend on it to set np->dev,
> so we can't simply move that assignment up to netpoll_stup().
>
> Reported-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Tested-by: Bart Van Assche <bart.vanassche@sandisk.com>
Thanks!
Bart.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-06 14:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-05 20:58 [PATCH] Revert "netpoll: Fix extra refcount release in netpoll_cleanup()" Bjorn Helgaas
2016-04-06 13:48 ` Neil Horman
2016-04-06 14:13 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).