* [PATCH 01/10 v5] Input: ep93xx_keypad: Fix platform_get_irq's error checking
@ 2017-11-21 16:11 Arvind Yadav
2017-11-28 15:59 ` arvindY
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-11-21 16:11 UTC (permalink / raw)
To: dmitry.torokhov, maxime.ripard, wens, mcuos.com, linux, linux, lee.jones
Cc: linux-kernel, linux-input, linux-arm-kernel
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2 :
Return keypad->irq insted of -ENXIO.
changes in v3 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v4 :
Return -ENXIO insted of keypad->irq. Which was not correct in v3.
changes in v5 :
Remove changes of v3 and v4. go back to version v2. Which is correct.
No need to check for IRQ0 and return keypad->irq insted of -ENXIO.
drivers/input/keyboard/ep93xx_keypad.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
index f77b295..01788a7 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -257,8 +257,8 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
}
keypad->irq = platform_get_irq(pdev, 0);
- if (!keypad->irq) {
- err = -ENXIO;
+ if (keypad->irq < 0) {
+ err = keypad->irq;
goto failed_free;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 01/10 v5] Input: ep93xx_keypad: Fix platform_get_irq's error checking
2017-11-21 16:11 [PATCH 01/10 v5] Input: ep93xx_keypad: Fix platform_get_irq's error checking Arvind Yadav
@ 2017-11-28 15:59 ` arvindY
0 siblings, 0 replies; 2+ messages in thread
From: arvindY @ 2017-11-28 15:59 UTC (permalink / raw)
To: dmitry.torokhov, maxime.ripard, wens, mcuos.com, linux, linux, lee.jones
Cc: linux-kernel, linux-input, linux-arm-kernel
Hi Dmitry,
Sorry for troubling you. I need to push others also. Please share
your review comment.
Thanks,
On Tuesday 21 November 2017 09:41 PM, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2 :
> Return keypad->irq insted of -ENXIO.
> changes in v3 :
> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v4 :
> Return -ENXIO insted of keypad->irq. Which was not correct in v3.
> changes in v5 :
> Remove changes of v3 and v4. go back to version v2. Which is correct.
> No need to check for IRQ0 and return keypad->irq insted of -ENXIO.
>
> drivers/input/keyboard/ep93xx_keypad.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
> index f77b295..01788a7 100644
> --- a/drivers/input/keyboard/ep93xx_keypad.c
> +++ b/drivers/input/keyboard/ep93xx_keypad.c
> @@ -257,8 +257,8 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
> }
>
> keypad->irq = platform_get_irq(pdev, 0);
> - if (!keypad->irq) {
> - err = -ENXIO;
> + if (keypad->irq < 0) {
> + err = keypad->irq;
> goto failed_free;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-28 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-21 16:11 [PATCH 01/10 v5] Input: ep93xx_keypad: Fix platform_get_irq's error checking Arvind Yadav
2017-11-28 15:59 ` arvindY
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).