linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Jeremy Kerr <jeremy.kerr@canonical.com>
Cc: linux-kernel@vger.kernel.org, Matthew Garrett <mjg@redhat.com>,
	Matt Fleming <matt.fleming@intel.com>,
	Matt Domsch <Matt_Domsch@Dell.com>
Subject: Re: [RFC,PATCH] efi: Add support for a UEFI variable filesystem
Date: Thu, 30 Aug 2012 19:36:48 -0700	[thread overview]
Message-ID: <5e40036f-b0da-47f3-acba-5dea9fdb7ed6@email.android.com> (raw)
In-Reply-To: <50400859.2080606@canonical.com>

Wouldn't that be better handled by O_APPEND?



Jeremy Kerr <jeremy.kerr@canonical.com> wrote:

>Hi hpa,
>
>Thanks for the review!
>
>> However, I have a question... rather than putting the attributes as
>the
>> first data bytes, would it be better to make it either part of the
>> filename (assuming there is at least one character other than / which
>> can be reasonably relied upon to not be part of the name); for
>example:
>>
>> 	LangCodes,BS,RT
>>
>> ... or ...
>>
>> 	LangCodes,6
>
>This will get tricky when handling EFI_VARIABLE_APPEND_WRITE: this 
>attribute will never appear in the attributes returned by
>GetVariable(), 
>but may be passed to SetVariable(). If we put attributes in the 
>filename, we'd need to handle writes to both names, and/or have 
>duplicate dentries for each variable. We could do it, but the
>filesystem 
>interface might be a little messy.
>
>[Supporting append writes is essential for key database updates, which 
>may be signed]
>
>Cheers,
>
>
>Jeremy

-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.

  reply	other threads:[~2012-08-31  2:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1346319009.951368.767015086462.1.gpush@pecola>
2012-08-30 17:22 ` [RFC,PATCH] efi: Add support for a UEFI variable filesystem H. Peter Anvin
2012-08-31  0:42   ` Jeremy Kerr
2012-08-31  2:36     ` H. Peter Anvin [this message]
2012-09-03  1:39       ` Jeremy Kerr
2012-09-03  1:59         ` H. Peter Anvin
2012-09-03  3:15           ` Jeremy Kerr
2012-09-03  3:26           ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e40036f-b0da-47f3-acba-5dea9fdb7ed6@email.android.com \
    --to=hpa@zytor.com \
    --cc=Matt_Domsch@Dell.com \
    --cc=jeremy.kerr@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mjg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).