* linux-next: Fixes tag needs some work in the phy-next tree
@ 2020-01-27 20:05 Stephen Rothwell
2020-01-28 4:52 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2020-01-27 20:05 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Dafna Hirschfeld
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
Hi all,
In commit
0b96a3349af1 ("dt-bindings: fix compilation error of the example in intel,lgm-emmc-phy.yaml")
Fixes tag
Fixes: 5bc999108025 ("dt-bindings: phy: intel-emmc-phy: Add YAML
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please keep Fixes tags on a single line.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Fixes tag needs some work in the phy-next tree
2020-01-27 20:05 linux-next: Fixes tag needs some work in the phy-next tree Stephen Rothwell
@ 2020-01-28 4:52 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 7+ messages in thread
From: Kishon Vijay Abraham I @ 2020-01-28 4:52 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Dafna Hirschfeld
On 28/01/20 1:35 am, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 0b96a3349af1 ("dt-bindings: fix compilation error of the example in intel,lgm-emmc-phy.yaml")
>
> Fixes tag
>
> Fixes: 5bc999108025 ("dt-bindings: phy: intel-emmc-phy: Add YAML
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please keep Fixes tags on a single line.
Fixed this.
Thanks
Kishon
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Fixes tag needs some work in the phy-next tree
2022-11-07 1:10 ` Justin Chen
@ 2022-11-07 4:51 ` Vinod Koul
0 siblings, 0 replies; 7+ messages in thread
From: Vinod Koul @ 2022-11-07 4:51 UTC (permalink / raw)
To: Justin Chen
Cc: Stephen Rothwell, Kishon Vijay Abraham I,
Linux Kernel Mailing List, Linux Next Mailing List
On 06-11-22, 17:10, Justin Chen wrote:
> On Sun, Nov 6, 2022 at 1:12 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > In commits
> >
> > 5b679072af07 ("phy: usb: Fix clock imbalance for suspend/resume")
> > 219ec4e8f7b2 ("phy: usb: Use slow clock for wake enabled suspend")
> >
> > Fixes tag
> >
> > Fixes: ae532b2b7aa5 ("usb: Add "wake on" functionality for newer Synopsis XHCI controllers")
> >
> > has these problem(s):
> >
> > - Subject does not match target commit subject
Fixed now
> > Just use
> > git log -1 --format='Fixes: %h ("%s")'
> >
> Apologies, I missed the "phy:" in the beginning. Should be this.
> Fixes: ae532b2b7aa5 ("phy: usb: Add "wake on" functionality for newer
> Synopsis XHCI controllers")
Use the script above to generate this and not manually
>
> How should I fix this? Can this be fixed in place?
I have fixed it up
--
~Vinod
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Fixes tag needs some work in the phy-next tree
2022-11-06 21:13 Stephen Rothwell
@ 2022-11-07 4:50 ` Vinod Koul
0 siblings, 0 replies; 7+ messages in thread
From: Vinod Koul @ 2022-11-07 4:50 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Kishon Vijay Abraham I, Al Cooper, Linux Kernel Mailing List,
Linux Next Mailing List
On 07-11-22, 08:13, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 3ef54ad3004a ("phy: usb: s2 WoL wakeup_count not incremented for USB->Eth devices")
Thanks for reporting, fixed now
>
> Fixes tag
>
> Fixes: f1c0db40a3ad ("usb: Add "wake on" functionality")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> --
> Cheers,
> Stephen Rothwell
--
~Vinod
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Fixes tag needs some work in the phy-next tree
2022-11-06 21:11 Stephen Rothwell
@ 2022-11-07 1:10 ` Justin Chen
2022-11-07 4:51 ` Vinod Koul
0 siblings, 1 reply; 7+ messages in thread
From: Justin Chen @ 2022-11-07 1:10 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Kishon Vijay Abraham I, Vinod Koul, Linux Kernel Mailing List,
Linux Next Mailing List
On Sun, Nov 6, 2022 at 1:12 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commits
>
> 5b679072af07 ("phy: usb: Fix clock imbalance for suspend/resume")
> 219ec4e8f7b2 ("phy: usb: Use slow clock for wake enabled suspend")
>
> Fixes tag
>
> Fixes: ae532b2b7aa5 ("usb: Add "wake on" functionality for newer Synopsis XHCI controllers")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
Apologies, I missed the "phy:" in the beginning. Should be this.
Fixes: ae532b2b7aa5 ("phy: usb: Add "wake on" functionality for newer
Synopsis XHCI controllers")
How should I fix this? Can this be fixed in place?
Thanks,
Justin
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: Fixes tag needs some work in the phy-next tree
@ 2022-11-06 21:13 Stephen Rothwell
2022-11-07 4:50 ` Vinod Koul
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2022-11-06 21:13 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul
Cc: Al Cooper, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
Hi all,
In commit
3ef54ad3004a ("phy: usb: s2 WoL wakeup_count not incremented for USB->Eth devices")
Fixes tag
Fixes: f1c0db40a3ad ("usb: Add "wake on" functionality")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: Fixes tag needs some work in the phy-next tree
@ 2022-11-06 21:11 Stephen Rothwell
2022-11-07 1:10 ` Justin Chen
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2022-11-06 21:11 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul
Cc: Justin Chen, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
Hi all,
In commits
5b679072af07 ("phy: usb: Fix clock imbalance for suspend/resume")
219ec4e8f7b2 ("phy: usb: Use slow clock for wake enabled suspend")
Fixes tag
Fixes: ae532b2b7aa5 ("usb: Add "wake on" functionality for newer Synopsis XHCI controllers")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-11-07 4:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-27 20:05 linux-next: Fixes tag needs some work in the phy-next tree Stephen Rothwell
2020-01-28 4:52 ` Kishon Vijay Abraham I
2022-11-06 21:11 Stephen Rothwell
2022-11-07 1:10 ` Justin Chen
2022-11-07 4:51 ` Vinod Koul
2022-11-06 21:13 Stephen Rothwell
2022-11-07 4:50 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).