From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Sean Paul <seanpaul@chromium.org>
Cc: dri-devel@lists.freedesktop.org,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
David Airlie <airlied@linux.ie>,
Fabien Dessenne <fabien.dessenne@st.com>,
Vincent Abriou <vincent.abriou@st.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: GPU-DRM-STI: Fine-tuning for some function implementations
Date: Sat, 6 May 2017 15:54:51 +0200 [thread overview]
Message-ID: <77d74ffc-c833-f7ad-b1e2-5e07ac9d23a7@users.sourceforge.net> (raw)
In-Reply-To: <20170506123304.2scgonpvt7kjf4cz@art_vandelay>
> Generally speaking, I don't care about checkpatch/cocci changes that aren't tested.
I find this view interesting only to some degree.
1. I suggest to combine a few functions into fewer ones.
* Do you spot any programming mistakes in these concrete cases?
* Can such code reduction result into desired effects?
2. I propose to use the function “seq_putc” at more source code places.
* Do you really find any previous system test approaches insufficient around
such a Linux feature?
* Does the programming interface “seq_puts” provide any properties
that you prefer over the other one for the sequence output of single characters?
http://elixir.free-electrons.com/linux/v4.11/source/fs/seq_file.c#L664
> With your changes, we don't have this upside.
How do you think about to pick spelling corrections up for two comment lines?
Regards,
Markus
next prev parent reply other threads:[~2017-05-06 13:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 13:50 [PATCH 0/5] GPU-DRM-STI: Fine-tuning for some function implementations SF Markus Elfring
2017-05-05 13:52 ` [PATCH 1/5] drm/sti: Reduce function calls for sequence output at five places SF Markus Elfring
2017-05-05 13:54 ` [PATCH 2/5] drm/sti: Replace 17 seq_puts() calls by seq_putc() SF Markus Elfring
2017-05-05 13:55 ` [PATCH 3/5] drm/sti: Fix a typo in a comment line SF Markus Elfring
2017-05-05 13:56 ` [PATCH 4/5] drm/sti: Fix typos " SF Markus Elfring
2017-05-05 13:57 ` [PATCH 5/5] drm/sti: Adjust two checks for null pointers in sti_hqvdp_probe() SF Markus Elfring
2017-05-05 14:09 ` [PATCH 0/5] GPU-DRM-STI: Fine-tuning for some function implementations Sean Paul
2017-05-05 15:04 ` SF Markus Elfring
2017-05-06 12:33 ` Sean Paul
2017-05-06 13:54 ` SF Markus Elfring [this message]
2017-05-06 15:25 ` Sean Paul
2017-05-06 17:00 ` SF Markus Elfring
2017-05-09 8:03 ` Benjamin Gaignard
2017-05-09 10:02 ` Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77d74ffc-c833-f7ad-b1e2-5e07ac9d23a7@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=airlied@linux.ie \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabien.dessenne@st.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanpaul@chromium.org \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).