From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Sean Paul <seanpaul@chromium.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
David Airlie <airlied@linux.ie>,
Fabien Dessenne <fabien.dessenne@st.com>,
Vincent Abriou <vincent.abriou@st.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: GPU-DRM-STI: Fine-tuning for some function implementations
Date: Tue, 9 May 2017 12:02:52 +0200 [thread overview]
Message-ID: <CA+M3ks4KaLCTNFEV3cyHbXWZ8pM2fSRKVp_9=DBNkE7Tw6FJ9g@mail.gmail.com> (raw)
In-Reply-To: <CA+M3ks79oBX=MWgZZWa23yeJ7XAxx1TBVAgk2LSi4jGKJJju3A@mail.gmail.com>
2017-05-09 10:03 GMT+02:00 Benjamin Gaignard <benjamin.gaignard@linaro.org>:
> 2017-05-06 19:00 GMT+02:00 SF Markus Elfring <elfring@users.sourceforge.net>:
>>>> 1. I suggest to combine a few functions into fewer ones.
>>>> * Do you spot any programming mistakes in these concrete cases?
>>>
>>> Not in the patches I skimmed.
>>
>> Thanks for such feedback.
>>
>>
>>> However, your history of breaking code tells me that there have been mistakes
>>> missed in the past.
>>
>> I admit that I had my own share of software development hiccups. I would also
>> like to reduce them. But a probability remains that I will stumble on
>> various glitches as usual.
>>
>>
>>> As such, I'm not willing to take untested code from you that does not change
>>> functionality at the risk of breaking something that is currently working.
>>
>> I imagine that the shown software refactoring will improve the affected
>> sequence outputs in useful ways, won't it?
>>
>>
>>> This is non-negotiable.
>>
>> It seems that we have got different views around the ways to get to acceptable
>> final system test results.
>>
>>
>>> As I said before, if you test it, I'll consider it.
>
> As sti driver maintainer I will test those patches.
> If their are ok and get some other reviewed/ack I will use them
> for myself training on how push patches in drm-misc.
>
> Benjamin
After testing:
Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
>
>>
>> I got a few doubts for this information. If you find my software development
>> reputation so questionable, I assume that you would not trust any tests
>> that I would try out on my own.
>>
>>
>>> If you are unwilling to test your changes, I'm unwilling to apply them.
>>
>> I guess that the desired willingness will depend on a test environment
>> which will be trusted by all involved parties. Other incentives might
>> also matter.
>>
>>
>>> I'm not interested in double checking all of your work, and fixing your bugs
>>> for no functional benefit.
>>
>> Do you care for improvements in the implementation of logging functions?
>>
>>
>>> I find less value in these patches if they're from someone seemingly
>>> trying to rack up patch count.
>>
>> I am picking special source code search patterns up.
>> The evolving development tools can point then hundreds of source files
>> out which contain similar update candidates.
>> I found also a few spelling weaknesses while I was looking around
>> in affected source code. These tools can also increase the awareness
>> for such change possibilities, can't they?
>>
>> Regards,
>> Markus
prev parent reply other threads:[~2017-05-09 10:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 13:50 [PATCH 0/5] GPU-DRM-STI: Fine-tuning for some function implementations SF Markus Elfring
2017-05-05 13:52 ` [PATCH 1/5] drm/sti: Reduce function calls for sequence output at five places SF Markus Elfring
2017-05-05 13:54 ` [PATCH 2/5] drm/sti: Replace 17 seq_puts() calls by seq_putc() SF Markus Elfring
2017-05-05 13:55 ` [PATCH 3/5] drm/sti: Fix a typo in a comment line SF Markus Elfring
2017-05-05 13:56 ` [PATCH 4/5] drm/sti: Fix typos " SF Markus Elfring
2017-05-05 13:57 ` [PATCH 5/5] drm/sti: Adjust two checks for null pointers in sti_hqvdp_probe() SF Markus Elfring
2017-05-05 14:09 ` [PATCH 0/5] GPU-DRM-STI: Fine-tuning for some function implementations Sean Paul
2017-05-05 15:04 ` SF Markus Elfring
2017-05-06 12:33 ` Sean Paul
2017-05-06 13:54 ` SF Markus Elfring
2017-05-06 15:25 ` Sean Paul
2017-05-06 17:00 ` SF Markus Elfring
2017-05-09 8:03 ` Benjamin Gaignard
2017-05-09 10:02 ` Benjamin Gaignard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+M3ks4KaLCTNFEV3cyHbXWZ8pM2fSRKVp_9=DBNkE7Tw6FJ9g@mail.gmail.com' \
--to=benjamin.gaignard@linaro.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=elfring@users.sourceforge.net \
--cc=fabien.dessenne@st.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanpaul@chromium.org \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).