* [PATCH] xen/pvcalls: Add MODULE_LICENSE()
@ 2017-11-15 16:37 Boris Ostrovsky
2017-11-15 16:44 ` Juergen Gross
2017-11-15 18:07 ` Stefano Stabellini
0 siblings, 2 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2017-11-15 16:37 UTC (permalink / raw)
To: xen-devel; +Cc: jgross, linux-kernel, sstabellini, Boris Ostrovsky
Since commit ba1029c9cbc5 ("modpost: detect modules without a
MODULE_LICENSE") modules without said macro will generate
WARNING: modpost: missing MODULE_LICENSE() in <filename>
While at it, also add module description and attribution.
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
drivers/xen/pvcalls-back.c | 4 ++++
drivers/xen/pvcalls-front.c | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index b209cd4..02cd33c 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -1238,3 +1238,7 @@ static void __exit pvcalls_back_fin(void)
}
module_exit(pvcalls_back_fin);
+
+MODULE_DESCRIPTION("Xen PV Calls backend driver");
+MODULE_AUTHOR("Stefano Stabellini <sstabellini@kernel.org>");
+MODULE_LICENSE("GPL");
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 2925b2f..9e40c2c 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -1273,3 +1273,7 @@ static int __init pvcalls_frontend_init(void)
}
module_init(pvcalls_frontend_init);
+
+MODULE_DESCRIPTION("Xen PV Calls frontend driver");
+MODULE_AUTHOR("Stefano Stabellini <sstabellini@kernel.org>");
+MODULE_LICENSE("GPL");
--
2.7.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/pvcalls: Add MODULE_LICENSE()
2017-11-15 16:37 [PATCH] xen/pvcalls: Add MODULE_LICENSE() Boris Ostrovsky
@ 2017-11-15 16:44 ` Juergen Gross
2017-11-15 18:07 ` Stefano Stabellini
1 sibling, 0 replies; 3+ messages in thread
From: Juergen Gross @ 2017-11-15 16:44 UTC (permalink / raw)
To: Boris Ostrovsky, xen-devel; +Cc: linux-kernel, sstabellini
On 15/11/17 17:37, Boris Ostrovsky wrote:
> Since commit ba1029c9cbc5 ("modpost: detect modules without a
> MODULE_LICENSE") modules without said macro will generate
>
> WARNING: modpost: missing MODULE_LICENSE() in <filename>
>
> While at it, also add module description and attribution.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/pvcalls: Add MODULE_LICENSE()
2017-11-15 16:37 [PATCH] xen/pvcalls: Add MODULE_LICENSE() Boris Ostrovsky
2017-11-15 16:44 ` Juergen Gross
@ 2017-11-15 18:07 ` Stefano Stabellini
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2017-11-15 18:07 UTC (permalink / raw)
To: Boris Ostrovsky; +Cc: xen-devel, jgross, linux-kernel, sstabellini
On Wed, 15 Nov 2017, Boris Ostrovsky wrote:
> Since commit ba1029c9cbc5 ("modpost: detect modules without a
> MODULE_LICENSE") modules without said macro will generate
>
> WARNING: modpost: missing MODULE_LICENSE() in <filename>
>
> While at it, also add module description and attribution.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Ack. Thank you!
> ---
> drivers/xen/pvcalls-back.c | 4 ++++
> drivers/xen/pvcalls-front.c | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
> index b209cd4..02cd33c 100644
> --- a/drivers/xen/pvcalls-back.c
> +++ b/drivers/xen/pvcalls-back.c
> @@ -1238,3 +1238,7 @@ static void __exit pvcalls_back_fin(void)
> }
>
> module_exit(pvcalls_back_fin);
> +
> +MODULE_DESCRIPTION("Xen PV Calls backend driver");
> +MODULE_AUTHOR("Stefano Stabellini <sstabellini@kernel.org>");
> +MODULE_LICENSE("GPL");
> diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
> index 2925b2f..9e40c2c 100644
> --- a/drivers/xen/pvcalls-front.c
> +++ b/drivers/xen/pvcalls-front.c
> @@ -1273,3 +1273,7 @@ static int __init pvcalls_frontend_init(void)
> }
>
> module_init(pvcalls_frontend_init);
> +
> +MODULE_DESCRIPTION("Xen PV Calls frontend driver");
> +MODULE_AUTHOR("Stefano Stabellini <sstabellini@kernel.org>");
> +MODULE_LICENSE("GPL");
> --
> 2.7.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-15 18:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-15 16:37 [PATCH] xen/pvcalls: Add MODULE_LICENSE() Boris Ostrovsky
2017-11-15 16:44 ` Juergen Gross
2017-11-15 18:07 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).