linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v2 net-next 0/2] Add support for Microchip Technology KSZ9131 10/100/1000 Ethernet PHY
  2018-09-27 20:15 [PATCH v2 net-next 0/2] Add support for Microchip Technology KSZ9131 10/100/1000 Ethernet PHY Yuiko Oshino
@ 2018-09-27 19:28 ` Florian Fainelli
  2018-09-28 14:51   ` Yuiko.Oshino
  0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2018-09-27 19:28 UTC (permalink / raw)
  To: Yuiko Oshino, davem, robh+dt, devicetree, andrew
  Cc: linux-kernel, mark.rutland, m.felsch, Markus.Niebel, netdev,
	UNGLinuxDriver

On 09/27/2018 01:15 PM, Yuiko Oshino wrote:
> This is the initial driver for Microchip KSZ9131 10/100/1000 Ethernet PHY
> 
> v2:
> - Creating a series from two related patches.

When people give you Acked-by or Reviewed-by tags in prior versions, it
is usually a good  practice to add them to your next version of the
patch submission. Also, your patches 1 and 2 did not show up as as reply
to this cover letter, while they should, please fix this if you ever
need to submit new patches in the future.

Thank you!

> 
> Yuiko Oshino (2):
>   net: phy: micrel: add Microchip KSZ9131 inital driver
>   dt-bindings: net: add support for Microchip KSZ9131 Ethernet PHY
> 
>  .../devicetree/bindings/net/micrel-ksz90x1.txt     | 29 +++++++++++++++++++-
>  drivers/net/phy/micrel.c                           | 32 ++++++++++++++++++++--
>  include/linux/micrel_phy.h                         |  1 +
>  3 files changed, 58 insertions(+), 4 deletions(-)
> 


-- 
Florian

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 net-next 0/2]  Add support for Microchip Technology KSZ9131 10/100/1000 Ethernet PHY
@ 2018-09-27 20:15 Yuiko Oshino
  2018-09-27 19:28 ` Florian Fainelli
  0 siblings, 1 reply; 3+ messages in thread
From: Yuiko Oshino @ 2018-09-27 20:15 UTC (permalink / raw)
  To: davem, robh+dt, devicetree, f.fainelli, andrew
  Cc: linux-kernel, mark.rutland, m.felsch, Markus.Niebel, netdev,
	UNGLinuxDriver

This is the initial driver for Microchip KSZ9131 10/100/1000 Ethernet PHY

v2:
- Creating a series from two related patches.

Yuiko Oshino (2):
  net: phy: micrel: add Microchip KSZ9131 inital driver
  dt-bindings: net: add support for Microchip KSZ9131 Ethernet PHY

 .../devicetree/bindings/net/micrel-ksz90x1.txt     | 29 +++++++++++++++++++-
 drivers/net/phy/micrel.c                           | 32 ++++++++++++++++++++--
 include/linux/micrel_phy.h                         |  1 +
 3 files changed, 58 insertions(+), 4 deletions(-)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH v2 net-next 0/2] Add support for Microchip Technology KSZ9131 10/100/1000 Ethernet PHY
  2018-09-27 19:28 ` Florian Fainelli
@ 2018-09-28 14:51   ` Yuiko.Oshino
  0 siblings, 0 replies; 3+ messages in thread
From: Yuiko.Oshino @ 2018-09-28 14:51 UTC (permalink / raw)
  To: f.fainelli, davem, robh+dt, devicetree, andrew
  Cc: linux-kernel, mark.rutland, m.felsch, Markus.Niebel, netdev,
	UNGLinuxDriver

>On 09/27/2018 01:15 PM, Yuiko Oshino wrote:
>> This is the initial driver for Microchip KSZ9131 10/100/1000 Ethernet
>> PHY
>>
>> v2:
>> - Creating a series from two related patches.
>
>When people give you Acked-by or Reviewed-by tags in prior versions, it is usually
>a good  practice to add them to your next version of the patch submission. Also,
>your patches 1 and 2 did not show up as as reply to this cover letter, while they
>should, please fix this if you ever need to submit new patches in the future.
>
>Thank you!

Florian,
Thank you for your reviews. Sorry I forgot to add Acked-by.
Is seems like I am modifying the dt-binding doc, so I will submit v3.
Thank you!

>
>--
>Florian

Yuiko

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-28 14:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-27 20:15 [PATCH v2 net-next 0/2] Add support for Microchip Technology KSZ9131 10/100/1000 Ethernet PHY Yuiko Oshino
2018-09-27 19:28 ` Florian Fainelli
2018-09-28 14:51   ` Yuiko.Oshino

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).