From: Dave Hansen <dave.hansen@linux.intel.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Andrew Lutomirski <luto@kernel.org>
Cc: riel@surriel.com, LKML <linux-kernel@vger.kernel.org>,
X86 ML <x86@kernel.org>
Subject: Re: Lazy FPU restoration / moving kernel_fpu_end() to context switch
Date: Fri, 15 Jun 2018 13:42:14 -0700 [thread overview]
Message-ID: <7e415c4d-415b-0ff6-5488-1681e522d2dc@linux.intel.com> (raw)
In-Reply-To: <CAHmME9qhmSVNBq_GnkYrGU-PPEX9Fk0yiGktsCeEXo+LTB9KPg@mail.gmail.com>
On 06/15/2018 01:33 PM, Jason A. Donenfeld wrote:
> On Fri, Jun 15, 2018 at 8:32 PM Andy Lutomirski <luto@kernel.org> wrote:
>> quite in the form you imagined. The idea that we've tossed around is
>> to restore FPU state on return to user mode. Roughly, we'd introduce
>> a new thread flag TIF_FPU_UNLOADED (name TBD).
>> prepare_exit_to_usermode() would notice this flag, copy the fpstate to
>> fpregs, and clear the flag. (Or maybe exit_to_usermode_loop() -- No
>> one has quite thought it through, but I think it should be outside the
>> loop.) We'd update all the FPU accessors to understand the flag.
> Yes! This is exactly what I was thinking. Then those calls to begin()
> and end() could be placed as close to the actual FPU usage as
> possible.
Andy, what was the specific concern about PKRU? That we might do:
kernel_fpu_begin(); <- Saves the first time
something()
kernel_fpu_end(); <- Does not XRSTOR
copy_from_user(); <- Sees old PKRU, does the wrong thing
prepare_exit_to_usermode(); <- Does the XRSTOR
// only now does PKRU have the right value
SYSRET/IRET
?
Does that *matter* unless something() modified PKRU? We could just make
the rule that nobody is supposed to mess with it and that it's not
covered by kernel_fpu_begin/end() semantics. We could even
theoretically enforce that in a debug environment if we watch its value.
next prev parent reply other threads:[~2018-06-15 20:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 13:11 Lazy FPU restoration / moving kernel_fpu_end() to context switch Jason A. Donenfeld
2018-06-15 16:25 ` Thomas Gleixner
2018-06-15 18:33 ` Brian Gerst
2018-06-15 19:34 ` Peter Zijlstra
2018-06-15 20:30 ` Jason A. Donenfeld
2018-06-18 9:44 ` Peter Zijlstra
2018-06-18 15:25 ` Jason A. Donenfeld
2018-06-15 18:31 ` Andy Lutomirski
2018-06-15 18:40 ` Rik van Riel
2018-06-15 18:41 ` Dave Hansen
2018-06-15 18:49 ` Andy Lutomirski
2018-06-15 18:48 ` Dave Hansen
2018-06-15 18:53 ` Andy Lutomirski
2018-06-15 20:27 ` Jason A. Donenfeld
2018-06-15 20:48 ` Jason A. Donenfeld
2018-06-19 11:43 ` David Laight
2018-06-19 13:08 ` Thomas Gleixner
2018-06-15 20:33 ` Jason A. Donenfeld
2018-06-15 20:42 ` Dave Hansen [this message]
2018-06-15 20:52 ` Andy Lutomirski
2018-06-15 20:56 ` Rik van Riel
2018-07-11 16:28 ` Sebastian Andrzej Siewior
2018-07-11 20:10 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e415c4d-415b-0ff6-5488-1681e522d2dc@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=riel@surriel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).