From: John Hubbard <jhubbard@nvidia.com>
To: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: <gregkh@linuxfoundation.org>, <surenb@google.com>,
<joaodias@google.com>, LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: cma: support sysfs
Date: Thu, 4 Feb 2021 00:50:58 -0800 [thread overview]
Message-ID: <7e7c01a7-27fe-00a3-f67f-8bcf9ef3eae9@nvidia.com> (raw)
In-Reply-To: <20210203155001.4121868-1-minchan@kernel.org>
On 2/3/21 7:50 AM, Minchan Kim wrote:
> Since CMA is getting used more widely, it's more important to
> keep monitoring CMA statistics for system health since it's
> directly related to user experience.
>
> This patch introduces sysfs for the CMA and exposes stats below
> to keep monitor for telemetric in the system.
>
> * the number of CMA allocation attempts
> * the number of CMA allocation failures
> * the number of CMA page allocation attempts
> * the number of CMA page allocation failures
The desire to report CMA data is understandable, but there are a few
odd things here:
1) First of all, this has significant overlap with /sys/kernel/debug/cma
items. I suspect that all of these items could instead go into
/sys/kernel/debug/cma, right?
2) The overall CMA allocation attempts/failures (first two items above) seem
an odd pair of things to track. Maybe that is what was easy to track, but I'd
vote for just omitting them.
>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
> ---
> Documentation/ABI/testing/sysfs-kernel-mm-cma | 39 +++++
> include/linux/cma.h | 1 +
> mm/Makefile | 1 +
> mm/cma.c | 6 +-
> mm/cma.h | 20 +++
> mm/cma_sysfs.c | 143 ++++++++++++++++++
> 6 files changed, 209 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/ABI/testing/sysfs-kernel-mm-cma
> create mode 100644 mm/cma_sysfs.c
>
> diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-cma b/Documentation/ABI/testing/sysfs-kernel-mm-cma
> new file mode 100644
> index 000000000000..2a43c0aacc39
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-kernel-mm-cma
> @@ -0,0 +1,39 @@
> +What: /sys/kernel/mm/cma/
> +Date: Feb 2021
> +Contact: Minchan Kim <minchan@kernel.org>
> +Description:
> + /sys/kernel/mm/cma/ contains a number of subdirectories by
> + cma-heap name. The subdirectory contains a number of files
> + to represent cma allocation statistics.
Somewhere, maybe here, there should be a mention of the closely related
/sys/kernel/debug/cma files.
> +
> + There are number of files under
> + /sys/kernel/mm/cma/<cma-heap-name> directory
> +
> + - cma_alloc_attempt
> + - cma_alloc_fail
Are these really useful? They a summary of the alloc_pages items, really.
> + - alloc_pages_attempt
> + - alloc_pages_fail
This should also have "cma" in the name, really: cma_alloc_pages_*.
> +
> +What: /sys/kernel/mm/cma/<cma-heap-name>/cma_alloc_attempt
> +Date: Feb 2021
> +Contact: Minchan Kim <minchan@kernel.org>
> +Description:
> + the number of cma_alloc API attempted
> +
> +What: /sys/kernel/mm/cma/<cma-heap-name>/cma_alloc_fail
> +Date: Feb 2021
> +Contact: Minchan Kim <minchan@kernel.org>
> +Description:
> + the number of CMA_alloc API failed
> +
> +What: /sys/kernel/mm/cma/<cma-heap-name>/alloc_pages_attempt
> +Date: Feb 2021
> +Contact: Minchan Kim <minchan@kernel.org>
> +Description:
> + the number of pages CMA API tried to allocate
> +
> +What: /sys/kernel/mm/cma/<cma-heap-name>/alloc_pages_fail
> +Date: Feb 2021
> +Contact: Minchan Kim <minchan@kernel.org>
> +Description:
> + the number of pages CMA API failed to allocate
> diff --git a/include/linux/cma.h b/include/linux/cma.h
> index 217999c8a762..71a28a5bb54e 100644
> --- a/include/linux/cma.h
> +++ b/include/linux/cma.h
> @@ -49,4 +49,5 @@ extern struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align,
> extern bool cma_release(struct cma *cma, const struct page *pages, unsigned int count);
>
> extern int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data);
> +
A single additional blank line seems to be the only change to this file. :)
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2021-02-04 8:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 15:50 [PATCH] mm: cma: support sysfs Minchan Kim
2021-02-04 8:50 ` John Hubbard [this message]
2021-02-04 20:07 ` Minchan Kim
2021-02-04 23:14 ` John Hubbard
2021-02-04 23:43 ` Suren Baghdasaryan
2021-02-04 23:45 ` Suren Baghdasaryan
2021-02-05 0:25 ` John Hubbard
2021-02-05 0:34 ` John Hubbard
2021-02-05 1:44 ` Suren Baghdasaryan
2021-02-05 0:12 ` Minchan Kim
2021-02-05 0:24 ` John Hubbard
2021-02-05 1:44 ` Minchan Kim
2021-02-05 2:39 ` Suren Baghdasaryan
2021-02-05 2:52 ` John Hubbard
2021-02-05 5:17 ` Minchan Kim
2021-02-05 5:49 ` John Hubbard
2021-02-05 6:24 ` Minchan Kim
2021-02-05 6:41 ` John Hubbard
2021-02-05 16:15 ` Minchan Kim
2021-02-05 20:25 ` John Hubbard
2021-02-05 21:28 ` Minchan Kim
2021-02-05 21:52 ` Suren Baghdasaryan
2021-02-05 21:58 ` John Hubbard
2021-02-05 22:47 ` Minchan Kim
2021-02-06 17:08 ` Pintu Agarwal
2021-02-08 8:39 ` John Hubbard
2021-02-05 21:57 ` John Hubbard
2021-02-05 2:55 ` Matthew Wilcox
2021-02-05 5:22 ` Minchan Kim
2021-02-05 12:12 ` Matthew Wilcox
2021-02-05 16:16 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e7c01a7-27fe-00a3-f67f-8bcf9ef3eae9@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=joaodias@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).