From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, kan.liang@linux.intel.com,
alexander.shishkin@linux.intel.com
Subject: Re: [PATCH v1 2/7] perf/x86/intel: Support PEBS output to PT
Date: Wed, 31 Jul 2019 17:02:05 +0300 [thread overview]
Message-ID: <871ry6480y.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190729133705.GC31381@hirez.programming.kicks-ass.net>
Peter Zijlstra <peterz@infradead.org> writes:
> On Thu, Jul 04, 2019 at 07:00:19PM +0300, Alexander Shishkin wrote:
>> + /*
>> + * In case there's a mix of PEBS->PT and PEBS->DS, fall back
>> + * to DS.
>> + */
>
> I thought we disallowed that from happening !?
Yes, that was a weird leftover.
Thanks a bunch for the comments, they should all be addressed in v2:
https://marc.info/?l=linux-kernel&m=156458152126310
Regards,
--
Alex
next prev parent reply other threads:[~2019-07-31 14:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 16:00 [PATCH v1 0/7] perf, intel: Add support for PEBS output to Intel PT Alexander Shishkin
2019-07-04 16:00 ` [PATCH v1 1/7] perf: Allow normal events to be sources of AUX data Alexander Shishkin
2019-07-29 11:31 ` Peter Zijlstra
2019-07-04 16:00 ` [PATCH v1 2/7] perf/x86/intel: Support PEBS output to PT Alexander Shishkin
2019-07-29 13:37 ` Peter Zijlstra
2019-07-31 14:02 ` Alexander Shishkin [this message]
2019-07-04 16:00 ` [PATCH v1 3/7] perf tools: Add aux_source attribute flag Alexander Shishkin
2019-07-04 16:00 ` [PATCH v1 4/7] perf tools: Add itrace option 'o' to synthesize aux-source events Alexander Shishkin
2019-07-04 16:00 ` [PATCH v1 5/7] perf intel-pt: Process options for PEBS event synthesis Alexander Shishkin
2019-07-04 16:00 ` [PATCH v1 6/7] perf tools: Add aux-source config term Alexander Shishkin
2019-07-04 16:00 ` [PATCH v1 7/7] perf intel-pt: Add brief documentation for PEBS via Intel PT Alexander Shishkin
2019-07-29 8:10 ` [PATCH v1 0/7] perf, intel: Add support for PEBS output to " Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ry6480y.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=acme@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).