From: Mason <slash.tmp@free.fr>
To: Marc Zyngier <marc.zyngier@arm.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
David Laight <david.laight@aculab.com>,
linux-pci <linux-pci@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Thibaud Cornic <thibaud_cornic@sigmadesigns.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v0.2] PCI: Add support for tango PCIe host bridge
Date: Wed, 19 Apr 2017 13:19:20 +0200 [thread overview]
Message-ID: <87d48d57-5f9f-1b35-99da-ab39de2d3d48@free.fr> (raw)
In-Reply-To: <37cd6172-b04e-fcad-18fc-4fbb26cc611b@arm.com>
On 12/04/2017 11:59, Marc Zyngier wrote:
> And that's *wrong*. I've repeatedly said that you only need to deal with
> *your* irqchip. End of story. Nowhere else. Please leave the MSI irqchip
> alone, it is very unlikely that you have to provide anything at all to it.
Hello Marc,
I am hoping you can help me pinpoint what's missing in my code,
to have it behave the way you describe.
As you have stated, I have *two* struct irq_chip:
one is mine (tango_chip), the other not_mine (msi_chip).
static struct irq_chip tango_chip = {
.name = "TANGO IRQ_CHIP",
.irq_compose_msi_msg = tango_compose_msi_msg,
.irq_set_affinity = tango_set_affinity,
.irq_ack = tango_ack,
.irq_mask = tango_mask,
.irq_unmask = tango_unmask,
};
static struct irq_chip msi_chip = {
.name = "NOT MY IRQ_CHIP",
.irq_ack = not_mine_ack,
.irq_mask = not_mine_mask,
.irq_unmask = not_mine_unmask,
};
A struct msi_domain_info links to the msi_chip.
static struct msi_domain_info msi_dom_info = {
.flags = MSI_FLAG_PCI_MSIX | MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS,
.chip = &msi_chip,
};
irq_dom = irq_domain_create_linear(fwnode, MSI_COUNT, &irq_dom_ops, pcie);
msi_dom = pci_msi_create_irq_domain(fwnode, &msi_dom_info, irq_dom);
I believe irq_dom and tango_chip are tied together by:
irq_domain_set_info(dom, virq, pos, &tango_chip, pcie, handle_edge_irq, NULL, NULL);
My biggest problem is that tango_unmask() is never called.
Here is the log of function calls as they happen on my system:
[ 0.361586] TANGO irq_chip=c0d10a00 MSI irq_chip=c0d10aa8
[ 0.361595] IRQ_DOM=cf9db300 MSI_DOM=cf9b5080
[ 0.363214] find_free_msi: dom=cf9db300 virq=30 hwirq=0 chip=c0d10a00 cdata=cfb0a410
[ 0.363314] [<c0316e54>] (tango_irq_domain_alloc) from [<c0163468>] (msi_domain_alloc+0x68/0x128)
[ 0.363543] ENTER tango_compose_msi_msg
[ 0.363552] TANGO IRQ_CHIP: irq_data=cfaf4180 irq=30 hwirq=0 chip=c0d10a00 dom=cf9db300 pdata= (null) cdata=cfb0a410
[ 0.363609] [<c0316ca4>] (tango_compose_msi_msg) from [<c015f654>] (irq_chip_compose_msi_msg+0x48/0x58)
[ 0.363928] ENTER not_mine_unmask
[ 0.363943] NOT MY IRQ_CHIP: irq_data=cf940110 irq=30 hwirq=0 chip=c0d10aa8 dom=cf9b5080 pdata=cfaf4180 cdata= (null)
[ 0.364012] [<c0316c48>] (not_mine_unmask) from [<c015edc0>] (irq_enable+0x30/0x44)
[ 2.475111] find_free_msi: dom=cf9db300 virq=34 hwirq=1 chip=c0d10a00 cdata=cfb0a410
[ 2.516895] [<c0316e54>] (tango_irq_domain_alloc) from [<c0163468>] (msi_domain_alloc+0x68/0x128)
[ 2.686593] find_free_msi: dom=cf9db300 virq=35 hwirq=2 chip=c0d10a00 cdata=cfb0a410
[ 2.728334] [<c0316e54>] (tango_irq_domain_alloc) from [<c0163468>] (msi_domain_alloc+0x68/0x128)
[ 2.897946] find_free_msi: dom=cf9db300 virq=36 hwirq=3 chip=c0d10a00 cdata=cfb0a410
[ 2.939680] [<c0316e54>] (tango_irq_domain_alloc) from [<c0163468>] (msi_domain_alloc+0x68/0x128)
[ 3.109254] ENTER tango_compose_msi_msg
[ 3.114603] TANGO IRQ_CHIP: irq_data=cfb4b500 irq=34 hwirq=1 chip=c0d10a00 dom=cf9db300 pdata= (null) cdata=cfb0a410
[ 3.160621] [<c0316ca4>] (tango_compose_msi_msg) from [<c015f654>] (irq_chip_compose_msi_msg+0x48/0x58)
[ 3.340161] ENTER tango_compose_msi_msg
[ 3.345507] TANGO IRQ_CHIP: irq_data=cfb4b440 irq=35 hwirq=2 chip=c0d10a00 dom=cf9db300 pdata= (null) cdata=cfb0a410
[ 3.391522] [<c0316ca4>] (tango_compose_msi_msg) from [<c015f654>] (irq_chip_compose_msi_msg+0x48/0x58)
[ 3.571148] ENTER tango_compose_msi_msg
[ 3.576503] TANGO IRQ_CHIP: irq_data=cfb4b380 irq=36 hwirq=3 chip=c0d10a00 dom=cf9db300 pdata= (null) cdata=cfb0a410
[ 3.631966] [<c015f654>] (irq_chip_compose_msi_msg) from [<c016362c>] (msi_domain_activate+0x18/0x40)
[ 3.802121] ENTER not_mine_unmask
[ 3.806937] NOT MY IRQ_CHIP: irq_data=cf95c210 irq=34 hwirq=524288 chip=c0d10aa8 dom=cf9b5080 pdata=cfb4b500 cdata= (null)
[ 3.852943] [<c0316c48>] (not_mine_unmask) from [<c015edc0>] (irq_enable+0x30/0x44)
[ 3.998596] ENTER not_mine_unmask
[ 4.003410] NOT MY IRQ_CHIP: irq_data=cf95c010 irq=35 hwirq=524289 chip=c0d10aa8 dom=cf9b5080 pdata=cfb4b440 cdata= (null)
[ 4.049415] [<c0316c48>] (not_mine_unmask) from [<c015edc0>] (irq_enable+0x30/0x44)
[ 4.195055] ENTER not_mine_unmask
[ 4.199870] NOT MY IRQ_CHIP: irq_data=cf97cf10 irq=36 hwirq=524290 chip=c0d10aa8 dom=cf9b5080 pdata=cfb4b380 cdata= (null)
[ 4.245874] [<c0316c48>] (not_mine_unmask) from [<c015edc0>] (irq_enable+0x30/0x44)
It's driving me nuts. Do you know what might be wrong?
Regards.
next prev parent reply other threads:[~2017-04-19 11:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 13:05 [RFC PATCH v0.2] PCI: Add support for tango PCIe host bridge Mason
2017-03-23 14:22 ` Marc Zyngier
2017-03-23 17:03 ` Mason
2017-03-23 23:40 ` Mason
2017-03-24 18:22 ` Marc Zyngier
2017-03-27 14:35 ` Mason
2017-03-27 14:46 ` Thomas Gleixner
2017-03-27 15:18 ` Mason
2017-03-24 18:47 ` Marc Zyngier
2017-03-27 15:53 ` Mason
2017-03-27 17:09 ` Marc Zyngier
2017-03-27 19:44 ` Mason
2017-03-27 21:07 ` Marc Zyngier
2017-03-27 22:04 ` Mason
2017-03-28 8:21 ` Marc Zyngier
2017-04-11 15:13 ` Mason
2017-04-11 15:49 ` Marc Zyngier
2017-04-11 16:26 ` Mason
2017-04-11 16:43 ` Marc Zyngier
2017-04-11 17:52 ` Mason
2017-04-12 8:08 ` Marc Zyngier
2017-04-12 9:50 ` Mason
2017-04-12 9:59 ` Marc Zyngier
2017-04-19 11:19 ` Mason [this message]
2017-04-20 8:20 ` Mason
2017-04-20 9:43 ` Marc Zyngier
2017-03-29 11:39 ` Mason
2017-03-30 11:09 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d48d57-5f9f-1b35-99da-ab39de2d3d48@free.fr \
--to=slash.tmp@free.fr \
--cc=david.laight@aculab.com \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=thibaud_cornic@sigmadesigns.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).