[PATCH] fat-fs printk arg. fix

[PATCH] fat-fs printk arg. fix

[Randy.Dunlap]

Hi,

A recent fatfs patch for large partitions upset printk.
Here's a patch for it.

--
~Randy


patch_name:	fat-printk.patch
patch_version:	2003-06-03.15:37:48
author:		Randy.Dunlap <rddunlap@osdl.org>
description:	printk() args are unhappy with recent change for large
		partition support;
product:	Linux
product_versions: 2.5.70
maintainer:	OGAWA Hirofumi
diffstat:	=
 fs/fat/misc.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


diff -Naur ./fs/fat/misc.c%PRTK ./fs/fat/misc.c
--- ./fs/fat/misc.c%PRTK	2003-06-02 14:35:15.000000000 -0700
+++ ./fs/fat/misc.c	2003-06-03 14:40:49.000000000 -0700
@@ -311,7 +311,7 @@
 	*bh = sb_bread(sb, phys);
 	if (*bh == NULL) {
 		printk(KERN_ERR "FAT: Directory bread(block %llu) failed\n",
-		       phys);
+		       (u64)phys);
 		/* skip this block */
 		*pos = (iblock + 1) << sb->s_blocksize_bits;
 		goto next;

Re: [PATCH] fat-fs printk arg. fix

[Andrew Morton]

"Randy.Dunlap" <rddunlap@osdl.org> wrote:
>
>  		printk(KERN_ERR "FAT: Directory bread(block %llu) failed\n",
> -		       phys);
> +		       (u64)phys);

The printk control string says, precisely, "unsigned long long".  So that
is what we should be casting the argument to.

I have made that change, thanks.

Re: [PATCH] fat-fs printk arg. fix

[OGAWA Hirofumi]

"Randy.Dunlap" <rddunlap@osdl.org> writes:

>  		printk(KERN_ERR "FAT: Directory bread(block %llu) failed\n",
> -		       phys);
> +		       (u64)phys);
>  		/* skip this block */
>  		*pos = (iblock + 1) << sb->s_blocksize_bits;
>  		goto next;

I was forgeting that issue of sector_t with printk. Thanks for
correcting.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

[PATCH] fat-fs printk arg. fix

[Peter Chubb]

>>>>> "Randy" == Randy Dunlap <Randy.Dunlap> writes:

Randy> Hi, A recent fatfs patch for large partitions upset printk.

Please cast to unsigned long long, not to u64, or the 64-bit
architectures (where u64 is unsigned long, not unsigned long long)
will see warnings.



PeterC