linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm: drop drm_property_unreference_blob_locked()
@ 2015-05-19 11:38 Sergey Senozhatsky
  2015-05-20  7:09 ` Jani Nikula
  0 siblings, 1 reply; 3+ messages in thread
From: Sergey Senozhatsky @ 2015-05-19 11:38 UTC (permalink / raw)
  To: David Airlie
  Cc: Daniel Stone, Maarten Lankhorst, dri-devel, linux-kernel,
	Sergey Senozhatsky

drm_property_unreference_blob_locked() is static and unused,
drop it.

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
 drivers/gpu/drm/drm_crtc.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 4059f06..6e60f71 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -4313,25 +4313,6 @@ void drm_property_unreference_blob(struct drm_property_blob *blob)
 EXPORT_SYMBOL(drm_property_unreference_blob);
 
 /**
- * drm_property_unreference_blob_locked - Unreference a blob property with blob_lock held
- *
- * Drop a reference on a blob property. May free the object. This must be
- * called with blob_lock held.
- *
- * @param dev  Device the blob was created on
- * @param blob Pointer to blob property
- */
-static void drm_property_unreference_blob_locked(struct drm_property_blob *blob)
-{
-	if (!blob)
-		return;
-
-	DRM_DEBUG("%p: blob ID: %d (%d)\n", blob, blob->base.id, atomic_read(&blob->refcount.refcount));
-
-	kref_put(&blob->refcount, drm_property_free_blob);
-}
-
-/**
  * drm_property_reference_blob - Take a reference on an existing property
  *
  * Take a new reference on an existing blob property.
-- 
2.4.1.168.g1ea28e1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm: drop drm_property_unreference_blob_locked()
  2015-05-19 11:38 [PATCH] drm: drop drm_property_unreference_blob_locked() Sergey Senozhatsky
@ 2015-05-20  7:09 ` Jani Nikula
  2015-05-20 11:50   ` Sergey Senozhatsky
  0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2015-05-20  7:09 UTC (permalink / raw)
  To: Sergey Senozhatsky, David Airlie
  Cc: Sergey Senozhatsky, Daniel Stone, dri-devel, linux-kernel

On Tue, 19 May 2015, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> drm_property_unreference_blob_locked() is static and unused,
> drop it.

http://mid.gmane.org/CAPj87rMPtafeYNzgXoP+fx0dAqhwaD7kdnJgqb_vdbPtiOrXPg@mail.gmail.com

>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---
>  drivers/gpu/drm/drm_crtc.c | 19 -------------------
>  1 file changed, 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 4059f06..6e60f71 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -4313,25 +4313,6 @@ void drm_property_unreference_blob(struct drm_property_blob *blob)
>  EXPORT_SYMBOL(drm_property_unreference_blob);
>  
>  /**
> - * drm_property_unreference_blob_locked - Unreference a blob property with blob_lock held
> - *
> - * Drop a reference on a blob property. May free the object. This must be
> - * called with blob_lock held.
> - *
> - * @param dev  Device the blob was created on
> - * @param blob Pointer to blob property
> - */
> -static void drm_property_unreference_blob_locked(struct drm_property_blob *blob)
> -{
> -	if (!blob)
> -		return;
> -
> -	DRM_DEBUG("%p: blob ID: %d (%d)\n", blob, blob->base.id, atomic_read(&blob->refcount.refcount));
> -
> -	kref_put(&blob->refcount, drm_property_free_blob);
> -}
> -
> -/**
>   * drm_property_reference_blob - Take a reference on an existing property
>   *
>   * Take a new reference on an existing blob property.
> -- 
> 2.4.1.168.g1ea28e1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm: drop drm_property_unreference_blob_locked()
  2015-05-20  7:09 ` Jani Nikula
@ 2015-05-20 11:50   ` Sergey Senozhatsky
  0 siblings, 0 replies; 3+ messages in thread
From: Sergey Senozhatsky @ 2015-05-20 11:50 UTC (permalink / raw)
  To: Jani Nikula
  Cc: Sergey Senozhatsky, David Airlie, Daniel Stone, dri-devel, linux-kernel

On (05/20/15 10:09), Jani Nikula wrote:
> > drm_property_unreference_blob_locked() is static and unused,
> > drop it.
> 
> http://mid.gmane.org/CAPj87rMPtafeYNzgXoP+fx0dAqhwaD7kdnJgqb_vdbPtiOrXPg@mail.gmail.com
> 

oh, ok. thanks.

	-ss

> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > ---
> >  drivers/gpu/drm/drm_crtc.c | 19 -------------------
> >  1 file changed, 19 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> > index 4059f06..6e60f71 100644
> > --- a/drivers/gpu/drm/drm_crtc.c
> > +++ b/drivers/gpu/drm/drm_crtc.c
> > @@ -4313,25 +4313,6 @@ void drm_property_unreference_blob(struct drm_property_blob *blob)
> >  EXPORT_SYMBOL(drm_property_unreference_blob);
> >  
> >  /**
> > - * drm_property_unreference_blob_locked - Unreference a blob property with blob_lock held
> > - *
> > - * Drop a reference on a blob property. May free the object. This must be
> > - * called with blob_lock held.
> > - *
> > - * @param dev  Device the blob was created on
> > - * @param blob Pointer to blob property
> > - */
> > -static void drm_property_unreference_blob_locked(struct drm_property_blob *blob)
> > -{
> > -	if (!blob)
> > -		return;
> > -
> > -	DRM_DEBUG("%p: blob ID: %d (%d)\n", blob, blob->base.id, atomic_read(&blob->refcount.refcount));
> > -
> > -	kref_put(&blob->refcount, drm_property_free_blob);
> > -}
> > -
> > -/**
> >   * drm_property_reference_blob - Take a reference on an existing property
> >   *
> >   * Take a new reference on an existing blob property.
> > -- 
> > 2.4.1.168.g1ea28e1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-05-20 11:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-19 11:38 [PATCH] drm: drop drm_property_unreference_blob_locked() Sergey Senozhatsky
2015-05-20  7:09 ` Jani Nikula
2015-05-20 11:50   ` Sergey Senozhatsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).