linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] block: Remove redundant 'return' statement
@ 2020-09-28  0:42 Baolin Wang
  2020-10-08  3:40 ` Baolin Wang
  2020-10-08 14:00 ` Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Baolin Wang @ 2020-09-28  0:42 UTC (permalink / raw)
  To: tj, axboe; +Cc: baolin.wang, baolin.wang7, linux-block, cgroups, linux-kernel

Remove redundant 'return' statement for 'void' functions.

Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
---
 block/blk-iocost.c    | 2 +-
 block/blk-iolatency.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-iocost.c b/block/blk-iocost.c
index ef9476f..e38c406 100644
--- a/block/blk-iocost.c
+++ b/block/blk-iocost.c
@@ -3343,7 +3343,7 @@ static int __init ioc_init(void)
 
 static void __exit ioc_exit(void)
 {
-	return blkcg_policy_unregister(&blkcg_policy_iocost);
+	blkcg_policy_unregister(&blkcg_policy_iocost);
 }
 
 module_init(ioc_init);
diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c
index f90429c..81be009 100644
--- a/block/blk-iolatency.c
+++ b/block/blk-iolatency.c
@@ -1046,7 +1046,7 @@ static int __init iolatency_init(void)
 
 static void __exit iolatency_exit(void)
 {
-	return blkcg_policy_unregister(&blkcg_policy_iolatency);
+	blkcg_policy_unregister(&blkcg_policy_iolatency);
 }
 
 module_init(iolatency_init);
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] block: Remove redundant 'return' statement
  2020-09-28  0:42 [PATCH] block: Remove redundant 'return' statement Baolin Wang
@ 2020-10-08  3:40 ` Baolin Wang
  2020-10-08 14:00 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Baolin Wang @ 2020-10-08  3:40 UTC (permalink / raw)
  To: tj, axboe; +Cc: baolin.wang7, linux-block, cgroups, linux-kernel

Hi,

On Mon, Sep 28, 2020 at 08:42:26AM +0800, Baolin Wang wrote:
> Remove redundant 'return' statement for 'void' functions.
> 
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>

Gentle ping?

> ---
>  block/blk-iocost.c    | 2 +-
>  block/blk-iolatency.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/blk-iocost.c b/block/blk-iocost.c
> index ef9476f..e38c406 100644
> --- a/block/blk-iocost.c
> +++ b/block/blk-iocost.c
> @@ -3343,7 +3343,7 @@ static int __init ioc_init(void)
>  
>  static void __exit ioc_exit(void)
>  {
> -	return blkcg_policy_unregister(&blkcg_policy_iocost);
> +	blkcg_policy_unregister(&blkcg_policy_iocost);
>  }
>  
>  module_init(ioc_init);
> diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c
> index f90429c..81be009 100644
> --- a/block/blk-iolatency.c
> +++ b/block/blk-iolatency.c
> @@ -1046,7 +1046,7 @@ static int __init iolatency_init(void)
>  
>  static void __exit iolatency_exit(void)
>  {
> -	return blkcg_policy_unregister(&blkcg_policy_iolatency);
> +	blkcg_policy_unregister(&blkcg_policy_iolatency);
>  }
>  
>  module_init(iolatency_init);
> -- 
> 1.8.3.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] block: Remove redundant 'return' statement
  2020-09-28  0:42 [PATCH] block: Remove redundant 'return' statement Baolin Wang
  2020-10-08  3:40 ` Baolin Wang
@ 2020-10-08 14:00 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2020-10-08 14:00 UTC (permalink / raw)
  To: Baolin Wang, tj; +Cc: baolin.wang7, linux-block, cgroups, linux-kernel

On 9/27/20 6:42 PM, Baolin Wang wrote:
> Remove redundant 'return' statement for 'void' functions.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-08 14:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28  0:42 [PATCH] block: Remove redundant 'return' statement Baolin Wang
2020-10-08  3:40 ` Baolin Wang
2020-10-08 14:00 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).