linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	John Fastabend <john.fastabend@gmail.com>,
	netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [RFC PATCH v2] ptr_ring: linked list fallback
Date: Wed, 28 Feb 2018 11:39:15 +0800	[thread overview]
Message-ID: <909327f0-52b8-5c3c-47fe-7b1b71dca196@redhat.com> (raw)
In-Reply-To: <b73c7c1e-4a63-45c0-cef5-0ec8f1195eca@redhat.com>



On 2018年02月28日 11:28, Jason Wang wrote:
>>> Well I believe the main user for this is qdisc, which use skb array. 
>>> And we
>>> can not use what implemented in this patch directly for sk_buff 
>>> without some
>>> changes on the data structure.
>> Why not? skb has next and prev pointers at 1st two fields:
>>
>> struct sk_buff {
>>          union {
>>                  struct {
>>                          /* These two members must be first. */
>>                          struct sk_buff          *next;
>>                          struct sk_buff          *prev;
>> ...
>> }
>>
>> so it's just a question of casting to struct plist.
>
> Well, then the casting can only be done in skb_array implementation? 

Ok, could be done in ptr ring. But still looks tricky, because of the 
different meaning of prev and last.

Thanks

  reply	other threads:[~2018-02-28  3:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26  1:17 [RFC PATCH v2] ptr_ring: linked list fallback Michael S. Tsirkin
2018-02-26  3:15 ` Jason Wang
2018-02-26 20:34   ` Michael S. Tsirkin
2018-02-27  2:29     ` Jason Wang
2018-02-27 17:12       ` Michael S. Tsirkin
2018-02-28  3:28         ` Jason Wang
2018-02-28  3:39           ` Jason Wang [this message]
2018-02-28  4:11             ` Michael S. Tsirkin
2018-02-28  4:09           ` Michael S. Tsirkin
2018-02-28  6:28             ` Jason Wang
2018-02-28 14:01               ` Michael S. Tsirkin
2018-02-28 14:20                 ` Jason Wang
2018-02-28 15:43                   ` Michael S. Tsirkin
2018-03-01  6:41                     ` Jason Wang
2018-02-27 17:53 ` Eric Dumazet
2018-02-27 19:35   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=909327f0-52b8-5c3c-47fe-7b1b71dca196@redhat.com \
    --to=jasowang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=john.fastabend@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).