linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Dmitry Osipenko' <digetx@gmail.com>, Sameer Pujar <spujar@nvidia.com>
Cc: "perex@perex.cz" <perex@perex.cz>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"sharadg@nvidia.com" <sharadg@nvidia.com>,
	"mkumard@nvidia.com" <mkumard@nvidia.com>,
	"viswanathl@nvidia.com" <viswanathl@nvidia.com>,
	"rlokhande@nvidia.com" <rlokhande@nvidia.com>,
	"dramesh@nvidia.com" <dramesh@nvidia.com>,
	"atalambedu@nvidia.com" <atalambedu@nvidia.com>
Subject: RE: [PATCH v2 4/9] ASoC: tegra: add Tegra210 based I2S driver
Date: Thu, 6 Feb 2020 17:06:47 +0000	[thread overview]
Message-ID: <90ae7badcb3441daa8144233de8f6825@AcuMS.aculab.com> (raw)
In-Reply-To: <3a586a6b-5f53-dc44-b9fc-67c633c626ef@gmail.com>

From: f Dmitry Osipenko
> Sent: 06 February 2020 16:59
> 
> 30.01.2020 13:33, Sameer Pujar пишет:
> ...
> > +static const int tegra210_cif_fmt[] = {
> > +	0,
> > +	TEGRA_ACIF_BITS_16,
> > +	TEGRA_ACIF_BITS_32,
> > +};
> > +
> > +static const int tegra210_i2s_bit_fmt[] = {
> > +	0,
> > +	I2S_BITS_16,
> > +	I2S_BITS_32,
> > +};
> > +
> > +static const int tegra210_i2s_sample_size[] = {
> > +	0,
> > +	16,
> > +	32,
> > +};
> 
> static const *unsigned* int?

Or get rid of the table lookups completely.
Assuming the index is never zero then the value
can be calculated as (const_a + const_b * index).

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

  reply	other threads:[~2020-02-06 17:06 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30 10:33 [PATCH v2 0/9] add ASoC components for AHUB Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 1/9] dt-bindings: sound: tegra: add DT binding " Sameer Pujar
2020-02-03 20:19   ` Dmitry Osipenko
2020-02-04  4:24     ` Sameer Pujar
2020-02-06 18:10   ` Rob Herring
2020-02-10 11:30     ` Sameer Pujar
2020-02-11 18:15       ` Rob Herring
2020-01-30 10:33 ` [PATCH v2 2/9] ASoC: tegra: add support for CIF programming Sameer Pujar
2020-02-05 17:02   ` Dmitry Osipenko
2020-02-06 11:56     ` Sameer Pujar
2020-02-06 16:49       ` Dmitry Osipenko
2020-02-07 11:03         ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 3/9] ASoC: tegra: add Tegra210 based DMIC driver Sameer Pujar
2020-02-06 16:53   ` Dmitry Osipenko
2020-02-07 11:06     ` Sameer Pujar
2020-02-08 16:19       ` Dmitry Osipenko
2020-01-30 10:33 ` [PATCH v2 4/9] ASoC: tegra: add Tegra210 based I2S driver Sameer Pujar
2020-02-06 16:59   ` Dmitry Osipenko
2020-02-06 17:06     ` David Laight [this message]
2020-02-07 11:23       ` Sameer Pujar
2020-02-07 11:24     ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 5/9] ASoC: tegra: add Tegra210 based AHUB driver Sameer Pujar
2020-01-30 16:22   ` Dmitry Osipenko
2020-02-04  4:29     ` Sameer Pujar
2020-01-30 17:09   ` Dmitry Osipenko
2020-01-30 17:18     ` Dmitry Osipenko
2020-02-04  4:35       ` Sameer Pujar
2020-02-04  4:34     ` Sameer Pujar
2020-01-30 17:25   ` Dmitry Osipenko
2020-01-31  3:12     ` Sameer Pujar
2020-01-31 14:34       ` Dmitry Osipenko
2020-02-04  4:36     ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 6/9] ASoC: tegra: add Tegra186 based DSPK driver Sameer Pujar
2020-02-06 17:15   ` Dmitry Osipenko
2020-02-07 11:26     ` Sameer Pujar
2020-02-07 18:22       ` Dmitry Osipenko
2020-02-10 11:15         ` Sameer Pujar
2020-02-10 12:22           ` Jon Hunter
2020-02-10 14:49             ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 8/9] arm64: tegra: add AHUB components for few Tegra chips Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 9/9] arm64: tegra: enable AHUB modules " Sameer Pujar
2020-02-06 17:36 ` [PATCH v2 0/9] add ASoC components for AHUB Dmitry Osipenko
2020-02-07 11:30   ` Sameer Pujar
2020-02-07 18:25     ` Dmitry Osipenko
2020-02-10 11:22       ` Sameer Pujar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90ae7badcb3441daa8144233de8f6825@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=atalambedu@nvidia.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=dramesh@nvidia.com \
    --cc=jonathanh@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mkumard@nvidia.com \
    --cc=perex@perex.cz \
    --cc=rlokhande@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=sharadg@nvidia.com \
    --cc=spujar@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    --cc=viswanathl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).