Re: [PATCH v2 1/9] dt-bindings: sound: tegra: add DT binding for AHUB

From: Rob Herring <robh@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jon Hunter <jonathanh@nvidia.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	Linux-ALSA <alsa-devel@alsa-project.org>,
	devicetree@vger.kernel.org,
	linux-tegra <linux-tegra@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	sharadg@nvidia.com, mkumard@nvidia.com, viswanathl@nvidia.com,
	rlokhande@nvidia.com, dramesh@nvidia.com, atalambedu@nvidia.com
Subject: Re: [PATCH v2 1/9] dt-bindings: sound: tegra: add DT binding for AHUB
Date: Tue, 11 Feb 2020 12:15:53 -0600	[thread overview]
Message-ID: <CAL_JsqKCzR5DXm_ip-mrrPyeAUcZJRWi_cQEhPd7agp9T_uumA@mail.gmail.com> (raw)
In-Reply-To: <af58b6b2-25b2-e968-73c9-d87e1a9e2746@nvidia.com>

On Mon, Feb 10, 2020 at 5:31 AM Sameer Pujar <spujar@nvidia.com> wrote:
>
>
>
> On 2/6/2020 11:40 PM, Rob Herring wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On Thu, Jan 30, 2020 at 04:03:34PM +0530, Sameer Pujar wrote:
> >> Audio Hub (AHUB) comprises a collection of hardware accelerators for audio
> >> pre-processing and post-processing and a programmable full crossbar for
> >> audio routing across these accelerators. This patch adds YAML schema for DT
> >> binding of AHUB and few of its following components. These devices will be
> >> registered as ASoC components.
> >>   * ADMAIF
> >>   * I2S
> >>   * DMIC
> >>   * DSPK
> >>
> >> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> >> ---
> >>   .../bindings/sound/nvidia,tegra186-dspk.yaml       | 105 +++++++++++++
> >>   .../bindings/sound/nvidia,tegra210-admaif.yaml     | 165 +++++++++++++++++++++
> >>   .../bindings/sound/nvidia,tegra210-ahub.yaml       | 130 ++++++++++++++++
> >>   .../bindings/sound/nvidia,tegra210-dmic.yaml       | 105 +++++++++++++
> >>   .../bindings/sound/nvidia,tegra210-i2s.yaml        | 112 ++++++++++++++
> >>   5 files changed, 617 insertions(+)
> >>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> >>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
> >>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
> >>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml
> >>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> >> new file mode 100644
> >> index 0000000..dc9fef3
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> >> @@ -0,0 +1,105 @@
> >> +# SPDX-License-Identifier: (GPL-2.0)
> . . .
> >> +    items:
> >> +      - description: initial module clock rate
> >> +
> >> +  "#sound-dai-cells":
> >> +    const: 1
> >> +
> >> +  sound-name-prefix:
> >> +    $ref: /schemas/types.yaml#/definitions/string
> >> +    description:
> >> +      Used as prefix for sink/source names of the component. Must be a
> >> +      unique string among multiple instances of the same component.
> >> +      The name can be "DSPK1" or "DSPKx", where x depends on the maximum
> > Sounds like a constraint.
>
> Is there a better way to convey the recommended strings above?

pattern: '^DSPK[1-9]$'

Adjusting the number range regex as you need.

(And $ref will need to be under an 'allOf')

Rob