* [PATCH net-next] drivers: net: ionic: simplify the return expression of ionic_set_rxfh()
@ 2020-12-08 13:53 Zheng Yongjun
2020-12-09 18:02 ` Shannon Nelson
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2020-12-08 13:53 UTC (permalink / raw)
To: drivers, davem, kuba, leon, netdev, linux-kernel; +Cc: Zheng Yongjun
Simplify the return expression.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
index 35c72d4a78b3..0832bedcb3b4 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
@@ -738,16 +738,11 @@ static int ionic_set_rxfh(struct net_device *netdev, const u32 *indir,
const u8 *key, const u8 hfunc)
{
struct ionic_lif *lif = netdev_priv(netdev);
- int err;
if (hfunc != ETH_RSS_HASH_NO_CHANGE && hfunc != ETH_RSS_HASH_TOP)
return -EOPNOTSUPP;
- err = ionic_lif_rss_config(lif, lif->rss_types, key, indir);
- if (err)
- return err;
-
- return 0;
+ return ionic_lif_rss_config(lif, lif->rss_types, key, indir);
}
static int ionic_set_tunable(struct net_device *dev,
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] drivers: net: ionic: simplify the return expression of ionic_set_rxfh()
2020-12-08 13:53 [PATCH net-next] drivers: net: ionic: simplify the return expression of ionic_set_rxfh() Zheng Yongjun
@ 2020-12-09 18:02 ` Shannon Nelson
0 siblings, 0 replies; 2+ messages in thread
From: Shannon Nelson @ 2020-12-09 18:02 UTC (permalink / raw)
To: Zheng Yongjun, drivers, davem, kuba, leon, netdev, linux-kernel
On 12/8/20 5:53 AM, Zheng Yongjun wrote:
> Simplify the return expression.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Acked-by: Shannon Nelson <snelson@pensando.io>
> ---
> drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> index 35c72d4a78b3..0832bedcb3b4 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> @@ -738,16 +738,11 @@ static int ionic_set_rxfh(struct net_device *netdev, const u32 *indir,
> const u8 *key, const u8 hfunc)
> {
> struct ionic_lif *lif = netdev_priv(netdev);
> - int err;
>
> if (hfunc != ETH_RSS_HASH_NO_CHANGE && hfunc != ETH_RSS_HASH_TOP)
> return -EOPNOTSUPP;
>
> - err = ionic_lif_rss_config(lif, lif->rss_types, key, indir);
> - if (err)
> - return err;
> -
> - return 0;
> + return ionic_lif_rss_config(lif, lif->rss_types, key, indir);
> }
>
> static int ionic_set_tunable(struct net_device *dev,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-09 18:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08 13:53 [PATCH net-next] drivers: net: ionic: simplify the return expression of ionic_set_rxfh() Zheng Yongjun
2020-12-09 18:02 ` Shannon Nelson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).