linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Codrin.Ciubotariu@microchip.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Cc: lgirdwood@gmail.com, broonie@kernel.org, mirq-linux@rere.qmqm.pl,
	gustavoars@kernel.org, tiwai@suse.com
Subject: Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones
Date: Wed, 24 Mar 2021 10:28:24 -0500	[thread overview]
Message-ID: <95d0f1c1-5a89-837f-b1dc-42482a3b1250@linux.intel.com> (raw)
In-Reply-To: <2e9d903f-dd76-5b22-77ea-5fc42be306fd@microchip.com>


> I am using hw_params_fixup, but it's not enough. The first thing I do is
> to not add the BE HW constraint rules in runtime->hw_constraints,
> because this will potentially affect the FE HW params. If the FE does
> sampling rate conversion, for example, applying the sampling rate
> constrain rules from a BE codec on FE is useless. The second thing I do
> is to apply these BE HW constraint rules to the BE HW params. It's true
> that the BE HW params can be fine tuned via hw_params_fixup (topology,
> device-tree or even static parameters) and set in such a way that avoid
> the BE HW constraints, so we could ignore the constraint rules added by
> their drivers. It's not every elegant and running the BE HW constraint
> rules for the fixup BE HW params can be a sanity check. Also, I am
> thinking that if the FE does no conversion (be_hw_params_fixup missing)
> and more than one BEs are available, applying the HW constraint rules on
> the same set of BE HW params could rule out the incompatible BE DAI
> links and start the compatible ones only. I am not sure this is a real
> usecase.

Even after a second cup of coffee I was not able to follow why the 
hw_params_fixup was not enough? That paragraph is rather dense.

And to be frank I don't fully understand the problem statement above: 
"separate the FE HW constraints from the BE HW constraints". We have 
existing solutions with a DSP-based SRC adjusting FE rates to what is 
required by the BE dailink.

Maybe it would help to show examples of what you can do today and what 
you cannot, so that we are on the same wavelength on what the 
limitations are and how to remove them?


  reply	other threads:[~2021-03-24 15:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 11:43 [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones Codrin Ciubotariu
2021-03-23 11:43 ` [RFC PATCH 1/3] pcm: use substream instead of runtime in snd_pcm_hw_rule_add() Codrin Ciubotariu
2021-03-23 11:43 ` [RFC PATCH 2/3] ASoC: soc-pcm: add hw_constraints for BE DAI links Codrin Ciubotariu
2021-03-23 11:43 ` [RFC PATCH 3/3] ASoC: soc-pcm: apply BE HW constraint rules Codrin Ciubotariu
2021-03-23 12:15 ` [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones Jaroslav Kysela
2021-03-23 14:18   ` Codrin.Ciubotariu
2021-04-14 14:58     ` Codrin.Ciubotariu
2021-04-15 16:17       ` Mark Brown
2021-04-15 16:56         ` Codrin.Ciubotariu
2021-04-15 17:25           ` Mark Brown
2021-04-16 16:03             ` Codrin.Ciubotariu
2021-04-16 16:31               ` Mark Brown
2021-04-16 16:47                 ` Pierre-Louis Bossart
2021-04-16 18:55                   ` Mark Brown
2021-04-16 19:39                     ` Pierre-Louis Bossart
2021-04-19 15:07                       ` Mark Brown
2021-04-16 17:39                 ` Codrin.Ciubotariu
2021-03-23 19:25 ` Pierre-Louis Bossart
2021-03-24  9:51   ` Codrin.Ciubotariu
2021-03-24 15:28     ` Pierre-Louis Bossart [this message]
2021-03-24 17:12       ` Codrin.Ciubotariu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95d0f1c1-5a89-837f-b1dc-42482a3b1250@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=Codrin.Ciubotariu@microchip.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=gustavoars@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).