* [PATCH] docs/devicetree: mailbox: fix trivial typo
@ 2020-05-10 19:38 l4stpr0gr4m
2020-05-11 7:00 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: l4stpr0gr4m @ 2020-05-10 19:38 UTC (permalink / raw)
To: trivial
Cc: michal.simek, linux-kernel, devicetree, linux-arm-kernel, Kangmin Park
From: Kangmin Park <l4stpr0gr4m@gmail.com>
Fix node id typo in example
Signed-off-by: Kangmin Park <l4stpr0gr4m@gmail.com>
---
Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
index 4438432..ad76edc 100644
--- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
+++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
@@ -87,7 +87,7 @@ Example:
ranges;
/* APU<->RPU0 IPI mailbox controller */
- ipi_mailbox_rpu0: mailbox@ff90400 {
+ ipi_mailbox_rpu0: mailbox@ff990400 {
reg = <0xff990400 0x20>,
<0xff990420 0x20>,
<0xff990080 0x20>,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] docs/devicetree: mailbox: fix trivial typo
2020-05-10 19:38 [PATCH] docs/devicetree: mailbox: fix trivial typo l4stpr0gr4m
@ 2020-05-11 7:00 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2020-05-11 7:00 UTC (permalink / raw)
To: l4stpr0gr4m, trivial
Cc: michal.simek, linux-kernel, devicetree, linux-arm-kernel
On 10. 05. 20 21:38, l4stpr0gr4m@gmail.com wrote:
> From: Kangmin Park <l4stpr0gr4m@gmail.com>
>
> Fix node id typo in example
I think it is more than typo. It is incorrect unit-address which doesn't
match the first address specified in the reg property of the node.
Here is line from dt binding spec.
"The unit-address must match the first address specified in the
reg property of the node."
>
> Signed-off-by: Kangmin Park <l4stpr0gr4m@gmail.com>
IIRC subject should start with dt-bindings:
> ---
> Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> index 4438432..ad76edc 100644
> --- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> +++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> @@ -87,7 +87,7 @@ Example:
> ranges;
>
> /* APU<->RPU0 IPI mailbox controller */
> - ipi_mailbox_rpu0: mailbox@ff90400 {
> + ipi_mailbox_rpu0: mailbox@ff990400 {
> reg = <0xff990400 0x20>,
> <0xff990420 0x20>,
> <0xff990080 0x20>,
>
Change is correct.
With nits above applied please add my
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-11 7:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-10 19:38 [PATCH] docs/devicetree: mailbox: fix trivial typo l4stpr0gr4m
2020-05-11 7:00 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).