* [PATCH 1/1] usb: chipidea: msm: Ensure proper controller reset using role switch API
[not found] <20200507004918.25975-1-peter.chen@kernel.org>
@ 2020-05-07 0:49 ` Peter Chen
2020-05-07 6:45 ` Greg KH
2020-05-07 6:46 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Peter Chen @ 2020-05-07 0:49 UTC (permalink / raw)
To: gregkh
Cc: linux-usb, Bryan O'Donoghue, Peter Chen, Philipp Zabel,
linux-kernel, Stephen Boyd, Peter Chen
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Currently we check to make sure there is no error state on the extcon
handle for VBUS when writing to the HS_PHY_GENCONFIG_2 register. When using
the USB role-switch API we still need to write to this register absent an
extcon handle.
This patch makes the appropriate update to ensure the write happens if
role-switching is true.
Fixes: 05559f10ed79 ("usb: chipidea: add role switch class support")
Cc: Peter Chen <Peter.Chen@nxp.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/usb/chipidea/ci_hdrc_msm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c
index af648ba6544d..46105457e1ca 100644
--- a/drivers/usb/chipidea/ci_hdrc_msm.c
+++ b/drivers/usb/chipidea/ci_hdrc_msm.c
@@ -114,7 +114,7 @@ static int ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event)
hw_write_id_reg(ci, HS_PHY_GENCONFIG_2,
HS_PHY_ULPI_TX_PKT_EN_CLR_FIX, 0);
- if (!IS_ERR(ci->platdata->vbus_extcon.edev)) {
+ if (!IS_ERR(ci->platdata->vbus_extcon.edev) || ci->role_switch) {
hw_write_id_reg(ci, HS_PHY_GENCONFIG_2,
HS_PHY_SESS_VLD_CTRL_EN,
HS_PHY_SESS_VLD_CTRL_EN);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] usb: chipidea: msm: Ensure proper controller reset using role switch API
2020-05-07 0:49 ` [PATCH 1/1] usb: chipidea: msm: Ensure proper controller reset using role switch API Peter Chen
@ 2020-05-07 6:45 ` Greg KH
2020-05-07 6:46 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-05-07 6:45 UTC (permalink / raw)
To: Peter Chen
Cc: linux-usb, Bryan O'Donoghue, Peter Chen, Philipp Zabel,
linux-kernel, Stephen Boyd
On Thu, May 07, 2020 at 08:49:18AM +0800, Peter Chen wrote:
> From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>
> Currently we check to make sure there is no error state on the extcon
> handle for VBUS when writing to the HS_PHY_GENCONFIG_2 register. When using
> the USB role-switch API we still need to write to this register absent an
> extcon handle.
>
> This patch makes the appropriate update to ensure the write happens if
> role-switching is true.
>
> Fixes: 05559f10ed79 ("usb: chipidea: add role switch class support")
>
> Cc: Peter Chen <Peter.Chen@nxp.com>
No blank line needed, and you can drop your own Cc: in the patch :)
I'll edit it by hand...
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] usb: chipidea: msm: Ensure proper controller reset using role switch API
2020-05-07 0:49 ` [PATCH 1/1] usb: chipidea: msm: Ensure proper controller reset using role switch API Peter Chen
2020-05-07 6:45 ` Greg KH
@ 2020-05-07 6:46 ` Greg KH
2020-05-07 6:48 ` Peter Chen
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2020-05-07 6:46 UTC (permalink / raw)
To: Peter Chen
Cc: linux-usb, Bryan O'Donoghue, Peter Chen, Philipp Zabel,
linux-kernel, Stephen Boyd
On Thu, May 07, 2020 at 08:49:18AM +0800, Peter Chen wrote:
> From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>
> Currently we check to make sure there is no error state on the extcon
> handle for VBUS when writing to the HS_PHY_GENCONFIG_2 register. When using
> the USB role-switch API we still need to write to this register absent an
> extcon handle.
>
> This patch makes the appropriate update to ensure the write happens if
> role-switching is true.
>
> Fixes: 05559f10ed79 ("usb: chipidea: add role switch class support")
This should also go do stable kernels, I'll mark that...
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/1] usb: chipidea: msm: Ensure proper controller reset using role switch API
2020-05-07 6:46 ` Greg KH
@ 2020-05-07 6:48 ` Peter Chen
0 siblings, 0 replies; 4+ messages in thread
From: Peter Chen @ 2020-05-07 6:48 UTC (permalink / raw)
To: Greg KH, Peter Chen
Cc: linux-usb, Bryan O'Donoghue, Philipp Zabel, linux-kernel,
Stephen Boyd
>
> On Thu, May 07, 2020 at 08:49:18AM +0800, Peter Chen wrote:
> > From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> >
> > Currently we check to make sure there is no error state on the extcon
> > handle for VBUS when writing to the HS_PHY_GENCONFIG_2 register. When
> > using the USB role-switch API we still need to write to this register
> > absent an extcon handle.
> >
> > This patch makes the appropriate update to ensure the write happens if
> > role-switching is true.
> >
> > Fixes: 05559f10ed79 ("usb: chipidea: add role switch class support")
>
> This should also go do stable kernels, I'll mark that...
Thanks, Greg.
Peter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-07 6:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200507004918.25975-1-peter.chen@kernel.org>
2020-05-07 0:49 ` [PATCH 1/1] usb: chipidea: msm: Ensure proper controller reset using role switch API Peter Chen
2020-05-07 6:45 ` Greg KH
2020-05-07 6:46 ` Greg KH
2020-05-07 6:48 ` Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).