From: "Li, Xin3" <xin3.li@intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Brian Gerst <brgerst@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: RE: [PATCH 5/6] x86/gsseg: move load_gs_index() to its own header file
Date: Fri, 7 Oct 2022 22:41:35 +0000 [thread overview]
Message-ID: <BN6PR1101MB2161FA3D7F1DB25C7F2C83ACA85F9@BN6PR1101MB2161.namprd11.prod.outlook.com> (raw)
In-Reply-To: <6CBB0EC9-5EF1-4396-9B5F-C0A5592BFD37@zytor.com>
> On October 7, 2022 8:40:41 AM PDT, Brian Gerst <brgerst@gmail.com> wrote:
> >On Thu, Oct 6, 2022 at 12:13 PM Xin Li <xin3.li@intel.com> wrote:
> >>
> >> From: "H. Peter Anvin (Intel)" <hpa@zytor.com>
> >>
> >> <asm/cpufeature.h> depends on <asm/special_insns.h>, so in order to
> >> be able to use alternatives in native_load_gs_index(), factor it out
> >> into a separate header file.
> >>
> >> Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
> >> Signed-off-by: Xin Li <xin3.li@intel.com>
> >
> >This could be moved into <asm/segment.h> instead of creating a new header
> file.
Good suggestion. However I still prefer to keep GS segment in its own header file,
1) it's a special segment for x86_64 kernel, and it's more readable to keep it separated.
2) segment.h is included in too many files, but gsseg.h only 4 files. We avoid header pollution.
Maybe we should even factor GS segment out of segment.h for x86_64.
Xin
> >
> >--
> >Brian Gerst
>
> At least at the time I wrote the code, it could not, without creating yet another
> circular header file dependency.
next prev parent reply other threads:[~2022-10-07 22:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 15:40 [PATCH 0/6] Enable LKGS instruction Xin Li
2022-10-06 15:40 ` [PATCH 1/6] x86/cpufeature: add cpu feature bit for LKGS Xin Li
2022-10-06 15:40 ` [PATCH 2/6] x86/opcode: add LKGS instruction to x86-opcode-map Xin Li
2022-10-06 15:40 ` [PATCH 3/6] x86/gsseg: make asm_load_gs_index() take an u16 Xin Li
2022-10-06 15:40 ` [PATCH 4/6] x86/gsseg: move local_irq_save/restore() into asm_load_gs_index() Xin Li
2022-10-07 14:50 ` Peter Zijlstra
2022-10-07 17:47 ` H. Peter Anvin
2022-10-06 15:40 ` [PATCH 5/6] x86/gsseg: move load_gs_index() to its own header file Xin Li
2022-10-07 15:40 ` Brian Gerst
2022-10-07 17:43 ` H. Peter Anvin
2022-10-07 22:41 ` Li, Xin3 [this message]
2022-10-06 15:40 ` [PATCH 6/6] x86/gsseg: use the LKGS instruction if available for load_gs_index() Xin Li
2022-10-07 14:47 ` Peter Zijlstra
2022-10-07 17:45 ` H. Peter Anvin
2022-10-07 18:07 ` Li, Xin3
2022-10-07 18:49 ` H. Peter Anvin
2022-10-07 18:01 ` Li, Xin3
2022-10-07 19:24 ` Peter Zijlstra
2022-10-07 20:03 ` H. Peter Anvin
2022-10-07 20:23 ` Peter Zijlstra
2022-10-07 20:33 ` H. Peter Anvin
2022-10-08 5:32 ` Li, Xin3
2022-10-08 7:16 ` H. Peter Anvin
2022-10-10 4:21 ` Li, Xin3
2022-10-14 4:36 ` Li, Xin3
2022-10-07 14:52 ` Peter Zijlstra
2022-10-07 15:09 ` Peter Zijlstra
2022-10-08 5:31 ` Li, Xin3
2022-10-07 16:18 ` Brian Gerst
2022-10-08 5:40 ` Li, Xin3
2022-10-08 12:40 ` Brian Gerst
2022-10-10 4:32 ` Li, Xin3
2022-10-10 4:51 ` H. Peter Anvin
2022-10-10 7:53 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR1101MB2161FA3D7F1DB25C7F2C83ACA85F9@BN6PR1101MB2161.namprd11.prod.outlook.com \
--to=xin3.li@intel.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).