[PATCH 0/3] mfd: ChromeOS EC Kconfig dependency cleanup

[PATCH 0/3] mfd: ChromeOS EC Kconfig dependency cleanup

[Javier Martinez Canillas]

Hello,

This is a trivial series that do some changes to the dependency for the
ChromeOS EC drivers Kconfig symbols. The patches are on top of Paul's
patch "mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM":
https://lkml.org/lkml/2015/6/20/219.

Paul fixed a warning about unmet dependencies but I think the correct fix
is to remove unneded dependencies. So that is what this series do and are
composed of the following patches:


Javier Martinez Canillas (3):
  platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM
  mfd: Remove MFD_CROS_EC depends on X86 || ARM
  mfd: Remove MFD_CROS_EC_SPI depends on OF

 drivers/mfd/Kconfig             | 3 +--
 drivers/platform/chrome/Kconfig | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

-- 
2.1.4

[PATCH 1/3] platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM

[Javier Martinez Canillas]

The Chrome platform support depends on X86 || ARM because there are
only Chromebooks using those architectures. But only some drivers
depend on a given architecture, and the ones that do already have
a dependency on their specific Kconfig symbol entries.

An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST
but is more future proof to remove the dependency and let the drivers
be built in all architectures if possible to have more build coverage.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---

 drivers/platform/chrome/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
index cb1329919527..3271cd1abe7c 100644
--- a/drivers/platform/chrome/Kconfig
+++ b/drivers/platform/chrome/Kconfig
@@ -4,7 +4,6 @@
 
 menuconfig CHROME_PLATFORMS
 	bool "Platform support for Chrome hardware"
-	depends on X86 || ARM
 	---help---
 	  Say Y here to get to see options for platform support for
 	  various Chromebooks and Chromeboxes. This option alone does
-- 
2.1.4

[PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

[Javier Martinez Canillas]

A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:

(MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)

This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
that dependency was removed since there isn't a reason why the option can
not be selected on other architectures. So now the above warning will not
happen and the MFD_CROS_EC dependency can be removed since is not needed.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---

 drivers/mfd/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index d3235e6f1953..653815950aa2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -94,7 +94,6 @@ config MFD_AXP20X
 
 config MFD_CROS_EC
 	tristate "ChromeOS Embedded Controller"
-	depends on X86 || ARM
 	select MFD_CORE
 	select CHROME_PLATFORMS
 	select CROS_EC_PROTO
-- 
2.1.4

[PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF

[Javier Martinez Canillas]

The ChromeOS EC SPI transport driver has a dependency on OF because it
uses some OF helpers from the <linux/of.h> header. But there isn't a
need for an explicit dependency since the header has stub functions if
CONFIG_OF is not defined.

Also, MFD_CROS_EC_SPI already depends on MFD_CROS_EC which in turn has
a dependency on OF so in practice can't be selected without CONFIG_OF.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

---

 drivers/mfd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 653815950aa2..3f68dd251ce8 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C
 
 config MFD_CROS_EC_SPI
 	tristate "ChromeOS Embedded Controller (SPI)"
-	depends on MFD_CROS_EC && CROS_EC_PROTO && SPI && OF
+	depends on MFD_CROS_EC && CROS_EC_PROTO && SPI
 
 	---help---
 	  If you say Y here, you get support for talking to the ChromeOS EC
-- 
2.1.4

Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF

[Lee Jones]

On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:

> The ChromeOS EC SPI transport driver has a dependency on OF because it
> uses some OF helpers from the <linux/of.h> header. But there isn't a
> need for an explicit dependency since the header has stub functions if
> CONFIG_OF is not defined.
> 
> Also, MFD_CROS_EC_SPI already depends on MFD_CROS_EC which in turn has
> a dependency on OF so in practice can't be selected without CONFIG_OF.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 
> ---
> 
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied for v4.3, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 653815950aa2..3f68dd251ce8 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C
>  
>  config MFD_CROS_EC_SPI
>  	tristate "ChromeOS Embedded Controller (SPI)"
> -	depends on MFD_CROS_EC && CROS_EC_PROTO && SPI && OF
> +	depends on MFD_CROS_EC && CROS_EC_PROTO && SPI
>  
>  	---help---
>  	  If you say Y here, you get support for talking to the ChromeOS EC

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

[Lee Jones]

On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:

> A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
> 
> (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
> 
> This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
> that dependency was removed since there isn't a reason why the option can
> not be selected on other architectures. So now the above warning will not
> happen and the MFD_CROS_EC dependency can be removed since is not needed.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
> 
>  drivers/mfd/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

Applied for v4.3, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index d3235e6f1953..653815950aa2 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -94,7 +94,6 @@ config MFD_AXP20X
>  
>  config MFD_CROS_EC
>  	tristate "ChromeOS Embedded Controller"
> -	depends on X86 || ARM
>  	select MFD_CORE
>  	select CHROME_PLATFORMS
>  	select CROS_EC_PROTO

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

[Javier Martinez Canillas]

Hello Lee,

On 06/25/2015 10:38 AM, Lee Jones wrote:
> On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
> 
>> A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
>> 
>> (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
>> 
>> This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
>> that dependency was removed since there isn't a reason why the option can
>> not be selected on other architectures. So now the above warning will not
>> happen and the MFD_CROS_EC dependency can be removed since is not needed.
>> 
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> ---
>> 
>>  drivers/mfd/Kconfig | 1 -
>>  1 file changed, 1 deletion(-)
> 
> Applied for v4.3, thanks.
> 

Thanks a lot.

Olof,

Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
Since both patches 1/3 and 2/3 are needed to fix the build warning for
!X86 and !ARM architectures.

Best regards,
Javier

Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

[Paul Gortmaker]

[Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM] On 25/06/2015 (Thu 10:44) Javier Martinez Canillas wrote:

> Hello Lee,
> 
> On 06/25/2015 10:38 AM, Lee Jones wrote:
> > On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
> > 
> >> A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
> >> 
> >> (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
> >> 
> >> This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
> >> that dependency was removed since there isn't a reason why the option can
> >> not be selected on other architectures. So now the above warning will not
> >> happen and the MFD_CROS_EC dependency can be removed since is not needed.
> >> 
> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> >> ---
> >> 
> >>  drivers/mfd/Kconfig | 1 -
> >>  1 file changed, 1 deletion(-)
> > 
> > Applied for v4.3, thanks.
> > 
> 
> Thanks a lot.
> 
> Olof,
> 
> Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
> Since both patches 1/3 and 2/3 are needed to fix the build warning for
> !X86 and !ARM architectures.

Checking this didn't fall through the cracks ; still seeing the issue
in xtensa (and other arch) builds of linux-next currently:

http://kisskb.ellerman.id.au/kisskb/buildresult/12452368/

Paul.
--

> 
> Best regards,
> Javier

Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

[Paul Gortmaker]

[Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM] On 25/06/2015 (Thu 10:44) Javier Martinez Canillas wrote:

> Hello Lee,
> 
> On 06/25/2015 10:38 AM, Lee Jones wrote:
> > On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
> > 
> >> A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
> >> 
> >> (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
> >> 
> >> This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
> >> that dependency was removed since there isn't a reason why the option can
> >> not be selected on other architectures. So now the above warning will not
> >> happen and the MFD_CROS_EC dependency can be removed since is not needed.
> >> 
> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> >> ---
> >> 
> >>  drivers/mfd/Kconfig | 1 -
> >>  1 file changed, 1 deletion(-)
> > 
> > Applied for v4.3, thanks.
> > 
> 
> Thanks a lot.
> 
> Olof,
> 
> Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
> Since both patches 1/3 and 2/3 are needed to fix the build warning for
> !X86 and !ARM architectures.

Hi all,

Wondering if this fell through the cracks.  It used to be just a
linux-next issue, but now it is a mainline issue.  This _really_ should
be fixed and fed to Linus ASAP.  Ideally it should have been fixed before 
going to mainline as it was reported in plenty of time ; that is the
whole point of linux-next.... to fix unanticipated fallout and revise.

------------------
paul@builder:~/git/linux-head$ git describe 
v4.2-rc3
paul@builder:~/git/linux-head$ echo $ARCH
sparc64
paul@builder:~/git/linux-head$ make allyesconfig
scripts/kconfig/conf  --allyesconfig Kconfig
warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
#
# configuration written to .config
#
paul@builder:~/git/linux-head$ 
------------------

Thanks,
Paul.
--

> 
> Best regards,
> Javier

Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

[Javier Martinez Canillas]

Hello Paul,

On Wed, Jul 22, 2015 at 3:13 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> [Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM] On 25/06/2015 (Thu 10:44) Javier Martinez Canillas wrote:
>
>> Hello Lee,
>>
>> On 06/25/2015 10:38 AM, Lee Jones wrote:
>> > On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
>> >
>> >> A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
>> >>
>> >> (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
>> >>
>> >> This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
>> >> that dependency was removed since there isn't a reason why the option can
>> >> not be selected on other architectures. So now the above warning will not
>> >> happen and the MFD_CROS_EC dependency can be removed since is not needed.
>> >>
>> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> >> ---
>> >>
>> >>  drivers/mfd/Kconfig | 1 -
>> >>  1 file changed, 1 deletion(-)
>> >
>> > Applied for v4.3, thanks.
>> >
>>
>> Thanks a lot.
>>
>> Olof,
>>
>> Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
>> Since both patches 1/3 and 2/3 are needed to fix the build warning for
>> !X86 and !ARM architectures.
>
> Hi all,
>
> Wondering if this fell through the cracks.  It used to be just a
> linux-next issue, but now it is a mainline issue.  This _really_ should
> be fixed and fed to Linus ASAP.  Ideally it should have been fixed before
> going to mainline as it was reported in plenty of time ; that is the
> whole point of linux-next.... to fix unanticipated fallout and revise.
>

Sorry that I didn't follow up on this but I recently changed jobs and
was quite busy and travelling.

The problem as is explained above in the quoted text is that $subject
is not enough to fix the issue, patch 1/3 should also be picked but
that is waiting for Olof's ack.
I agree that both patches 1/3 and 2/3 have to be sent as an -rc fix
since the commit that introduced the issue made it to 4.2.

Patch 3/3 can wait for 4.3 which BTW I see that has not been applied either.

> ------------------
> paul@builder:~/git/linux-head$ git describe
> v4.2-rc3
> paul@builder:~/git/linux-head$ echo $ARCH
> sparc64
> paul@builder:~/git/linux-head$ make allyesconfig
> scripts/kconfig/conf  --allyesconfig Kconfig
> warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
> #
> # configuration written to .config
> #
> paul@builder:~/git/linux-head$
> ------------------
>
> Thanks,
> Paul.
> --
>

Best regards,
Javier

Re: [PATCH 1/3] platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM

[Olof Johansson]

On Thu, Jun 25, 2015 at 02:20:42AM +0200, Javier Martinez Canillas wrote:
> The Chrome platform support depends on X86 || ARM because there are
> only Chromebooks using those architectures. But only some drivers
> depend on a given architecture, and the ones that do already have
> a dependency on their specific Kconfig symbol entries.
> 
> An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST
> but is more future proof to remove the dependency and let the drivers
> be built in all architectures if possible to have more build coverage.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Acked-by: Olof Johansson <olof@lixom.net>


-Olof

Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

[Olof Johansson]

On Thu, Jun 25, 2015 at 10:44:28AM +0200, Javier Martinez Canillas wrote:
> Hello Lee,
> 
> On 06/25/2015 10:38 AM, Lee Jones wrote:
> > On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
> > 
> >> A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
> >> 
> >> (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
> >> 
> >> This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
> >> that dependency was removed since there isn't a reason why the option can
> >> not be selected on other architectures. So now the above warning will not
> >> happen and the MFD_CROS_EC dependency can be removed since is not needed.
> >> 
> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> >> ---
> >> 
> >>  drivers/mfd/Kconfig | 1 -
> >>  1 file changed, 1 deletion(-)
> > 
> > Applied for v4.3, thanks.
> > 
> 
> Thanks a lot.
> 
> Olof,
> 
> Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
> Since both patches 1/3 and 2/3 are needed to fix the build warning for
> !X86 and !ARM architectures.

Yep, done.

-Olof

Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

[Olof Johansson]

On Tue, Jul 21, 2015 at 6:13 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> [Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM] On 25/06/2015 (Thu 10:44) Javier Martinez Canillas wrote:
>
>> Hello Lee,
>>
>> On 06/25/2015 10:38 AM, Lee Jones wrote:
>> > On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
>> >
>> >> A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
>> >>
>> >> (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
>> >>
>> >> This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
>> >> that dependency was removed since there isn't a reason why the option can
>> >> not be selected on other architectures. So now the above warning will not
>> >> happen and the MFD_CROS_EC dependency can be removed since is not needed.
>> >>
>> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> >> ---
>> >>
>> >>  drivers/mfd/Kconfig | 1 -
>> >>  1 file changed, 1 deletion(-)
>> >
>> > Applied for v4.3, thanks.
>> >
>>
>> Thanks a lot.
>>
>> Olof,
>>
>> Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
>> Since both patches 1/3 and 2/3 are needed to fix the build warning for
>> !X86 and !ARM architectures.
>
> Hi all,
>
> Wondering if this fell through the cracks.  It used to be just a
> linux-next issue, but now it is a mainline issue.  This _really_ should
> be fixed and fed to Linus ASAP.  Ideally it should have been fixed before
> going to mainline as it was reported in plenty of time ; that is the
> whole point of linux-next.... to fix unanticipated fallout and revise.

Yep, agreed. I've been a bit removed from upstream work for the last
couple of months (getting back to it now), so I've been bad at
following up on this.

Acks sent now, Lee, please pick up for 4.2 if you don't mind.


-Olof

Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

[Lee Jones]

On Thu, 25 Jun 2015, Lee Jones wrote:

> On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
> 
> > A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
> > 
> > (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
> > 
> > This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
> > that dependency was removed since there isn't a reason why the option can
> > not be selected on other architectures. So now the above warning will not
> > happen and the MFD_CROS_EC dependency can be removed since is not needed.
> > 
> > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> > ---
> > 
> >  drivers/mfd/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Applied for v4.3, thanks.

Now applied for v4.2, thanks.

> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index d3235e6f1953..653815950aa2 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -94,7 +94,6 @@ config MFD_AXP20X
> >  
> >  config MFD_CROS_EC
> >  	tristate "ChromeOS Embedded Controller"
> > -	depends on X86 || ARM
> >  	select MFD_CORE
> >  	select CHROME_PLATFORMS
> >  	select CROS_EC_PROTO
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/3] platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM

[Lee Jones]

On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:

> The Chrome platform support depends on X86 || ARM because there are
> only Chromebooks using those architectures. But only some drivers
> depend on a given architecture, and the ones that do already have
> a dependency on their specific Kconfig symbol entries.
> 
> An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST
> but is more future proof to remove the dependency and let the drivers
> be built in all architectures if possible to have more build coverage.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
> 
>  drivers/platform/chrome/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

Applied for v4.2, thanks.

> diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> index cb1329919527..3271cd1abe7c 100644
> --- a/drivers/platform/chrome/Kconfig
> +++ b/drivers/platform/chrome/Kconfig
> @@ -4,7 +4,6 @@
>  
>  menuconfig CHROME_PLATFORMS
>  	bool "Platform support for Chrome hardware"
> -	depends on X86 || ARM
>  	---help---
>  	  Say Y here to get to see options for platform support for
>  	  various Chromebooks and Chromeboxes. This option alone does

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF

[Lee Jones]

On Thu, 25 Jun 2015, Lee Jones wrote:

> On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
> 
> > The ChromeOS EC SPI transport driver has a dependency on OF because it
> > uses some OF helpers from the <linux/of.h> header. But there isn't a
> > need for an explicit dependency since the header has stub functions if
> > CONFIG_OF is not defined.
> > 
> > Also, MFD_CROS_EC_SPI already depends on MFD_CROS_EC which in turn has
> > a dependency on OF so in practice can't be selected without CONFIG_OF.
> > 
> > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> > 
> > ---
> > 
> >  drivers/mfd/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied for v4.3, thanks.

Now applied for v4.2, thanks.

> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 653815950aa2..3f68dd251ce8 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C
> >  
> >  config MFD_CROS_EC_SPI
> >  	tristate "ChromeOS Embedded Controller (SPI)"
> > -	depends on MFD_CROS_EC && CROS_EC_PROTO && SPI && OF
> > +	depends on MFD_CROS_EC && CROS_EC_PROTO && SPI
> >  
> >  	---help---
> >  	  If you say Y here, you get support for talking to the ChromeOS EC
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 0/3] mfd: ChromeOS EC Kconfig dependency cleanup

[Javier Martinez Canillas]

Hello Lee,

On Thu, Jun 25, 2015 at 2:20 AM, Javier Martinez Canillas
<javier.martinez@collabora.co.uk> wrote:
>
> This is a trivial series that do some changes to the dependency for the
> ChromeOS EC drivers Kconfig symbols. The patches are on top of Paul's
> patch "mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM":
> https://lkml.org/lkml/2015/6/20/219.
>
> Paul fixed a warning about unmet dependencies but I think the correct fix
> is to remove unneded dependencies. So that is what this series do and are
> composed of the following patches:
>
>
> Javier Martinez Canillas (3):
>   platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM
>   mfd: Remove MFD_CROS_EC depends on X86 || ARM
>   mfd: Remove MFD_CROS_EC_SPI depends on OF
>
>  drivers/mfd/Kconfig             | 3 +--
>  drivers/platform/chrome/Kconfig | 1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)
>

The warning that this series fixes has appeared again in linux-next.
You said some time ago that applied the patches for 4.3 [0] and indeed
I remember the warning going away at some point.

Do you know what happened with this patches? I see 3/3 in linux-next
but no 1/3 and 2/3.

[0]: https://lkml.org/lkml/2015/6/25/115

Thanks a lot and best regards,
Javier

Re: [PATCH 0/3] mfd: ChromeOS EC Kconfig dependency cleanup

[Lee Jones]

On Fri, 07 Aug 2015, Javier Martinez Canillas wrote:
> On Thu, Jun 25, 2015 at 2:20 AM, Javier Martinez Canillas
> <javier.martinez@collabora.co.uk> wrote:
> >
> > This is a trivial series that do some changes to the dependency for the
> > ChromeOS EC drivers Kconfig symbols. The patches are on top of Paul's
> > patch "mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM":
> > https://lkml.org/lkml/2015/6/20/219.
> >
> > Paul fixed a warning about unmet dependencies but I think the correct fix
> > is to remove unneded dependencies. So that is what this series do and are
> > composed of the following patches:
> >
> >
> > Javier Martinez Canillas (3):
> >   platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM
> >   mfd: Remove MFD_CROS_EC depends on X86 || ARM
> >   mfd: Remove MFD_CROS_EC_SPI depends on OF
> >
> >  drivers/mfd/Kconfig             | 3 +--
> >  drivers/platform/chrome/Kconfig | 1 -
> >  2 files changed, 1 insertion(+), 3 deletions(-)
> >
> 
> The warning that this series fixes has appeared again in linux-next.
> You said some time ago that applied the patches for 4.3 [0] and indeed
> I remember the warning going away at some point.
> 
> Do you know what happened with this patches? I see 3/3 in linux-next
> but no 1/3 and 2/3.

No idea why you're not seeing them.  They are in my -fixes branch,
which is pulled into -next.  I have _just_ sent them to Linus for
inclusion into v4.2.

Let me know if you still see the issue.

> [0]: https://lkml.org/lkml/2015/6/25/115
> 
> Thanks a lot and best regards,
> Javier

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 0/3] mfd: ChromeOS EC Kconfig dependency cleanup

[Lee Jones]

On Mon, 10 Aug 2015, Lee Jones wrote:

> On Fri, 07 Aug 2015, Javier Martinez Canillas wrote:
> > On Thu, Jun 25, 2015 at 2:20 AM, Javier Martinez Canillas
> > <javier.martinez@collabora.co.uk> wrote:
> > >
> > > This is a trivial series that do some changes to the dependency for the
> > > ChromeOS EC drivers Kconfig symbols. The patches are on top of Paul's
> > > patch "mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM":
> > > https://lkml.org/lkml/2015/6/20/219.
> > >
> > > Paul fixed a warning about unmet dependencies but I think the correct fix
> > > is to remove unneded dependencies. So that is what this series do and are
> > > composed of the following patches:
> > >
> > >
> > > Javier Martinez Canillas (3):
> > >   platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM
> > >   mfd: Remove MFD_CROS_EC depends on X86 || ARM
> > >   mfd: Remove MFD_CROS_EC_SPI depends on OF
> > >
> > >  drivers/mfd/Kconfig             | 3 +--
> > >  drivers/platform/chrome/Kconfig | 1 -
> > >  2 files changed, 1 insertion(+), 3 deletions(-)
> > >
> > 
> > The warning that this series fixes has appeared again in linux-next.
> > You said some time ago that applied the patches for 4.3 [0] and indeed
> > I remember the warning going away at some point.
> > 
> > Do you know what happened with this patches? I see 3/3 in linux-next
> > but no 1/3 and 2/3.
> 
> No idea why you're not seeing them.  They are in my -fixes branch,
> which is pulled into -next.  I have _just_ sent them to Linus for
> inclusion into v4.2.

Okay, scrap that.  It likes like MFD -fixes isn't pulled into -next.
I'll see what I can do about that.

> Let me know if you still see the issue.
> 
> > [0]: https://lkml.org/lkml/2015/6/25/115
> > 
> > Thanks a lot and best regards,
> > Javier
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 0/3] mfd: ChromeOS EC Kconfig dependency cleanup

[Javier Martinez Canillas]

Hello Lee,

On Mon, Aug 10, 2015 at 6:13 PM, Lee Jones <lee.jones@linaro.org> wrote:
> On Mon, 10 Aug 2015, Lee Jones wrote:
>> On Fri, 07 Aug 2015, Javier Martinez Canillas wrote:

[snip]

>> >
>> > Do you know what happened with this patches? I see 3/3 in linux-next
>> > but no 1/3 and 2/3.
>>
>> No idea why you're not seeing them.  They are in my -fixes branch,
>> which is pulled into -next.  I have _just_ sent them to Linus for
>> inclusion into v4.2.
>
> Okay, scrap that.  It likes like MFD -fixes isn't pulled into -next.
> I'll see what I can do about that.
>

Ok, that explains it. Thanks a lot for the heads up.

Best regards,
Javier

Re: [PATCH 1/3] platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM

[Geert Uytterhoeven]

On Thu, Jun 25, 2015 at 2:20 AM, Javier Martinez Canillas
<javier.martinez@collabora.co.uk> wrote:
> The Chrome platform support depends on X86 || ARM because there are
> only Chromebooks using those architectures. But only some drivers
> depend on a given architecture, and the ones that do already have
> a dependency on their specific Kconfig symbol entries.
>
> An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST
> but is more future proof to remove the dependency and let the drivers
> be built in all architectures if possible to have more build coverage.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

NAKed-by: Geert Uytterhoeven <geert@linux-m68k.org>

The proper way to have more build coverage is to extend the dependencies
with "|| COMPILE_TEST".

Yes I know MFD_CROS_EC selects CHROME_PLATFORMS, causing a
Kconfig warning on !X86 and !ARM.

Mixing "select" and "depends" (all other ChromeOS stuff depends on the
symbol) is bad practice, as it may lead to circular Kconfig dependencies.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/3] platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM

[Javier Martinez Canillas]

Hello Geert,

Thanks a lot for your feedback.

On Mon, Aug 17, 2015 at 9:56 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Thu, Jun 25, 2015 at 2:20 AM, Javier Martinez Canillas
> <javier.martinez@collabora.co.uk> wrote:
>> The Chrome platform support depends on X86 || ARM because there are
>> only Chromebooks using those architectures. But only some drivers
>> depend on a given architecture, and the ones that do already have
>> a dependency on their specific Kconfig symbol entries.
>>
>> An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST
>> but is more future proof to remove the dependency and let the drivers
>> be built in all architectures if possible to have more build coverage.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> NAKed-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> The proper way to have more build coverage is to extend the dependencies
> with "|| COMPILE_TEST".
>

Ok, I mentioned that as the other option but was not sure which one
was more suitable since CHROME_PLATFORMS is a category and the
individual drivers already depend on a given arch. But I will make it
depends on X86 || ARM again plus || COMPILE_TEST and in the future if
there is a Chromebook on !X86 and !ARM, that new arch can be added to
the or logic.

> Yes I know MFD_CROS_EC selects CHROME_PLATFORMS, causing a
> Kconfig warning on !X86 and !ARM.
>
> Mixing "select" and "depends" (all other ChromeOS stuff depends on the
> symbol) is bad practice, as it may lead to circular Kconfig dependencies.
>

Yes, I think this is the real issue. I added the select instead of a
depends to avoid breaking git bisection when moving the cros_ec com
helpers out of MFD since some platforms use MFD_CROS_EC but don't
enable CHROME_PLATFORMS on their defconfigs. But I'll change the
select to depends instead and include the defconfig changes as a
dependency in the series to avoid breaking git bisection.

> Gr{oetje,eeting}s,
>
>                         Geert
>
> --

Best regards,
Javier