linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating
@ 2015-06-26  2:25 Walter Lozano
  2015-06-26  2:25 ` [PATCH 2/3] ARM: socfpga: dts: Fix entries order Walter Lozano
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Walter Lozano @ 2015-06-26  2:25 UTC (permalink / raw)
  To: dinguyen, geert, s.trumtrar, robh+dt, pawel.moll, mark.rutland,
	ijc+devicetree, galak, linux, devicetree, linux-arm-kernel,
	linux-kernel
  Cc: Walter Lozano

This patch fixes the formating of DTS bindings for the adxl34x digital
accelerometer.

Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar>
---
 arch/arm/boot/dts/socfpga_cyclone5_sockit.dts |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
index 71468a7..5b60692 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
@@ -73,14 +73,14 @@
 	status = "okay";
 };
 
-&i2c1{
+&i2c1 {
 	status = "okay";
 
-	accel1: accel1@53{
+	accel1: accelerometer@53 {
 		compatible = "adxl34x";
 		reg = <0x53>;
 
-		interrupt-parent = < &portc >;
+		interrupt-parent = <&portc>;
 		interrupts = <3 2>;
 	};
 };
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] ARM: socfpga: dts: Fix entries order
  2015-06-26  2:25 [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating Walter Lozano
@ 2015-06-26  2:25 ` Walter Lozano
  2015-06-26  2:25 ` [PATCH 3/3] ARM: socfpga: dts: Fix adxl345 compatible string Walter Lozano
  2015-06-26  7:16 ` [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating Steffen Trumtrar
  2 siblings, 0 replies; 7+ messages in thread
From: Walter Lozano @ 2015-06-26  2:25 UTC (permalink / raw)
  To: dinguyen, geert, s.trumtrar, robh+dt, pawel.moll, mark.rutland,
	ijc+devicetree, galak, linux, devicetree, linux-arm-kernel,
	linux-kernel
  Cc: Walter Lozano

This patch reorders the nodes alphabetically

Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar>
---
 arch/arm/boot/dts/socfpga_cyclone5_sockit.dts |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
index 5b60692..d343e03 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
@@ -60,15 +60,6 @@
 	rxc-skew-ps = <2000>;
 };
 
-&mmc0 {
-	vmmc-supply = <&regulator_3_3v>;
-	vqmmc-supply = <&regulator_3_3v>;
-};
-
-&usb1 {
-	status = "okay";
-};
-
 &gpio2 {
 	status = "okay";
 };
@@ -84,3 +75,12 @@
 		interrupts = <3 2>;
 	};
 };
+
+&mmc0 {
+	vmmc-supply = <&regulator_3_3v>;
+	vqmmc-supply = <&regulator_3_3v>;
+};
+
+&usb1 {
+	status = "okay";
+};
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/3] ARM: socfpga: dts: Fix adxl345 compatible string
  2015-06-26  2:25 [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating Walter Lozano
  2015-06-26  2:25 ` [PATCH 2/3] ARM: socfpga: dts: Fix entries order Walter Lozano
@ 2015-06-26  2:25 ` Walter Lozano
  2015-06-26  7:16 ` [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating Steffen Trumtrar
  2 siblings, 0 replies; 7+ messages in thread
From: Walter Lozano @ 2015-06-26  2:25 UTC (permalink / raw)
  To: dinguyen, geert, s.trumtrar, robh+dt, pawel.moll, mark.rutland,
	ijc+devicetree, galak, linux, devicetree, linux-arm-kernel,
	linux-kernel
  Cc: Walter Lozano

This patch fixes the compatible string for adxl345 digital accelerometer
after the deprecation of compatible string adxl345x.

Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar>
---
 arch/arm/boot/dts/socfpga_cyclone5_sockit.dts |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
index d343e03..5e17fd1 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
@@ -68,7 +68,7 @@
 	status = "okay";
 
 	accel1: accelerometer@53 {
-		compatible = "adxl34x";
+		compatible = "adi,adxl345";
 		reg = <0x53>;
 
 		interrupt-parent = <&portc>;
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating
  2015-06-26  2:25 [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating Walter Lozano
  2015-06-26  2:25 ` [PATCH 2/3] ARM: socfpga: dts: Fix entries order Walter Lozano
  2015-06-26  2:25 ` [PATCH 3/3] ARM: socfpga: dts: Fix adxl345 compatible string Walter Lozano
@ 2015-06-26  7:16 ` Steffen Trumtrar
  2015-06-26 10:36   ` Walter Lozano
  2 siblings, 1 reply; 7+ messages in thread
From: Steffen Trumtrar @ 2015-06-26  7:16 UTC (permalink / raw)
  To: Walter Lozano
  Cc: dinguyen, geert, robh+dt, pawel.moll, mark.rutland,
	ijc+devicetree, galak, linux, devicetree, linux-arm-kernel,
	linux-kernel

Hi Walter!

On Thu, Jun 25, 2015 at 11:25:57PM -0300, Walter Lozano wrote:
> This patch fixes the formating of DTS bindings for the adxl34x digital
> accelerometer.
> 
> Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar>
> ---
>  arch/arm/boot/dts/socfpga_cyclone5_sockit.dts |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
> index 71468a7..5b60692 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
> @@ -73,14 +73,14 @@
>  	status = "okay";
>  };
>  
> -&i2c1{
> +&i2c1 {
>  	status = "okay";
>  
> -	accel1: accel1@53{
> +	accel1: accelerometer@53 {
>  		compatible = "adxl34x";
>  		reg = <0x53>;
>  
> -		interrupt-parent = < &portc >;
> +		interrupt-parent = <&portc>;
>  		interrupts = <3 2>;
>  	};
>  };

I would personally squash 3/3 into this one, but otherwise:

Whole series

	Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>

Thanks,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating
  2015-06-26  7:16 ` [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating Steffen Trumtrar
@ 2015-06-26 10:36   ` Walter Lozano
  2015-07-07 14:00     ` Dinh Nguyen
  0 siblings, 1 reply; 7+ messages in thread
From: Walter Lozano @ 2015-06-26 10:36 UTC (permalink / raw)
  To: Steffen Trumtrar
  Cc: dinguyen, Geert Uytterhoeven, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree,
	linux-arm-kernel, linux-kernel

Hi Steffen

On Fri, Jun 26, 2015 at 4:16 AM, Steffen Trumtrar
<s.trumtrar@pengutronix.de> wrote:
> Hi Walter!
>
> On Thu, Jun 25, 2015 at 11:25:57PM -0300, Walter Lozano wrote:
>> This patch fixes the formating of DTS bindings for the adxl34x digital
>> accelerometer.
>>
>> Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar>
>> ---
>>  arch/arm/boot/dts/socfpga_cyclone5_sockit.dts |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>> index 71468a7..5b60692 100644
>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>> @@ -73,14 +73,14 @@
>>       status = "okay";
>>  };
>>
>> -&i2c1{
>> +&i2c1 {
>>       status = "okay";
>>
>> -     accel1: accel1@53{
>> +     accel1: accelerometer@53 {
>>               compatible = "adxl34x";
>>               reg = <0x53>;
>>
>> -             interrupt-parent = < &portc >;
>> +             interrupt-parent = <&portc>;
>>               interrupts = <3 2>;
>>       };
>>  };
>
> I would personally squash 3/3 into this one, but otherwise:
>
> Whole series
>
>         Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>

Thanks for your comments. I have no problem at all. Dinh?

Regards

-- 
Walter Lozano, VanguardiaSur
www.vanguardiasur.com.ar

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating
  2015-06-26 10:36   ` Walter Lozano
@ 2015-07-07 14:00     ` Dinh Nguyen
  2015-07-07 14:05       ` Walter Lozano
  0 siblings, 1 reply; 7+ messages in thread
From: Dinh Nguyen @ 2015-07-07 14:00 UTC (permalink / raw)
  To: Walter Lozano, Steffen Trumtrar
  Cc: Geert Uytterhoeven, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Russell King, devicetree,
	linux-arm-kernel, linux-kernel



On 6/26/15 5:36 AM, Walter Lozano wrote:
> Hi Steffen
> 
> On Fri, Jun 26, 2015 at 4:16 AM, Steffen Trumtrar
> <s.trumtrar@pengutronix.de> wrote:
>> Hi Walter!
>>
>> On Thu, Jun 25, 2015 at 11:25:57PM -0300, Walter Lozano wrote:
>>> This patch fixes the formating of DTS bindings for the adxl34x digital
>>> accelerometer.
>>>
>>> Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar>
>>> ---
>>>  arch/arm/boot/dts/socfpga_cyclone5_sockit.dts |    6 +++---
>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>> index 71468a7..5b60692 100644
>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>> @@ -73,14 +73,14 @@
>>>       status = "okay";
>>>  };
>>>
>>> -&i2c1{
>>> +&i2c1 {
>>>       status = "okay";
>>>
>>> -     accel1: accel1@53{
>>> +     accel1: accelerometer@53 {
>>>               compatible = "adxl34x";
>>>               reg = <0x53>;
>>>
>>> -             interrupt-parent = < &portc >;
>>> +             interrupt-parent = <&portc>;
>>>               interrupts = <3 2>;
>>>       };
>>>  };
>>
>> I would personally squash 3/3 into this one, but otherwise:
>>
>> Whole series
>>
>>         Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>>
> 
> Thanks for your comments. I have no problem at all. Dinh?

I've applied and squashed 1/3 and 3/3 together.

Thanks,
Dinh

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating
  2015-07-07 14:00     ` Dinh Nguyen
@ 2015-07-07 14:05       ` Walter Lozano
  0 siblings, 0 replies; 7+ messages in thread
From: Walter Lozano @ 2015-07-07 14:05 UTC (permalink / raw)
  To: Dinh Nguyen
  Cc: Steffen Trumtrar, Geert Uytterhoeven, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree,
	linux-arm-kernel, linux-kernel

On Tue, Jul 7, 2015 at 11:00 AM, Dinh Nguyen
<dinguyen@opensource.altera.com> wrote:
>
>
> On 6/26/15 5:36 AM, Walter Lozano wrote:
>> Hi Steffen
>>
>> On Fri, Jun 26, 2015 at 4:16 AM, Steffen Trumtrar
>> <s.trumtrar@pengutronix.de> wrote:
>>> Hi Walter!
>>>
>>> On Thu, Jun 25, 2015 at 11:25:57PM -0300, Walter Lozano wrote:
>>>> This patch fixes the formating of DTS bindings for the adxl34x digital
>>>> accelerometer.
>>>>
>>>> Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar>
>>>> ---
>>>>  arch/arm/boot/dts/socfpga_cyclone5_sockit.dts |    6 +++---
>>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>>> index 71468a7..5b60692 100644
>>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>>> @@ -73,14 +73,14 @@
>>>>       status = "okay";
>>>>  };
>>>>
>>>> -&i2c1{
>>>> +&i2c1 {
>>>>       status = "okay";
>>>>
>>>> -     accel1: accel1@53{
>>>> +     accel1: accelerometer@53 {
>>>>               compatible = "adxl34x";
>>>>               reg = <0x53>;
>>>>
>>>> -             interrupt-parent = < &portc >;
>>>> +             interrupt-parent = <&portc>;
>>>>               interrupts = <3 2>;
>>>>       };
>>>>  };
>>>
>>> I would personally squash 3/3 into this one, but otherwise:
>>>
>>> Whole series
>>>
>>>         Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>>>
>>
>> Thanks for your comments. I have no problem at all. Dinh?
>
> I've applied and squashed 1/3 and 3/3 together.
>

Great! Thanks!

-- 
Walter Lozano, VanguardiaSur
www.vanguardiasur.com.ar

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-07-07 14:06 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-26  2:25 [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating Walter Lozano
2015-06-26  2:25 ` [PATCH 2/3] ARM: socfpga: dts: Fix entries order Walter Lozano
2015-06-26  2:25 ` [PATCH 3/3] ARM: socfpga: dts: Fix adxl345 compatible string Walter Lozano
2015-06-26  7:16 ` [PATCH 1/3] ARM: socfpga: dts: Fix adxl34x formating Steffen Trumtrar
2015-06-26 10:36   ` Walter Lozano
2015-07-07 14:00     ` Dinh Nguyen
2015-07-07 14:05       ` Walter Lozano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).