* [PATCH] mmc: Export host capabilities to debugfs.
@ 2018-03-01 13:17 Harish Jenny K N
2018-03-01 14:24 ` Linus Walleij
2018-03-03 16:32 ` Vladimir Zapolskiy
0 siblings, 2 replies; 7+ messages in thread
From: Harish Jenny K N @ 2018-03-01 13:17 UTC (permalink / raw)
To: ulf.hansson, linus.walleij, adrian.hunter, shawn.lin,
avri.altman, andriy.shevchenko
Cc: linux-mmc, linux-kernel, harish_kandiga
This patch exports the host capabilities to debugfs
Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
---
drivers/mmc/core/debugfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
index c51e0c0..fa2df7f 100644
--- a/drivers/mmc/core/debugfs.c
+++ b/drivers/mmc/core/debugfs.c
@@ -289,6 +289,9 @@ void mmc_add_card_debugfs(struct mmc_card *card)
card->debugfs_root = root;
+ if (!debugfs_create_x32("host_caps", S_IRUSR, root, (u32 *)&host->caps))
+ goto err;
+
if (!debugfs_create_x32("state", S_IRUSR, root, &card->state))
goto err;
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: Export host capabilities to debugfs.
2018-03-01 13:17 [PATCH] mmc: Export host capabilities to debugfs Harish Jenny K N
@ 2018-03-01 14:24 ` Linus Walleij
2018-03-02 13:17 ` Harish Jenny K N
2018-03-03 16:32 ` Vladimir Zapolskiy
1 sibling, 1 reply; 7+ messages in thread
From: Linus Walleij @ 2018-03-01 14:24 UTC (permalink / raw)
To: Harish Jenny K N
Cc: Ulf Hansson, Adrian Hunter, Shawn Lin, Avri Altman,
Andy Shevchenko, linux-mmc, linux-kernel
On Thu, Mar 1, 2018 at 2:17 PM, Harish Jenny K N
<harish_kandiga@mentor.com> wrote:
Thanks for your patch!
> This patch exports the host capabilities to debugfs
>
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
Is there a corresponding patch to the mmc utils to make use
of the exported information? An opaque u32 seems pretty hard
to interpret.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: Export host capabilities to debugfs.
2018-03-01 14:24 ` Linus Walleij
@ 2018-03-02 13:17 ` Harish Jenny K N
2018-03-02 13:24 ` Linus Walleij
0 siblings, 1 reply; 7+ messages in thread
From: Harish Jenny K N @ 2018-03-02 13:17 UTC (permalink / raw)
To: Linus Walleij
Cc: Ulf Hansson, Adrian Hunter, Shawn Lin, Avri Altman,
Andy Shevchenko, linux-mmc, linux-kernel
On Thursday 01 March 2018 07:54 PM, Linus Walleij wrote:
> On Thu, Mar 1, 2018 at 2:17 PM, Harish Jenny K N
> <harish_kandiga@mentor.com> wrote:
>
> Thanks for your patch!
>
>> This patch exports the host capabilities to debugfs
>>
>> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
>> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
> Is there a corresponding patch to the mmc utils to make use
> of the exported information? An opaque u32 seems pretty hard
> to interpret.
>
> Yours,
> Linus Walleij
A sample patch "[RFC PATCH] mmc-utils: host_caps: Add parser to read host capabilities" is submitted.
Thanks,
Harish Jenny K N
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: Export host capabilities to debugfs.
2018-03-02 13:17 ` Harish Jenny K N
@ 2018-03-02 13:24 ` Linus Walleij
0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2018-03-02 13:24 UTC (permalink / raw)
To: Harish Jenny K N
Cc: Ulf Hansson, Adrian Hunter, Shawn Lin, Avri Altman,
Andy Shevchenko, linux-mmc, linux-kernel
On Fri, Mar 2, 2018 at 2:17 PM, Harish Jenny K N
<harish_kandiga@mentor.com> wrote:
> On Thursday 01 March 2018 07:54 PM, Linus Walleij wrote:
>> On Thu, Mar 1, 2018 at 2:17 PM, Harish Jenny K N
>> <harish_kandiga@mentor.com> wrote:
>>
>> Thanks for your patch!
>>
>>> This patch exports the host capabilities to debugfs
>>>
>>> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
>>> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
>> Is there a corresponding patch to the mmc utils to make use
>> of the exported information? An opaque u32 seems pretty hard
>> to interpret.
>>
>> Yours,
>> Linus Walleij
>
> A sample patch "[RFC PATCH] mmc-utils: host_caps: Add parser to read host capabilities" is submitted.
Nice! :)
Good work.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: Export host capabilities to debugfs.
2018-03-01 13:17 [PATCH] mmc: Export host capabilities to debugfs Harish Jenny K N
2018-03-01 14:24 ` Linus Walleij
@ 2018-03-03 16:32 ` Vladimir Zapolskiy
2018-03-05 4:07 ` Harish Jenny K N
1 sibling, 1 reply; 7+ messages in thread
From: Vladimir Zapolskiy @ 2018-03-03 16:32 UTC (permalink / raw)
To: Harish Jenny K N, ulf.hansson, linus.walleij, adrian.hunter,
shawn.lin, avri.altman, andriy.shevchenko
Cc: linux-mmc, linux-kernel
Hi Harish,
On 03/01/2018 03:17 PM, Harish Jenny K N wrote:
> This patch exports the host capabilities to debugfs
>
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
> ---
would you mind to restore the authorship to Abbas Raza and send v2?
Thank you in advance.
--
With best wishes,
Vladimir
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mmc: Export host capabilities to debugfs.
2018-03-03 16:32 ` Vladimir Zapolskiy
@ 2018-03-05 4:07 ` Harish Jenny K N
0 siblings, 0 replies; 7+ messages in thread
From: Harish Jenny K N @ 2018-03-05 4:07 UTC (permalink / raw)
To: Vladimir Zapolskiy, ulf.hansson, linus.walleij, adrian.hunter,
shawn.lin, avri.altman, andriy.shevchenko
Cc: linux-mmc, linux-kernel
On Saturday 03 March 2018 10:02 PM, Vladimir Zapolskiy wrote:
> Hi Harish,
>
> On 03/01/2018 03:17 PM, Harish Jenny K N wrote:
>> This patch exports the host capabilities to debugfs
>>
>> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
>> Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
>> ---
> would you mind to restore the authorship to Abbas Raza and send v2?
Sure. Abbas had left Mentor and this was being done as part of new project.
Still, I will resend the patch by changing the Author.
Thanks,
Harish
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] mmc: Export host capabilities to debugfs.
@ 2018-03-05 13:38 Harish Jenny K N
0 siblings, 0 replies; 7+ messages in thread
From: Harish Jenny K N @ 2018-03-05 13:38 UTC (permalink / raw)
To: ulf.hansson, linus.walleij, adrian.hunter, shawn.lin,
avri.altman, andriy.shevchenko
Cc: linux-mmc, linux-kernel, harish_kandiga, Vladimir_Zapolskiy
From: Abbas Raza <Abbas_Raza@mentor.com>
This patch exports the host capabilities to debugfs
Signed-off-by: Abbas Raza <Abbas_Raza@mentor.com>
Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
[Harish: Added caps2, moved creation to mmc_add_host_debugfs]
Signed-off-by: Harish Jenny K N <harish_kandiga@mentor.com>
---
Changes in v4:
- Moved the creation of nodes to mmc_add_host_debugfs
- Exported caps2
- Renamed host_caps to caps
Changes in v3:
- Removed typecasting of &host->caps to (u32 *)
Changes in v2:
- Changed Author
drivers/mmc/core/debugfs.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
index c51e0c0..d2275c5 100644
--- a/drivers/mmc/core/debugfs.c
+++ b/drivers/mmc/core/debugfs.c
@@ -243,6 +243,12 @@ void mmc_add_host_debugfs(struct mmc_host *host)
if (!debugfs_create_file("ios", S_IRUSR, root, host, &mmc_ios_fops))
goto err_node;
+ if (!debugfs_create_x32("caps", S_IRUSR, root, &host->caps))
+ goto err_node;
+
+ if (!debugfs_create_x32("caps2", S_IRUSR, root, &host->caps2))
+ goto err_node;
+
if (!debugfs_create_file("clock", S_IRUSR | S_IWUSR, root, host,
&mmc_clock_fops))
goto err_node;
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-03-05 13:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-01 13:17 [PATCH] mmc: Export host capabilities to debugfs Harish Jenny K N
2018-03-01 14:24 ` Linus Walleij
2018-03-02 13:17 ` Harish Jenny K N
2018-03-02 13:24 ` Linus Walleij
2018-03-03 16:32 ` Vladimir Zapolskiy
2018-03-05 4:07 ` Harish Jenny K N
2018-03-05 13:38 Harish Jenny K N
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).