* [PATCH] driver/netfilter/nfnetlink: removed unused variable
@ 2014-05-31 11:06 Robin Schroer
2014-06-01 9:55 ` Richard Weinberger
0 siblings, 1 reply; 2+ messages in thread
From: Robin Schroer @ 2014-05-31 11:06 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netfilter, coreteam, linux-kernel
Removes the unused struct net *net = sock_net(skb->sk);
Signed-off-by: Robin Schroer <sulamiification@gmail.com>
---
net/netfilter/nfnetlink.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c
index c138b8f..5cc9db2 100644
--- a/net/netfilter/nfnetlink.c
+++ b/net/netfilter/nfnetlink.c
@@ -226,7 +226,6 @@ static void nfnetlink_rcv_batch(struct sk_buff *skb, struct nlmsghdr *nlh,
u_int16_t subsys_id)
{
struct sk_buff *nskb, *oskb = skb;
- struct net *net = sock_net(skb->sk);
const struct nfnetlink_subsystem *ss;
const struct nfnl_callback *nc;
bool success = true, done = false;
--
1.9.3
--
Robin Schroer
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] driver/netfilter/nfnetlink: removed unused variable
2014-05-31 11:06 [PATCH] driver/netfilter/nfnetlink: removed unused variable Robin Schroer
@ 2014-06-01 9:55 ` Richard Weinberger
0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2014-06-01 9:55 UTC (permalink / raw)
To: Robin Schroer
Cc: Pablo Neira Ayuso, netfilter-devel, netfilter, coreteam, LKML
On Sat, May 31, 2014 at 1:06 PM, Robin Schroer
<sulamiification@gmail.com> wrote:
> Removes the unused struct net *net = sock_net(skb->sk);
>
> Signed-off-by: Robin Schroer <sulamiification@gmail.com>
Against which tree is that patch?
net-next.git still uses net in nfnetlink_rcv_batch() AFAICT.
---cut---
if (err < 0)
goto ack;
if (nc->call_batch) {
err = nc->call_batch(net->nfnl, skb, nlh,
(const struct nlattr **)cda);
}
/* The lock was released to autoload some module, we
* have to abort and start from scratch using the
* original skb.
*/
---cut---
> ---
> net/netfilter/nfnetlink.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c
> index c138b8f..5cc9db2 100644
> --- a/net/netfilter/nfnetlink.c
> +++ b/net/netfilter/nfnetlink.c
> @@ -226,7 +226,6 @@ static void nfnetlink_rcv_batch(struct sk_buff *skb, struct nlmsghdr *nlh,
> u_int16_t subsys_id)
> {
> struct sk_buff *nskb, *oskb = skb;
> - struct net *net = sock_net(skb->sk);
> const struct nfnetlink_subsystem *ss;
> const struct nfnl_callback *nc;
> bool success = true, done = false;
> --
> 1.9.3
>
>
> --
>
> Robin Schroer
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-01 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-31 11:06 [PATCH] driver/netfilter/nfnetlink: removed unused variable Robin Schroer
2014-06-01 9:55 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).