* [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies
@ 2019-12-11 19:27 Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency Brendan Higgins
` (6 more replies)
0 siblings, 7 replies; 29+ messages in thread
From: Brendan Higgins @ 2019-12-11 19:27 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, David S. Miller, Alistar Popple,
Andrew Jeffery, Antoine Tenart, Arnd Bergmann,
Bartlomiej Zolnierkiewicz, Boris Brezillon, Corentin Labbe,
Eddie James, Greg Kroah-Hartman, Herbert Xu, Jeremy Kerr,
Joel Stanley, Linus Walleij, Michal Simek, Miquel Raynal,
Moses Christopher, Piotr Sroka, Radhey Shyam Pandey,
Vignesh Raghavendra
Cc: linux-um, linux-kernel, davidgow, Brendan Higgins, devel,
linux-amlogic, linux-arm-kernel, linux-aspeed, linux-crypto,
linux-fsi, linux-gpio, linux-mtd, netdev
# TL;DR
This patchset adds a missing HAS_IOMEM dependency to several drivers in
an attempt to get allyesconfig closer to working for ARCH=um.
# What am I trying to do?
This patchset is part of my attempt to get `make ARCH=um allyesconfig`
to produce a config that will build *and* boot to init, so that I can
use it as a mechanism to run tests[1].
This patchset is attempting to deal with
CONFIG_PINCTRL_EQUILIBRIUM=y
CONFIG_MTD_NAND_CADENCE=y
CONFIG_FSI_MASTER_ASPEED=y
CONFIG_CRYPTO_DEV_SAFEXCEL=y
CONFIG_XIL_AXIS_FIFO=y
CONFIG_CRYPTO_DEV_AMLOGIC_GXL=y
CONFIG_XILINX_AXI_EMAC=y
which are selected by `make ARCH=um allyesconfig`, but prevent it from
building.
# How far away are we from an allyesconfig UML kernel?
I have identified 33 Kconfigs that are selected by allyesconfig, but
will either not build on UML, or prevent it from booting. They are:
CONFIG_STATIC_LINK=y
CONFIG_UML_NET_PCAP=y
CONFIG_NET_PTP_CLASSIFY=y
CONFIG_IP_VS=y
CONFIG_BRIDGE_EBT_BROUTE=y
CONFIG_BRIDGE_EBT_T_FILTER=y
CONFIG_BRIDGE_EBT_T_NAT=y
CONFIG_MTD_NAND_CADENCE=y
CONFIG_MTD_NAND_NANDSIM=y
CONFIG_BLK_DEV_NULL_BLK=y
CONFIG_BLK_DEV_RAM=y
CONFIG_SCSI_DEBUG=y
CONFIG_NET_VENDOR_XILINX=y
CONFIG_NULL_TTY=y
CONFIG_PTP_1588_CLOCK=y
CONFIG_PINCTRL_EQUILIBRIUM=y
CONFIG_DMABUF_SELFTESTS=y
CONFIG_COMEDI=y
CONFIG_XIL_AXIS_FIFO=y
CONFIG_EXFAT_FS=y
CONFIG_STM_DUMMY=y
CONFIG_FSI_MASTER_ASPEED=y
CONFIG_JFS_FS=y
CONFIG_UBIFS_FS=y
CONFIG_CRAMFS=y
CONFIG_CRYPTO_DEV_SAFEXCEL=y
CONFIG_CRYPTO_DEV_AMLOGIC_GXL=y
CONFIG_KCOV=y
CONFIG_LKDTM=y
CONFIG_REED_SOLOMON_TEST=y
CONFIG_TEST_RHASHTABLE=y
CONFIG_TEST_MEMINIT=y
CONFIG_NETWORK_PHY_TIMESTAMPING=y
CONFIG_STATIC_LINK=y and CONFIG_UML_NET_PCAP=y already have fixes on
their way.
I also have a patchset that just got accepted to fix
CONFIG_EXFAT_FS=y[2].
So with this patchset and these other three fixes mentioned here, we
will be about a third of the way there. There is only one more broken
config that prevents UML from building, CONFIG_LKDTM=y. After this there
will still be 22 broken configs which will prevent the UML allyesconfig
kernel from reaching the end of init; nevertheless, this is a good
milestone where, once reached, we can stop some of this bleeding by
adding a build test.
# Why won't allyesconfig break again after this series of fixes?
As I mentioned above, I am using UML for testing the kernel, and I am
currently working on getting my tests to run on KernelCI. As part of our
testing procedure for KernelCI, we are planning on building a UML kernel
using allyesconfig and running our tests on it. Thus, we will find out
very quickly once someone breaks allyesconfig again once we get this all
working.
Brendan Higgins (7):
pinctrl: equilibrium: add unspecified HAS_IOMEM dependency
mtd: rawnand: add unspecified HAS_IOMEM dependency
net: axienet: add unspecified HAS_IOMEM dependency
crypto: inside-secure: add unspecified HAS_IOMEM dependency
crypto: amlogic: add unspecified HAS_IOMEM dependency
staging: axis-fifo: add unspecified HAS_IOMEM dependency
fsi: aspeed: add unspecified HAS_IOMEM dependency
drivers/crypto/Kconfig | 2 +-
drivers/crypto/amlogic/Kconfig | 1 +
drivers/fsi/Kconfig | 1 +
drivers/mtd/nand/raw/Kconfig | 2 +-
drivers/net/ethernet/xilinx/Kconfig | 1 +
drivers/pinctrl/Kconfig | 1 +
drivers/staging/axis-fifo/Kconfig | 2 +-
7 files changed, 7 insertions(+), 3 deletions(-)
[1] https://bugzilla.kernel.org/show_bug.cgi?id=205223
[2] https://patchwork.kernel.org/patch/11273771/
--
2.24.0.525.g8f36a354ae-goog
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
@ 2019-12-11 19:27 ` Brendan Higgins
2019-12-16 8:42 ` Linus Walleij
2019-12-16 10:39 ` Linus Walleij
2019-12-11 19:27 ` [PATCH v1 2/7] mtd: rawnand: " Brendan Higgins
` (5 subsequent siblings)
6 siblings, 2 replies; 29+ messages in thread
From: Brendan Higgins @ 2019-12-11 19:27 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Linus Walleij
Cc: linux-um, linux-kernel, davidgow, Brendan Higgins, linux-gpio
Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe':
drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency.
Reported-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 3bfbf2ff6e2bd..2c0b30477f7d0 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -422,6 +422,7 @@ config PINCTRL_TB10X
config PINCTRL_EQUILIBRIUM
tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC"
+ depends on HAS_IOMEM
select PINMUX
select PINCONF
select GPIOLIB
--
2.24.0.525.g8f36a354ae-goog
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency Brendan Higgins
@ 2019-12-11 19:27 ` Brendan Higgins
2020-01-09 15:23 ` Miquel Raynal
2019-12-11 19:27 ` [PATCH v1 3/7] net: axienet: " Brendan Higgins
` (4 subsequent siblings)
6 siblings, 1 reply; 29+ messages in thread
From: Brendan Higgins @ 2019-12-11 19:27 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Miquel Raynal, Vignesh Raghavendra,
Boris Brezillon, Piotr Sroka
Cc: linux-um, linux-kernel, davidgow, Brendan Higgins, linux-mtd
Currently CONFIG_MTD_NAND_CADENCE implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Reported-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/mtd/nand/raw/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index 74fb91adeb469..a80a46bb5b8bc 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/drivers/mtd/nand/raw/Kconfig
@@ -452,7 +452,7 @@ config MTD_NAND_PLATFORM
config MTD_NAND_CADENCE
tristate "Support Cadence NAND (HPNFC) controller"
- depends on OF || COMPILE_TEST
+ depends on (OF || COMPILE_TEST) && HAS_IOMEM
help
Enable the driver for NAND flash on platforms using a Cadence NAND
controller.
--
2.24.0.525.g8f36a354ae-goog
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v1 3/7] net: axienet: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 2/7] mtd: rawnand: " Brendan Higgins
@ 2019-12-11 19:27 ` Brendan Higgins
2019-12-12 5:45 ` Radhey Shyam Pandey
2019-12-11 19:27 ` [PATCH v1 4/7] crypto: inside-secure: " Brendan Higgins
` (3 subsequent siblings)
6 siblings, 1 reply; 29+ messages in thread
From: Brendan Higgins @ 2019-12-11 19:27 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, David S. Miller, Michal Simek,
Radhey Shyam Pandey
Cc: linux-um, linux-kernel, davidgow, Brendan Higgins, netdev,
linux-arm-kernel
Currently CONFIG_XILINX_AXI_EMAC=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function `axienet_probe':
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1680: undefined reference to `devm_ioremap_resource'
ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1779: undefined reference to `devm_ioremap_resource'
ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1789: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Reported-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/net/ethernet/xilinx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
index 6304ebd8b5c69..b1a285e693756 100644
--- a/drivers/net/ethernet/xilinx/Kconfig
+++ b/drivers/net/ethernet/xilinx/Kconfig
@@ -25,6 +25,7 @@ config XILINX_EMACLITE
config XILINX_AXI_EMAC
tristate "Xilinx 10/100/1000 AXI Ethernet support"
+ depends on HAS_IOMEM
select PHYLINK
---help---
This driver supports the 10/100/1000 Ethernet from Xilinx for the
--
2.24.0.525.g8f36a354ae-goog
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v1 4/7] crypto: inside-secure: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
` (2 preceding siblings ...)
2019-12-11 19:27 ` [PATCH v1 3/7] net: axienet: " Brendan Higgins
@ 2019-12-11 19:27 ` Brendan Higgins
2019-12-20 7:07 ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 5/7] crypto: amlogic: " Brendan Higgins
` (2 subsequent siblings)
6 siblings, 1 reply; 29+ messages in thread
From: Brendan Higgins @ 2019-12-11 19:27 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Herbert Xu, David S. Miller,
Antoine Tenart
Cc: linux-um, linux-kernel, davidgow, Brendan Higgins, linux-crypto
Currently CONFIG_CRYPTO_DEV_SAFEXCEL=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
ld: drivers/crypto/inside-secure/safexcel.o: in function `safexcel_probe':
drivers/crypto/inside-secure/safexcel.c:1692: undefined reference to `devm_platform_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Reported-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 91eb768d4221a..0a73bebd04e5d 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -716,7 +716,7 @@ source "drivers/crypto/stm32/Kconfig"
config CRYPTO_DEV_SAFEXCEL
tristate "Inside Secure's SafeXcel cryptographic engine driver"
- depends on OF || PCI || COMPILE_TEST
+ depends on (OF || PCI || COMPILE_TEST) && HAS_IOMEM
select CRYPTO_LIB_AES
select CRYPTO_AUTHENC
select CRYPTO_SKCIPHER
--
2.24.0.525.g8f36a354ae-goog
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v1 5/7] crypto: amlogic: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
` (3 preceding siblings ...)
2019-12-11 19:27 ` [PATCH v1 4/7] crypto: inside-secure: " Brendan Higgins
@ 2019-12-11 19:27 ` Brendan Higgins
2019-12-12 19:36 ` LABBE Corentin
2019-12-20 7:07 ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 6/7] staging: axis-fifo: " Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 7/7] fsi: aspeed: " Brendan Higgins
6 siblings, 2 replies; 29+ messages in thread
From: Brendan Higgins @ 2019-12-11 19:27 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Corentin Labbe, Herbert Xu,
David S. Miller
Cc: linux-um, linux-kernel, davidgow, Brendan Higgins, linux-crypto,
linux-amlogic
Currently CONFIG_CRYPTO_DEV_AMLOGIC_GXL=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
ld: drivers/crypto/amlogic/amlogic-gxl-core.o: in function `meson_crypto_probe':
drivers/crypto/amlogic/amlogic-gxl-core.c:240: undefined reference to `devm_platform_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Reported-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/crypto/amlogic/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/amlogic/Kconfig b/drivers/crypto/amlogic/Kconfig
index b90850d18965f..cf95476026708 100644
--- a/drivers/crypto/amlogic/Kconfig
+++ b/drivers/crypto/amlogic/Kconfig
@@ -1,5 +1,6 @@
config CRYPTO_DEV_AMLOGIC_GXL
tristate "Support for amlogic cryptographic offloader"
+ depends on HAS_IOMEM
default y if ARCH_MESON
select CRYPTO_SKCIPHER
select CRYPTO_ENGINE
--
2.24.0.525.g8f36a354ae-goog
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v1 6/7] staging: axis-fifo: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
` (4 preceding siblings ...)
2019-12-11 19:27 ` [PATCH v1 5/7] crypto: amlogic: " Brendan Higgins
@ 2019-12-11 19:27 ` Brendan Higgins
2019-12-14 11:28 ` Greg Kroah-Hartman
2019-12-11 19:27 ` [PATCH v1 7/7] fsi: aspeed: " Brendan Higgins
6 siblings, 1 reply; 29+ messages in thread
From: Brendan Higgins @ 2019-12-11 19:27 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Greg Kroah-Hartman,
Bartlomiej Zolnierkiewicz, Arnd Bergmann, Moses Christopher
Cc: linux-um, linux-kernel, davidgow, Brendan Higgins, devel
Currently CONFIG_XIL_AXIS_FIFO=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
ld: drivers/staging/axis-fifo/axis-fifo.o: in function `axis_fifo_probe':
drivers/staging/axis-fifo/axis-fifo.c:809: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Reported-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/staging/axis-fifo/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/axis-fifo/Kconfig b/drivers/staging/axis-fifo/Kconfig
index 3fffe4d6f327f..f180a8e9f58af 100644
--- a/drivers/staging/axis-fifo/Kconfig
+++ b/drivers/staging/axis-fifo/Kconfig
@@ -4,7 +4,7 @@
#
config XIL_AXIS_FIFO
tristate "Xilinx AXI-Stream FIFO IP core driver"
- depends on OF
+ depends on OF && HAS_IOMEM
help
This adds support for the Xilinx AXI-Stream FIFO IP core driver.
The AXI Streaming FIFO allows memory mapped access to a AXI Streaming
--
2.24.0.525.g8f36a354ae-goog
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
` (5 preceding siblings ...)
2019-12-11 19:27 ` [PATCH v1 6/7] staging: axis-fifo: " Brendan Higgins
@ 2019-12-11 19:27 ` Brendan Higgins
2019-12-12 0:12 ` Joel Stanley
6 siblings, 1 reply; 29+ messages in thread
From: Brendan Higgins @ 2019-12-11 19:27 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, Joel Stanley, Andrew Jeffery,
Jeremy Kerr, Alistar Popple, Eddie James
Cc: linux-um, linux-kernel, davidgow, Brendan Higgins, linux-fsi,
linux-arm-kernel, linux-aspeed
Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe':
drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Reported-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/fsi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig
index 92ce6d85802cc..4cc0e630ab79b 100644
--- a/drivers/fsi/Kconfig
+++ b/drivers/fsi/Kconfig
@@ -55,6 +55,7 @@ config FSI_MASTER_AST_CF
config FSI_MASTER_ASPEED
tristate "FSI ASPEED master"
+ depends on HAS_IOMEM
help
This option enables a FSI master that is present behind an OPB bridge
in the AST2600.
--
2.24.0.525.g8f36a354ae-goog
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 ` [PATCH v1 7/7] fsi: aspeed: " Brendan Higgins
@ 2019-12-12 0:12 ` Joel Stanley
2019-12-12 0:30 ` Brendan Higgins
0 siblings, 1 reply; 29+ messages in thread
From: Joel Stanley @ 2019-12-12 0:12 UTC (permalink / raw)
To: Brendan Higgins
Cc: jdike, Richard Weinberger, anton.ivanov, Andrew Jeffery,
Jeremy Kerr, Alistar Popple, Eddie James, linux-um,
Linux Kernel Mailing List, davidgow, linux-fsi, Linux ARM,
linux-aspeed
On Wed, 11 Dec 2019 at 19:28, Brendan Higgins <brendanhiggins@google.com> wrote:
>
> Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe':
> drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Reported-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in
order to build some ARM drivers under UM. Do you have plans to fix
that too?
Do you want to get this in a fix for 5.5?
Acked-by: Joel Stanley <joel@jms.id.au>
Cheers,
Joel
> ---
> drivers/fsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig
> index 92ce6d85802cc..4cc0e630ab79b 100644
> --- a/drivers/fsi/Kconfig
> +++ b/drivers/fsi/Kconfig
> @@ -55,6 +55,7 @@ config FSI_MASTER_AST_CF
>
> config FSI_MASTER_ASPEED
> tristate "FSI ASPEED master"
> + depends on HAS_IOMEM
> help
> This option enables a FSI master that is present behind an OPB bridge
> in the AST2600.
> --
> 2.24.0.525.g8f36a354ae-goog
>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency
2019-12-12 0:12 ` Joel Stanley
@ 2019-12-12 0:30 ` Brendan Higgins
2019-12-16 6:01 ` Joel Stanley
2020-01-27 9:46 ` Brendan Higgins
0 siblings, 2 replies; 29+ messages in thread
From: Brendan Higgins @ 2019-12-12 0:30 UTC (permalink / raw)
To: Joel Stanley
Cc: Jeff Dike, Richard Weinberger, Anton Ivanov, Andrew Jeffery,
Jeremy Kerr, Alistar Popple, Eddie James, linux-um,
Linux Kernel Mailing List, David Gow, linux-fsi, Linux ARM,
linux-aspeed
On Wed, Dec 11, 2019 at 4:12 PM Joel Stanley <joel@jms.id.au> wrote:
>
> On Wed, 11 Dec 2019 at 19:28, Brendan Higgins <brendanhiggins@google.com> wrote:
> >
> > Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on
> > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > the following build error:
> >
> > ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe':
> > drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource'
> >
> > Fix the build error by adding the unspecified dependency.
> >
> > Reported-by: Brendan Higgins <brendanhiggins@google.com>
> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
>
> Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in
> order to build some ARM drivers under UM. Do you have plans to fix
> that too?
The only broken configs I found for UML are all listed on the cover
letter of this patch. I think fixing COMPILE_TEST on UM could be
worthwhile. Did you see any brokenness other than what I mentioned on
the cover letter?
> Do you want to get this in a fix for 5.5?
Preferably, yes.
> Acked-by: Joel Stanley <joel@jms.id.au>
Thanks!
^ permalink raw reply [flat|nested] 29+ messages in thread
* RE: [PATCH v1 3/7] net: axienet: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 ` [PATCH v1 3/7] net: axienet: " Brendan Higgins
@ 2019-12-12 5:45 ` Radhey Shyam Pandey
0 siblings, 0 replies; 29+ messages in thread
From: Radhey Shyam Pandey @ 2019-12-12 5:45 UTC (permalink / raw)
To: Brendan Higgins, jdike, richard, anton.ivanov, David S. Miller,
Michal Simek
Cc: linux-um, linux-kernel, davidgow, netdev, linux-arm-kernel
> -----Original Message-----
> From: Brendan Higgins <brendanhiggins@google.com>
> Sent: Thursday, December 12, 2019 12:58 AM
> To: jdike@addtoit.com; richard@nod.at;
> anton.ivanov@cambridgegreys.com; David S. Miller
> <davem@davemloft.net>; Michal Simek <michals@xilinx.com>; Radhey
> Shyam Pandey <radheys@xilinx.com>
> Cc: linux-um@lists.infradead.org; linux-kernel@vger.kernel.org;
> davidgow@google.com; Brendan Higgins <brendanhiggins@google.com>;
> netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: [PATCH v1 3/7] net: axienet: add unspecified HAS_IOMEM
> dependency
>
> Currently CONFIG_XILINX_AXI_EMAC=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we
> get
> the following build error:
>
> ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function
> `axienet_probe':
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1680: undefined reference
> to `devm_ioremap_resource'
> ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1779: undefined
> reference to `devm_ioremap_resource'
> ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1789: undefined
> reference to `devm_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Reported-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Thanks!
> ---
> drivers/net/ethernet/xilinx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/xilinx/Kconfig
> b/drivers/net/ethernet/xilinx/Kconfig
> index 6304ebd8b5c69..b1a285e693756 100644
> --- a/drivers/net/ethernet/xilinx/Kconfig
> +++ b/drivers/net/ethernet/xilinx/Kconfig
> @@ -25,6 +25,7 @@ config XILINX_EMACLITE
>
> config XILINX_AXI_EMAC
> tristate "Xilinx 10/100/1000 AXI Ethernet support"
> + depends on HAS_IOMEM
> select PHYLINK
> ---help---
> This driver supports the 10/100/1000 Ethernet from Xilinx for the
> --
> 2.24.0.525.g8f36a354ae-goog
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 5/7] crypto: amlogic: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 ` [PATCH v1 5/7] crypto: amlogic: " Brendan Higgins
@ 2019-12-12 19:36 ` LABBE Corentin
2019-12-20 7:07 ` Herbert Xu
1 sibling, 0 replies; 29+ messages in thread
From: LABBE Corentin @ 2019-12-12 19:36 UTC (permalink / raw)
To: Brendan Higgins
Cc: jdike, richard, anton.ivanov, Herbert Xu, David S. Miller,
linux-um, linux-kernel, davidgow, linux-crypto, linux-amlogic
On Wed, Dec 11, 2019 at 11:27:40AM -0800, Brendan Higgins wrote:
> Currently CONFIG_CRYPTO_DEV_AMLOGIC_GXL=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> ld: drivers/crypto/amlogic/amlogic-gxl-core.o: in function `meson_crypto_probe':
> drivers/crypto/amlogic/amlogic-gxl-core.c:240: undefined reference to `devm_platform_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Reported-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
> drivers/crypto/amlogic/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/amlogic/Kconfig b/drivers/crypto/amlogic/Kconfig
> index b90850d18965f..cf95476026708 100644
> --- a/drivers/crypto/amlogic/Kconfig
> +++ b/drivers/crypto/amlogic/Kconfig
> @@ -1,5 +1,6 @@
> config CRYPTO_DEV_AMLOGIC_GXL
> tristate "Support for amlogic cryptographic offloader"
> + depends on HAS_IOMEM
> default y if ARCH_MESON
> select CRYPTO_SKCIPHER
> select CRYPTO_ENGINE
Acked-by: Corentin Labbe <clabbe@baylibre.com>
Thanks
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 6/7] staging: axis-fifo: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 ` [PATCH v1 6/7] staging: axis-fifo: " Brendan Higgins
@ 2019-12-14 11:28 ` Greg Kroah-Hartman
2020-01-23 22:16 ` Brendan Higgins
0 siblings, 1 reply; 29+ messages in thread
From: Greg Kroah-Hartman @ 2019-12-14 11:28 UTC (permalink / raw)
To: Brendan Higgins
Cc: jdike, richard, anton.ivanov, Bartlomiej Zolnierkiewicz,
Arnd Bergmann, Moses Christopher, linux-um, linux-kernel,
davidgow, devel
On Wed, Dec 11, 2019 at 11:27:41AM -0800, Brendan Higgins wrote:
> Currently CONFIG_XIL_AXIS_FIFO=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> ld: drivers/staging/axis-fifo/axis-fifo.o: in function `axis_fifo_probe':
> drivers/staging/axis-fifo/axis-fifo.c:809: undefined reference to `devm_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Reported-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
Saying you reported a problem and then fixed it kind of does a bit of
disservice to the "reported-by:" tag which we normally use only to
credit the people that do not actually fix the problem.
So in the future, no need for this to be there for patches that you
write yourself.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency
2019-12-12 0:30 ` Brendan Higgins
@ 2019-12-16 6:01 ` Joel Stanley
2020-01-27 9:46 ` Brendan Higgins
1 sibling, 0 replies; 29+ messages in thread
From: Joel Stanley @ 2019-12-16 6:01 UTC (permalink / raw)
To: Brendan Higgins
Cc: Andrew Jeffery, linux-um, Linux Kernel Mailing List, Linux ARM,
linux-aspeed
On Thu, 12 Dec 2019 at 00:30, Brendan Higgins <brendanhiggins@google.com> wrote:
>
> On Wed, Dec 11, 2019 at 4:12 PM Joel Stanley <joel@jms.id.au> wrote:
> >
> > Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in
> > order to build some ARM drivers under UM. Do you have plans to fix
> > that too?
>
> The only broken configs I found for UML are all listed on the cover
> letter of this patch. I think fixing COMPILE_TEST on UM could be
> worthwhile. Did you see any brokenness other than what I mentioned on
> the cover letter?
There's a few more in drivers/char/hw_random that you would need.
These were HW_RANDOM_MESON , HW_RANDOM_MTK, HW_RANDOM_EXYNOS,
HW_RANDOM_NPCM, HW_RANDOM_KEYSTONE.
The only one from your series I needed was PINCTRL_EQUILIBRIUM.
I applied this:
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -91,7 +91,6 @@ config INIT_ENV_ARG_LIMIT
config COMPILE_TEST
bool "Compile also drivers which will not load"
- depends on !UML
default n
help
That lets me build. However, the code I was attempting to enable
depends on REGMAP, which needs IOMEM too, so I hit that dead end.
Another issue I had was debugging my kunitconfig. This patch helped a bit:
--- a/tools/testing/kunit/kunit_config.py
+++ b/tools/testing/kunit/kunit_config.py
@@ -40,6 +40,9 @@ class Kconfig(object):
def is_subset_of(self, other: 'Kconfig') -> bool:
return self.entries().issubset(other.entries())
+ def difference(self, other: 'Kconfig') -> list:
+ return self.entries().difference(other.entries())
+
def write_to_file(self, path: str) -> None:
with open(path, 'w') as f:
for entry in self.entries():
diff --git a/tools/testing/kunit/kunit_kernel.py
b/tools/testing/kunit/kunit_kernel.py
index bf3876835331..0f261bc087e4 100644
--- a/tools/testing/kunit/kunit_kernel.py
+++ b/tools/testing/kunit/kunit_kernel.py
@@ -107,6 +107,7 @@ class LinuxSourceTree(object):
validated_kconfig.read_from_file(kconfig_path)
if not self._kconfig.is_subset_of(validated_kconfig):
logging.error('Provided Kconfig is not
contained in validated .config!')
+
logging.error(self._kconfig.difference(validated_kconfig))
return False
return True
Which would need some tidying up before applying, but helped a lot in
working out what was going wrong.
>
> > Do you want to get this in a fix for 5.5?
>
> Preferably, yes.
>
> > Acked-by: Joel Stanley <joel@jms.id.au>
>
> Thanks!
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 ` [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency Brendan Higgins
@ 2019-12-16 8:42 ` Linus Walleij
2019-12-16 9:31 ` Arnd Bergmann
2019-12-16 10:39 ` Linus Walleij
1 sibling, 1 reply; 29+ messages in thread
From: Linus Walleij @ 2019-12-16 8:42 UTC (permalink / raw)
To: Brendan Higgins, Rahul Tanwar, Arnd Bergmann
Cc: jdike, Richard Weinberger, anton.ivanov, linux-um, linux-kernel,
davidgow, open list:GPIO SUBSYSTEM
On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins
<brendanhiggins@google.com> wrote:
> Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe':
> drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource'
> ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource'
>
> Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency.
>
> Reported-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
We recently fixed a compile error by adding
depends on OF
and I think OF implies HAS_IOMEM so this should be fixed
now.
Can you confirm?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency
2019-12-16 8:42 ` Linus Walleij
@ 2019-12-16 9:31 ` Arnd Bergmann
0 siblings, 0 replies; 29+ messages in thread
From: Arnd Bergmann @ 2019-12-16 9:31 UTC (permalink / raw)
To: Linus Walleij
Cc: Brendan Higgins, Rahul Tanwar, Jeff Dike, Richard Weinberger,
Anton Ivanov, linux-um, linux-kernel, davidgow,
open list:GPIO SUBSYSTEM
On Mon, Dec 16, 2019 at 9:42 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins
> <brendanhiggins@google.com> wrote:
>
> > Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on
> > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > the following build error:
> >
> > ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe':
> > drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource'
> > ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource'
> >
> > Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency.
> >
> > Reported-by: Brendan Higgins <brendanhiggins@google.com>
> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
>
> We recently fixed a compile error by adding
> depends on OF
> and I think OF implies HAS_IOMEM so this should be fixed
> now.
>
> Can you confirm?
I'm fairly sure it does not, so both patches are needed.
Arnd
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 ` [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency Brendan Higgins
2019-12-16 8:42 ` Linus Walleij
@ 2019-12-16 10:39 ` Linus Walleij
2020-01-23 22:15 ` Brendan Higgins
1 sibling, 1 reply; 29+ messages in thread
From: Linus Walleij @ 2019-12-16 10:39 UTC (permalink / raw)
To: Brendan Higgins
Cc: jdike, Richard Weinberger, anton.ivanov, linux-um, linux-kernel,
David Gow, open list:GPIO SUBSYSTEM
On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins
<brendanhiggins@google.com> wrote:
> Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe':
> drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource'
> ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource'
>
> Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency.
>
> Reported-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
Patch applied but I augmented it with the recently added
OF dependency so it now says:
depends on OF && HAS_IOMEM
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 4/7] crypto: inside-secure: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 ` [PATCH v1 4/7] crypto: inside-secure: " Brendan Higgins
@ 2019-12-20 7:07 ` Herbert Xu
0 siblings, 0 replies; 29+ messages in thread
From: Herbert Xu @ 2019-12-20 7:07 UTC (permalink / raw)
To: Brendan Higgins
Cc: jdike, richard, anton.ivanov, David S. Miller, Antoine Tenart,
linux-um, linux-kernel, davidgow, linux-crypto
On Wed, Dec 11, 2019 at 11:27:39AM -0800, Brendan Higgins wrote:
> Currently CONFIG_CRYPTO_DEV_SAFEXCEL=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> ld: drivers/crypto/inside-secure/safexcel.o: in function `safexcel_probe':
> drivers/crypto/inside-secure/safexcel.c:1692: undefined reference to `devm_platform_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Reported-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
> drivers/crypto/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 5/7] crypto: amlogic: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 ` [PATCH v1 5/7] crypto: amlogic: " Brendan Higgins
2019-12-12 19:36 ` LABBE Corentin
@ 2019-12-20 7:07 ` Herbert Xu
1 sibling, 0 replies; 29+ messages in thread
From: Herbert Xu @ 2019-12-20 7:07 UTC (permalink / raw)
To: Brendan Higgins
Cc: jdike, richard, anton.ivanov, Corentin Labbe, David S. Miller,
linux-um, linux-kernel, davidgow, linux-crypto, linux-amlogic
On Wed, Dec 11, 2019 at 11:27:40AM -0800, Brendan Higgins wrote:
> Currently CONFIG_CRYPTO_DEV_AMLOGIC_GXL=y implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> ld: drivers/crypto/amlogic/amlogic-gxl-core.o: in function `meson_crypto_probe':
> drivers/crypto/amlogic/amlogic-gxl-core.c:240: undefined reference to `devm_platform_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Reported-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
> drivers/crypto/amlogic/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency
2019-12-11 19:27 ` [PATCH v1 2/7] mtd: rawnand: " Brendan Higgins
@ 2020-01-09 15:23 ` Miquel Raynal
2020-01-25 2:12 ` Brendan Higgins
0 siblings, 1 reply; 29+ messages in thread
From: Miquel Raynal @ 2020-01-09 15:23 UTC (permalink / raw)
To: Brendan Higgins
Cc: jdike, richard, anton.ivanov, Vignesh Raghavendra,
Boris Brezillon, Piotr Sroka, linux-um, linux-kernel, davidgow,
linux-mtd
Hi Brendan,
Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019
11:27:37 -0800:
> Currently CONFIG_MTD_NAND_CADENCE implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
> drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
> ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Reported-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
Sorry for the delay.
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency
2019-12-16 10:39 ` Linus Walleij
@ 2020-01-23 22:15 ` Brendan Higgins
0 siblings, 0 replies; 29+ messages in thread
From: Brendan Higgins @ 2020-01-23 22:15 UTC (permalink / raw)
To: Linus Walleij
Cc: Jeff Dike, Richard Weinberger, Anton Ivanov, linux-um,
linux-kernel, David Gow, open list:GPIO SUBSYSTEM
Sorry for not getting to this before I went on vacation.
On Mon, Dec 16, 2019 at 2:39 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins
> <brendanhiggins@google.com> wrote:
>
> > Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on
> > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > the following build error:
> >
> > ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe':
> > drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource'
> > ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource'
> >
> > Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency.
> >
> > Reported-by: Brendan Higgins <brendanhiggins@google.com>
> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
>
> Patch applied but I augmented it with the recently added
> OF dependency so it now says:
> depends on OF && HAS_IOMEM
Probably too late now to be helpful, but I can confirm that OF does
NOT depend on HAS_IOMEM, so this patch was still needed.
Thanks regardless!
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 6/7] staging: axis-fifo: add unspecified HAS_IOMEM dependency
2019-12-14 11:28 ` Greg Kroah-Hartman
@ 2020-01-23 22:16 ` Brendan Higgins
0 siblings, 0 replies; 29+ messages in thread
From: Brendan Higgins @ 2020-01-23 22:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jeff Dike, Richard Weinberger, Anton Ivanov,
Bartlomiej Zolnierkiewicz, Arnd Bergmann, Moses Christopher,
linux-um, Linux Kernel Mailing List, David Gow, devel
On Sat, Dec 14, 2019 at 3:28 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Dec 11, 2019 at 11:27:41AM -0800, Brendan Higgins wrote:
> > Currently CONFIG_XIL_AXIS_FIFO=y implicitly depends on
> > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > the following build error:
> >
> > ld: drivers/staging/axis-fifo/axis-fifo.o: in function `axis_fifo_probe':
> > drivers/staging/axis-fifo/axis-fifo.c:809: undefined reference to `devm_ioremap_resource'
> >
> > Fix the build error by adding the unspecified dependency.
> >
> > Reported-by: Brendan Higgins <brendanhiggins@google.com>
> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
>
> Saying you reported a problem and then fixed it kind of does a bit of
> disservice to the "reported-by:" tag which we normally use only to
> credit the people that do not actually fix the problem.
>
> So in the future, no need for this to be there for patches that you
> write yourself.
Alright, thanks for spelling that out. I will remember that in the future.
Cheers!
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency
2020-01-09 15:23 ` Miquel Raynal
@ 2020-01-25 2:12 ` Brendan Higgins
2020-01-25 15:28 ` Miquel Raynal
0 siblings, 1 reply; 29+ messages in thread
From: Brendan Higgins @ 2020-01-25 2:12 UTC (permalink / raw)
To: Miquel Raynal
Cc: Jeff Dike, Richard Weinberger, Anton Ivanov, Vignesh Raghavendra,
Boris Brezillon, Piotr Sroka, linux-um,
Linux Kernel Mailing List, David Gow, linux-mtd
On Thu, Jan 9, 2020 at 7:23 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Brendan,
>
> Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019
> 11:27:37 -0800:
>
> > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on
> > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > the following build error:
> >
> > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
> > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
> > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'
> >
> > Fix the build error by adding the unspecified dependency.
> >
> > Reported-by: Brendan Higgins <brendanhiggins@google.com>
> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> > ---
>
> Sorry for the delay.
>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
It looks like my change has not been applied to nand/next; is this the
branch it should be applied to? I have also verified that this patch
isn't in linux-next as of Jan 24th.
Is mtd/linux the correct tree for this? Or do I need to reach out to
someone else?
Cheers
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency
2020-01-25 2:12 ` Brendan Higgins
@ 2020-01-25 15:28 ` Miquel Raynal
2020-01-27 19:00 ` Brendan Higgins
2020-01-30 19:50 ` Miquel Raynal
0 siblings, 2 replies; 29+ messages in thread
From: Miquel Raynal @ 2020-01-25 15:28 UTC (permalink / raw)
To: Brendan Higgins
Cc: Jeff Dike, Richard Weinberger, Anton Ivanov, Vignesh Raghavendra,
Boris Brezillon, Piotr Sroka, linux-um,
Linux Kernel Mailing List, David Gow, linux-mtd
Hi Brendan,
Brendan Higgins <brendanhiggins@google.com> wrote on Fri, 24 Jan 2020
18:12:12 -0800:
> On Thu, Jan 9, 2020 at 7:23 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > Hi Brendan,
> >
> > Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019
> > 11:27:37 -0800:
> >
> > > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on
> > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > > the following build error:
> > >
> > > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
> > > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
> > > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'
> > >
> > > Fix the build error by adding the unspecified dependency.
> > >
> > > Reported-by: Brendan Higgins <brendanhiggins@google.com>
> > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> > > ---
> >
> > Sorry for the delay.
> >
> > Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> It looks like my change has not been applied to nand/next; is this the
> branch it should be applied to? I have also verified that this patch
> isn't in linux-next as of Jan 24th.
>
> Is mtd/linux the correct tree for this? Or do I need to reach out to
> someone else?
When I sent my Acked-by I supposed someone else would pick the patch,
but there is actually no dependency with all the other patches so I
don't know why I did it... Sorry about that. I'll take it anyway in my
PR for 5.6.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency
2019-12-12 0:30 ` Brendan Higgins
2019-12-16 6:01 ` Joel Stanley
@ 2020-01-27 9:46 ` Brendan Higgins
2020-01-31 3:43 ` Joel Stanley
1 sibling, 1 reply; 29+ messages in thread
From: Brendan Higgins @ 2020-01-27 9:46 UTC (permalink / raw)
To: Joel Stanley
Cc: Jeff Dike, Richard Weinberger, Anton Ivanov, Andrew Jeffery,
Jeremy Kerr, Alistar Popple, Eddie James, linux-um,
Linux Kernel Mailing List, David Gow, linux-fsi, Linux ARM,
linux-aspeed
On Wed, Dec 11, 2019 at 4:30 PM Brendan Higgins
<brendanhiggins@google.com> wrote:
>
> On Wed, Dec 11, 2019 at 4:12 PM Joel Stanley <joel@jms.id.au> wrote:
> >
> > On Wed, 11 Dec 2019 at 19:28, Brendan Higgins <brendanhiggins@google.com> wrote:
> > >
> > > Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on
> > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > > the following build error:
> > >
> > > ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe':
> > > drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource'
> > >
> > > Fix the build error by adding the unspecified dependency.
> > >
> > > Reported-by: Brendan Higgins <brendanhiggins@google.com>
> > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> >
> > Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in
> > order to build some ARM drivers under UM. Do you have plans to fix
> > that too?
>
> The only broken configs I found for UML are all listed on the cover
> letter of this patch. I think fixing COMPILE_TEST on UM could be
> worthwhile. Did you see any brokenness other than what I mentioned on
> the cover letter?
>
> > Do you want to get this in a fix for 5.5?
>
> Preferably, yes.
>
> > Acked-by: Joel Stanley <joel@jms.id.au>
Hey, I know I owe you a reply about debugging your kunitconfig (I'll
try to get to that this week); nevertheless, it looks like this patch
didn't make it into 5.5. Can you make sure it gets into 5.6? It
shouldn't depend on anything else.
Cheers
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency
2020-01-25 15:28 ` Miquel Raynal
@ 2020-01-27 19:00 ` Brendan Higgins
2020-01-30 19:50 ` Miquel Raynal
1 sibling, 0 replies; 29+ messages in thread
From: Brendan Higgins @ 2020-01-27 19:00 UTC (permalink / raw)
To: Miquel Raynal
Cc: Jeff Dike, Richard Weinberger, Anton Ivanov, Vignesh Raghavendra,
Boris Brezillon, Piotr Sroka, linux-um,
Linux Kernel Mailing List, David Gow, linux-mtd
On Sat, Jan 25, 2020 at 7:28 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Brendan,
>
> Brendan Higgins <brendanhiggins@google.com> wrote on Fri, 24 Jan 2020
> 18:12:12 -0800:
>
> > On Thu, Jan 9, 2020 at 7:23 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > >
> > > Hi Brendan,
> > >
> > > Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019
> > > 11:27:37 -0800:
> > >
> > > > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on
> > > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > > > the following build error:
> > > >
> > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
> > > > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
> > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'
> > > >
> > > > Fix the build error by adding the unspecified dependency.
> > > >
> > > > Reported-by: Brendan Higgins <brendanhiggins@google.com>
> > > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> > > > ---
> > >
> > > Sorry for the delay.
> > >
> > > Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
> >
> > It looks like my change has not been applied to nand/next; is this the
> > branch it should be applied to? I have also verified that this patch
> > isn't in linux-next as of Jan 24th.
> >
> > Is mtd/linux the correct tree for this? Or do I need to reach out to
> > someone else?
>
> When I sent my Acked-by I supposed someone else would pick the patch,
> but there is actually no dependency with all the other patches so I
> don't know why I did it... Sorry about that. I'll take it anyway in my
> PR for 5.6.
No worries, thanks!
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency
2020-01-25 15:28 ` Miquel Raynal
2020-01-27 19:00 ` Brendan Higgins
@ 2020-01-30 19:50 ` Miquel Raynal
2020-01-30 19:55 ` Brendan Higgins
1 sibling, 1 reply; 29+ messages in thread
From: Miquel Raynal @ 2020-01-30 19:50 UTC (permalink / raw)
To: Brendan Higgins
Cc: Jeff Dike, Richard Weinberger, Anton Ivanov, Vignesh Raghavendra,
Boris Brezillon, Piotr Sroka, linux-um,
Linux Kernel Mailing List, David Gow, linux-mtd
Hello,
Miquel Raynal <miquel.raynal@bootlin.com> wrote on Sat, 25 Jan 2020
16:28:03 +0100:
> Hi Brendan,
>
> Brendan Higgins <brendanhiggins@google.com> wrote on Fri, 24 Jan 2020
> 18:12:12 -0800:
>
> > On Thu, Jan 9, 2020 at 7:23 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > >
> > > Hi Brendan,
> > >
> > > Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019
> > > 11:27:37 -0800:
> > >
> > > > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on
> > > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > > > the following build error:
> > > >
> > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
> > > > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
> > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'
> > > >
> > > > Fix the build error by adding the unspecified dependency.
> > > >
> > > > Reported-by: Brendan Higgins <brendanhiggins@google.com>
> > > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> > > > ---
> > >
> > > Sorry for the delay.
> > >
> > > Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
> >
> > It looks like my change has not been applied to nand/next; is this the
> > branch it should be applied to? I have also verified that this patch
> > isn't in linux-next as of Jan 24th.
> >
> > Is mtd/linux the correct tree for this? Or do I need to reach out to
> > someone else?
>
> When I sent my Acked-by I supposed someone else would pick the patch,
> but there is actually no dependency with all the other patches so I
> don't know why I did it... Sorry about that. I'll take it anyway in my
> PR for 5.6.
It is applied on top of mtd/next since a few days, it will be part of
the 5.6 PR.
Sorry for the delay.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency
2020-01-30 19:50 ` Miquel Raynal
@ 2020-01-30 19:55 ` Brendan Higgins
0 siblings, 0 replies; 29+ messages in thread
From: Brendan Higgins @ 2020-01-30 19:55 UTC (permalink / raw)
To: Miquel Raynal
Cc: Jeff Dike, Richard Weinberger, Anton Ivanov, Vignesh Raghavendra,
Boris Brezillon, Piotr Sroka, linux-um,
Linux Kernel Mailing List, David Gow, linux-mtd
On Thu, Jan 30, 2020 at 11:50 AM Miquel Raynal
<miquel.raynal@bootlin.com> wrote:
>
> Hello,
>
> Miquel Raynal <miquel.raynal@bootlin.com> wrote on Sat, 25 Jan 2020
> 16:28:03 +0100:
>
> > Hi Brendan,
> >
> > Brendan Higgins <brendanhiggins@google.com> wrote on Fri, 24 Jan 2020
> > 18:12:12 -0800:
> >
> > > On Thu, Jan 9, 2020 at 7:23 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > > >
> > > > Hi Brendan,
> > > >
> > > > Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019
> > > > 11:27:37 -0800:
> > > >
> > > > > Currently CONFIG_MTD_NAND_CADENCE implicitly depends on
> > > > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > > > > the following build error:
> > > > >
> > > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
> > > > > drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
> > > > > ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'
> > > > >
> > > > > Fix the build error by adding the unspecified dependency.
> > > > >
> > > > > Reported-by: Brendan Higgins <brendanhiggins@google.com>
> > > > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> > > > > ---
> > > >
> > > > Sorry for the delay.
> > > >
> > > > Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > >
> > > It looks like my change has not been applied to nand/next; is this the
> > > branch it should be applied to? I have also verified that this patch
> > > isn't in linux-next as of Jan 24th.
> > >
> > > Is mtd/linux the correct tree for this? Or do I need to reach out to
> > > someone else?
> >
> > When I sent my Acked-by I supposed someone else would pick the patch,
> > but there is actually no dependency with all the other patches so I
> > don't know why I did it... Sorry about that. I'll take it anyway in my
> > PR for 5.6.
>
> It is applied on top of mtd/next since a few days, it will be part of
> the 5.6 PR.
>
> Sorry for the delay.
No worries.
Thanks!
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency
2020-01-27 9:46 ` Brendan Higgins
@ 2020-01-31 3:43 ` Joel Stanley
0 siblings, 0 replies; 29+ messages in thread
From: Joel Stanley @ 2020-01-31 3:43 UTC (permalink / raw)
To: Brendan Higgins
Cc: Jeff Dike, Richard Weinberger, Anton Ivanov, Andrew Jeffery,
Jeremy Kerr, Alistar Popple, Eddie James, linux-um,
Linux Kernel Mailing List, David Gow, linux-fsi, Linux ARM,
linux-aspeed
On Mon, 27 Jan 2020 at 09:46, Brendan Higgins <brendanhiggins@google.com> wrote:
> > > Do you want to get this in a fix for 5.5?
> >
> > Preferably, yes.
> >
> > > Acked-by: Joel Stanley <joel@jms.id.au>
>
> Hey, I know I owe you a reply about debugging your kunitconfig (I'll
> try to get to that this week); nevertheless, it looks like this patch
> didn't make it into 5.5. Can you make sure it gets into 5.6? It
> shouldn't depend on anything else.
Sure, thanks for the reminder.
Cheers,
Joel
^ permalink raw reply [flat|nested] 29+ messages in thread
end of thread, other threads:[~2020-01-31 3:44 UTC | newest]
Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency Brendan Higgins
2019-12-16 8:42 ` Linus Walleij
2019-12-16 9:31 ` Arnd Bergmann
2019-12-16 10:39 ` Linus Walleij
2020-01-23 22:15 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 2/7] mtd: rawnand: " Brendan Higgins
2020-01-09 15:23 ` Miquel Raynal
2020-01-25 2:12 ` Brendan Higgins
2020-01-25 15:28 ` Miquel Raynal
2020-01-27 19:00 ` Brendan Higgins
2020-01-30 19:50 ` Miquel Raynal
2020-01-30 19:55 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 3/7] net: axienet: " Brendan Higgins
2019-12-12 5:45 ` Radhey Shyam Pandey
2019-12-11 19:27 ` [PATCH v1 4/7] crypto: inside-secure: " Brendan Higgins
2019-12-20 7:07 ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 5/7] crypto: amlogic: " Brendan Higgins
2019-12-12 19:36 ` LABBE Corentin
2019-12-20 7:07 ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 6/7] staging: axis-fifo: " Brendan Higgins
2019-12-14 11:28 ` Greg Kroah-Hartman
2020-01-23 22:16 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 7/7] fsi: aspeed: " Brendan Higgins
2019-12-12 0:12 ` Joel Stanley
2019-12-12 0:30 ` Brendan Higgins
2019-12-16 6:01 ` Joel Stanley
2020-01-27 9:46 ` Brendan Higgins
2020-01-31 3:43 ` Joel Stanley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).