* [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet
@ 2018-09-19 14:19 Rodrigo Exterckötter Tjäder
2018-09-21 14:29 ` Maxime Ripard
0 siblings, 1 reply; 8+ messages in thread
From: Rodrigo Exterckötter Tjäder @ 2018-09-19 14:19 UTC (permalink / raw)
Cc: Rodrigo Exterckötter Tjäder, Maxime Ripard,
Chen-Yu Tsai, Rob Herring, Mark Rutland, linux-arm-kernel,
devicetree, linux-kernel
Without "allwinner,tx-delay-ps = <600>;" on the DTP it can receive packets
but not send.
Signed-off-by: Rodrigo Exterckötter Tjäder <rodrigo@tjader.xyz>
---
arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index 5245de3a1f35..75a435b9509b 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -90,6 +90,7 @@
phy-mode = "rgmii";
phy-handle = <&ext_rgmii_phy>;
phy-supply = <®_dcdc1>;
+ allwinner,tx-delay-ps = <600>;
status = "okay";
};
--
2.18.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet
2018-09-19 14:19 [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet Rodrigo Exterckötter Tjäder
@ 2018-09-21 14:29 ` Maxime Ripard
2018-09-21 15:25 ` Rodrigo Exterckötter Tjäder
0 siblings, 1 reply; 8+ messages in thread
From: Maxime Ripard @ 2018-09-21 14:29 UTC (permalink / raw)
To: Rodrigo Exterckötter Tjäder
Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, linux-arm-kernel,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Wed, Sep 19, 2018 at 11:19:36AM -0300, Rodrigo Exterckötter Tjäder wrote:
> Without "allwinner,tx-delay-ps = <600>;" on the DTP it can receive packets
> but not send.
>
> Signed-off-by: Rodrigo Exterckötter Tjäder <rodrigo@tjader.xyz>
Again, that commit log would be nice if it was a bit more
explicit. What is a DTP? How did you come up with that value? What is
the value used by Allwinner/Olimex, and why did you use another one if
you did?
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet
2018-09-21 14:29 ` Maxime Ripard
@ 2018-09-21 15:25 ` Rodrigo Exterckötter Tjäder
2018-09-26 9:45 ` Maxime Ripard
0 siblings, 1 reply; 8+ messages in thread
From: Rodrigo Exterckötter Tjäder @ 2018-09-21 15:25 UTC (permalink / raw)
To: maxime.ripard
Cc: wens, robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel
On Fri, Sep 21, 2018 at 11:30 AM Maxime Ripard
<maxime.ripard@bootlin.com> wrote:
> On Wed, Sep 19, 2018 at 11:19:36AM -0300, Rodrigo Exterckötter Tjäder wrote:
> > Without "allwinner,tx-delay-ps = <600>;" on the DTP it can receive packets
> > but not send.
> >
> > Signed-off-by: Rodrigo Exterckötter Tjäder <rodrigo@tjader.xyz>
>
> Again, that commit log would be nice if it was a bit more
> explicit. What is a DTP? How did you come up with that value? What is
> the value used by Allwinner/Olimex, and why did you use another one if
> you did?
Thanks for the feedback.
DTP is a typo, it should have been DT for "device tree".
Olimex's provided device tree uses a different driver for ethernet,
but it has a property named "tx-delay" with value 6 and the range of
the property is 0-7. On dwmac-sun8i's bindings documentation it says
allwinner,tx-delay-ps has a range of 0-700 and must be a multiple of
100, so I tried 600 and it works.
I'm not sure how much of that I should include in the commit log,
perhaps something like this:
---
arm64: dts: allwinner: OLinuXino: PHY TX clock delay
The PHY requres a delay on the TX clock, otherwise it is not able to send
any packets on the interface.
Olimex's device tree uses 6 in a range of 0-7, dwmac-sun8i requires a
multiple of 100 in the range 0-700.
Signed-off-by: Rodrigo Exterckötter Tjäder <rodrigo@tjader.xyz>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet
2018-09-21 15:25 ` Rodrigo Exterckötter Tjäder
@ 2018-09-26 9:45 ` Maxime Ripard
2018-09-26 15:14 ` Rodrigo Exterckötter Tjäder
0 siblings, 1 reply; 8+ messages in thread
From: Maxime Ripard @ 2018-09-26 9:45 UTC (permalink / raw)
To: Rodrigo Exterckötter Tjäder
Cc: wens, robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel
Hi!
On Fri, Sep 21, 2018 at 12:25:53PM -0300, Rodrigo Exterckötter Tjäder wrote:
> On Fri, Sep 21, 2018 at 11:30 AM Maxime Ripard
> <maxime.ripard@bootlin.com> wrote:
> > On Wed, Sep 19, 2018 at 11:19:36AM -0300, Rodrigo Exterckötter Tjäder wrote:
> > > Without "allwinner,tx-delay-ps = <600>;" on the DTP it can receive packets
> > > but not send.
> > >
> > > Signed-off-by: Rodrigo Exterckötter Tjäder <rodrigo@tjader.xyz>
> >
> > Again, that commit log would be nice if it was a bit more
> > explicit. What is a DTP? How did you come up with that value? What is
> > the value used by Allwinner/Olimex, and why did you use another one if
> > you did?
>
> Thanks for the feedback.
>
> DTP is a typo, it should have been DT for "device tree".
>
> Olimex's provided device tree uses a different driver for ethernet,
> but it has a property named "tx-delay" with value 6 and the range of
> the property is 0-7. On dwmac-sun8i's bindings documentation it says
> allwinner,tx-delay-ps has a range of 0-700 and must be a multiple of
> 100, so I tried 600 and it works.
>
> I'm not sure how much of that I should include in the commit log,
> perhaps something like this:
>
> ---
> arm64: dts: allwinner: OLinuXino: PHY TX clock delay
>
> The PHY requres a delay on the TX clock, otherwise it is not able to send
> any packets on the interface.
>
> Olimex's device tree uses 6 in a range of 0-7, dwmac-sun8i requires a
> multiple of 100 in the range 0-700.
>
> Signed-off-by: Rodrigo Exterckötter Tjäder <rodrigo@tjader.xyz>
There's no need to be so specific though :)
Something like that would work:
arm64: dts: allwinner: a64-olinuxino: set the PHY TX delay
The PHY found on the A64-Olinuxino requires a TX delay in order to
operate properly. Olimex uses a 600ps second delay in their BSP, and
that has been found to work, so let's use that value in the current
DT.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet
2018-09-26 9:45 ` Maxime Ripard
@ 2018-09-26 15:14 ` Rodrigo Exterckötter Tjäder
2018-09-26 17:05 ` Maxime Ripard
0 siblings, 1 reply; 8+ messages in thread
From: Rodrigo Exterckötter Tjäder @ 2018-09-26 15:14 UTC (permalink / raw)
To: maxime.ripard
Cc: wens, robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel
On Wed, Sep 26, 2018 at 6:46 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> There's no need to be so specific though :)
>
> Something like that would work:
>
> arm64: dts: allwinner: a64-olinuxino: set the PHY TX delay
>
> The PHY found on the A64-Olinuxino requires a TX delay in order to
> operate properly. Olimex uses a 600ps second delay in their BSP, and
> that has been found to work, so let's use that value in the current
> DT.
Should I go ahead and send a v2 with that commit message then?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet
2018-09-26 15:14 ` Rodrigo Exterckötter Tjäder
@ 2018-09-26 17:05 ` Maxime Ripard
2018-09-26 19:48 ` [PATCH v2] arm64: dts: allwinner: a64-olinuxino: set the PHY TX delay Rodrigo Exterckötter Tjäder
0 siblings, 1 reply; 8+ messages in thread
From: Maxime Ripard @ 2018-09-26 17:05 UTC (permalink / raw)
To: Rodrigo Exterckötter Tjäder
Cc: wens, robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel
On Wed, Sep 26, 2018 at 12:14:15PM -0300, Rodrigo Exterckötter Tjäder wrote:
> On Wed, Sep 26, 2018 at 6:46 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > There's no need to be so specific though :)
> >
> > Something like that would work:
> >
> > arm64: dts: allwinner: a64-olinuxino: set the PHY TX delay
> >
> > The PHY found on the A64-Olinuxino requires a TX delay in order to
> > operate properly. Olimex uses a 600ps second delay in their BSP, and
> > that has been found to work, so let's use that value in the current
> > DT.
>
> Should I go ahead and send a v2 with that commit message then?
Yep, thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] arm64: dts: allwinner: a64-olinuxino: set the PHY TX delay
2018-09-26 17:05 ` Maxime Ripard
@ 2018-09-26 19:48 ` Rodrigo Exterckötter Tjäder
2018-09-27 10:51 ` Chen-Yu Tsai
0 siblings, 1 reply; 8+ messages in thread
From: Rodrigo Exterckötter Tjäder @ 2018-09-26 19:48 UTC (permalink / raw)
Cc: Rodrigo Exterckötter Tjäder, Maxime Ripard,
Chen-Yu Tsai, Rob Herring, Mark Rutland, linux-arm-kernel,
devicetree, linux-kernel
The PHY found on the A64-OLinuXino requires a TX delay in order to
operate properly. Olimex uses a 600ps second delay in their BSP, and
that has been found to work, so let's use that value in the current
DT.
Signed-off-by: Rodrigo Exterckötter Tjäder <rodrigo@tjader.xyz>
---
arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index 6ef3dd4c2389..f7a4bccaa5d4 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -105,6 +105,7 @@
phy-mode = "rgmii";
phy-handle = <&ext_rgmii_phy>;
phy-supply = <®_dcdc1>;
+ allwinner,tx-delay-ps = <600>;
status = "okay";
};
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] arm64: dts: allwinner: a64-olinuxino: set the PHY TX delay
2018-09-26 19:48 ` [PATCH v2] arm64: dts: allwinner: a64-olinuxino: set the PHY TX delay Rodrigo Exterckötter Tjäder
@ 2018-09-27 10:51 ` Chen-Yu Tsai
0 siblings, 0 replies; 8+ messages in thread
From: Chen-Yu Tsai @ 2018-09-27 10:51 UTC (permalink / raw)
To: rodrigo
Cc: Maxime Ripard, Rob Herring, Mark Rutland, linux-arm-kernel,
devicetree, linux-kernel
On Thu, Sep 27, 2018 at 3:49 AM Rodrigo Exterckötter Tjäder
<rodrigo@tjader.xyz> wrote:
>
> The PHY found on the A64-OLinuXino requires a TX delay in order to
> operate properly. Olimex uses a 600ps second delay in their BSP, and
> that has been found to work, so let's use that value in the current
> DT.
>
> Signed-off-by: Rodrigo Exterckötter Tjäder <rodrigo@tjader.xyz>
Applied for 4.20. Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-09-27 10:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-19 14:19 [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix ethernet Rodrigo Exterckötter Tjäder
2018-09-21 14:29 ` Maxime Ripard
2018-09-21 15:25 ` Rodrigo Exterckötter Tjäder
2018-09-26 9:45 ` Maxime Ripard
2018-09-26 15:14 ` Rodrigo Exterckötter Tjäder
2018-09-26 17:05 ` Maxime Ripard
2018-09-26 19:48 ` [PATCH v2] arm64: dts: allwinner: a64-olinuxino: set the PHY TX delay Rodrigo Exterckötter Tjäder
2018-09-27 10:51 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).