* drivers/power/supply/mp2629_charger.c:522:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
@ 2020-10-09 13:37 kernel test robot
2020-10-09 14:27 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-10-09 13:37 UTC (permalink / raw)
To: Saravanan Sekar
Cc: kbuild-all, linux-kernel, Lee Jones, Andy Shevchenko, Sebastian Reichel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 549738f15da0e5a00275977623be199fbbf7df50
commit: 3bc6d790c39dfc4539c36525e6bcb617abbae467 power: supply: Add support for mps mp2629 battery charger
date: 4 months ago
:::::: branch date: 12 hours ago
:::::: commit date: 4 months ago
compiler: sh4-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
vim +522 drivers/power/supply/mp2629_charger.c
3bc6d790c39dfc Saravanan Sekar 2020-05-26 508
3bc6d790c39dfc Saravanan Sekar 2020-05-26 509 static ssize_t batt_impedance_compensation_show(struct device *dev,
3bc6d790c39dfc Saravanan Sekar 2020-05-26 510 struct device_attribute *attr,
3bc6d790c39dfc Saravanan Sekar 2020-05-26 511 char *buf)
3bc6d790c39dfc Saravanan Sekar 2020-05-26 512 {
3bc6d790c39dfc Saravanan Sekar 2020-05-26 513 struct mp2629_charger *charger = dev_get_drvdata(dev->parent);
3bc6d790c39dfc Saravanan Sekar 2020-05-26 514 unsigned int rval;
3bc6d790c39dfc Saravanan Sekar 2020-05-26 515 int ret;
3bc6d790c39dfc Saravanan Sekar 2020-05-26 516
3bc6d790c39dfc Saravanan Sekar 2020-05-26 517 ret = regmap_read(charger->regmap, MP2629_REG_IMPEDANCE_COMP, &rval);
3bc6d790c39dfc Saravanan Sekar 2020-05-26 518 if (ret)
3bc6d790c39dfc Saravanan Sekar 2020-05-26 519 return ret;
3bc6d790c39dfc Saravanan Sekar 2020-05-26 520
3bc6d790c39dfc Saravanan Sekar 2020-05-26 521 rval = (rval >> 4) * 10;
3bc6d790c39dfc Saravanan Sekar 2020-05-26 @522 return sprintf(buf, "%d mohm\n", rval);
3bc6d790c39dfc Saravanan Sekar 2020-05-26 523 }
3bc6d790c39dfc Saravanan Sekar 2020-05-26 524
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: drivers/power/supply/mp2629_charger.c:522:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
2020-10-09 13:37 drivers/power/supply/mp2629_charger.c:522:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int' kernel test robot
@ 2020-10-09 14:27 ` Andy Shevchenko
2020-10-12 5:35 ` [kbuild-all] " Rong Chen
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-10-09 14:27 UTC (permalink / raw)
To: kernel test robot
Cc: Saravanan Sekar, kbuild-all, Linux Kernel Mailing List,
Lee Jones, Sebastian Reichel
On Fri, Oct 9, 2020 at 4:23 PM kernel test robot <lkp@intel.com> wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 549738f15da0e5a00275977623be199fbbf7df50
> commit: 3bc6d790c39dfc4539c36525e6bcb617abbae467 power: supply: Add support for mps mp2629 battery charger
> date: 4 months ago
> :::::: branch date: 12 hours ago
> :::::: commit date: 4 months ago
> compiler: sh4-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
...
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 514 unsigned int rval;
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 515 int ret;
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 516
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 517 ret = regmap_read(charger->regmap, MP2629_REG_IMPEDANCE_COMP, &rval);
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 518 if (ret)
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 519 return ret;
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 520
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 521 rval = (rval >> 4) * 10;
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 @522 return sprintf(buf, "%d mohm\n", rval);
> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 523 }
Right, should be %u. Can LKP generate this type of patches?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [kbuild-all] Re: drivers/power/supply/mp2629_charger.c:522:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
2020-10-09 14:27 ` Andy Shevchenko
@ 2020-10-12 5:35 ` Rong Chen
0 siblings, 0 replies; 3+ messages in thread
From: Rong Chen @ 2020-10-12 5:35 UTC (permalink / raw)
To: Andy Shevchenko, kernel test robot
Cc: Saravanan Sekar, kbuild-all, Linux Kernel Mailing List,
Lee Jones, Sebastian Reichel
On 10/9/20 10:27 PM, Andy Shevchenko wrote:
> On Fri, Oct 9, 2020 at 4:23 PM kernel test robot <lkp@intel.com> wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: 549738f15da0e5a00275977623be199fbbf7df50
>> commit: 3bc6d790c39dfc4539c36525e6bcb617abbae467 power: supply: Add support for mps mp2629 battery charger
>> date: 4 months ago
>> :::::: branch date: 12 hours ago
>> :::::: commit date: 4 months ago
>> compiler: sh4-linux-gcc (GCC) 9.3.0
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
> ...
>
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 514 unsigned int rval;
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 515 int ret;
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 516
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 517 ret = regmap_read(charger->regmap, MP2629_REG_IMPEDANCE_COMP, &rval);
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 518 if (ret)
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 519 return ret;
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 520
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 521 rval = (rval >> 4) * 10;
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 @522 return sprintf(buf, "%d mohm\n", rval);
>> 3bc6d790c39dfc Saravanan Sekar 2020-05-26 523 }
> Right, should be %u. Can LKP generate this type of patches?
>
Hi Andy,
Thanks for the advice, is there a auto correct tool to do such thing?
I afraid we can't cover all the circumstances.
Best Regards,
Rong Chen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-12 5:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-09 13:37 drivers/power/supply/mp2629_charger.c:522:9: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int' kernel test robot
2020-10-09 14:27 ` Andy Shevchenko
2020-10-12 5:35 ` [kbuild-all] " Rong Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).