* [PATCH v1 1/1] usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield
@ 2021-04-25 15:09 Ferry Toth
2021-04-25 18:00 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Ferry Toth @ 2021-04-25 15:09 UTC (permalink / raw)
To: linux-usb, linux-kernel
Cc: Felipe Balbi, Greg Kroah-Hartman, Heikki Krogerus,
Andy Shevchenko, Ferry Toth
On Intel Merrifield LPM is causing host to reset port after a timeout.
By disabling LPM entirely this is prevented.
Signed-off-by: Ferry Toth <ftoth@exalondelft.nl>
Fixes: 066c09593454 ("usb: dwc3: pci: Enable extcon driver for Intel Merrifield")
---
drivers/usb/dwc3/dwc3-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 4c5c6972124a..e5d7eed2e60c 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -122,6 +122,7 @@ static const struct property_entry dwc3_pci_mrfld_properties[] = {
PROPERTY_ENTRY_STRING("linux,extcon-name", "mrfld_bcove_pwrsrc"),
PROPERTY_ENTRY_BOOL("snps,dis_u3_susphy_quirk"),
PROPERTY_ENTRY_BOOL("snps,dis_u2_susphy_quirk"),
+ PROPERTY_ENTRY_BOOL("snps,usb2-gadget-lpm-disable"),
PROPERTY_ENTRY_BOOL("linux,sysdev_is_parent"),
{}
};
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield
2021-04-25 15:09 [PATCH v1 1/1] usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield Ferry Toth
@ 2021-04-25 18:00 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2021-04-25 18:00 UTC (permalink / raw)
To: Ferry Toth
Cc: USB, Linux Kernel Mailing List, Felipe Balbi, Greg Kroah-Hartman,
Heikki Krogerus, Andy Shevchenko
On Sun, Apr 25, 2021 at 6:26 PM Ferry Toth <ftoth@exalondelft.nl> wrote:
>
> On Intel Merrifield LPM is causing host to reset port after a timeout.
the host
> By disabling LPM entirely this is prevented.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Thanks!
> Signed-off-by: Ferry Toth <ftoth@exalondelft.nl>
> Fixes: 066c09593454 ("usb: dwc3: pci: Enable extcon driver for Intel Merrifield")
> ---
> drivers/usb/dwc3/dwc3-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> index 4c5c6972124a..e5d7eed2e60c 100644
> --- a/drivers/usb/dwc3/dwc3-pci.c
> +++ b/drivers/usb/dwc3/dwc3-pci.c
> @@ -122,6 +122,7 @@ static const struct property_entry dwc3_pci_mrfld_properties[] = {
> PROPERTY_ENTRY_STRING("linux,extcon-name", "mrfld_bcove_pwrsrc"),
> PROPERTY_ENTRY_BOOL("snps,dis_u3_susphy_quirk"),
> PROPERTY_ENTRY_BOOL("snps,dis_u2_susphy_quirk"),
> + PROPERTY_ENTRY_BOOL("snps,usb2-gadget-lpm-disable"),
> PROPERTY_ENTRY_BOOL("linux,sysdev_is_parent"),
> {}
> };
> --
> 2.27.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-25 18:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-25 15:09 [PATCH v1 1/1] usb: dwc3: pci: Enable usb2-gadget-lpm-disable for Intel Merrifield Ferry Toth
2021-04-25 18:00 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).