* [PATCH] extcon: max14577: Add irq mask IRQ_ONESHOT
@ 2019-07-25 6:42 Vasyl Gomonovych
2019-07-25 7:24 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Vasyl Gomonovych @ 2019-07-25 6:42 UTC (permalink / raw)
To: cw00.choi, krzk, b.zolnierkie, myungjoo.ham
Cc: Vasyl Gomonovych, linux-kernel
Do not fire irq again until thread done
This issue was found by code inspection
Coccicheck irqf_oneshot.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/extcon/extcon-max14577.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
index 32f663436e6e..97c021512ffc 100644
--- a/drivers/extcon/extcon-max14577.c
+++ b/drivers/extcon/extcon-max14577.c
@@ -698,7 +698,7 @@ static int max14577_muic_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(&pdev->dev, virq, NULL,
max14577_muic_irq_handler,
- IRQF_NO_SUSPEND,
+ IRQF_NO_SUSPEND | IRQF_ONESHOT,
muic_irq->name, info);
if (ret) {
dev_err(&pdev->dev,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] extcon: max14577: Add irq mask IRQ_ONESHOT
2019-07-25 6:42 [PATCH] extcon: max14577: Add irq mask IRQ_ONESHOT Vasyl Gomonovych
@ 2019-07-25 7:24 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2019-07-25 7:24 UTC (permalink / raw)
To: Vasyl Gomonovych
Cc: Chanwoo Choi, Bartłomiej Żołnierkiewicz,
myungjoo.ham, linux-kernel
On Thu, 25 Jul 2019 at 08:42, Vasyl Gomonovych <gomonovych@gmail.com> wrote:
>
> Do not fire irq again until thread done
> This issue was found by code inspection
> Coccicheck irqf_oneshot.cocci
The same as in max77693 - this is virtual IRQ so no need for oneshot.
The hardware IRQ has oneshot set. Otherwise please provide slightly
more specific rationale for this commit.
Best regards,
Krzysztof
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
> drivers/extcon/extcon-max14577.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
> index 32f663436e6e..97c021512ffc 100644
> --- a/drivers/extcon/extcon-max14577.c
> +++ b/drivers/extcon/extcon-max14577.c
> @@ -698,7 +698,7 @@ static int max14577_muic_probe(struct platform_device *pdev)
>
> ret = devm_request_threaded_irq(&pdev->dev, virq, NULL,
> max14577_muic_irq_handler,
> - IRQF_NO_SUSPEND,
> + IRQF_NO_SUSPEND | IRQF_ONESHOT,
> muic_irq->name, info);
> if (ret) {
> dev_err(&pdev->dev,
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-25 7:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-25 6:42 [PATCH] extcon: max14577: Add irq mask IRQ_ONESHOT Vasyl Gomonovych
2019-07-25 7:24 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).