* [PATCH] sh: fix build error in mm/init.c
@ 2020-04-13 1:47 Masahiro Yamada
2020-04-13 7:42 ` Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Masahiro Yamada @ 2020-04-13 1:47 UTC (permalink / raw)
To: Andrew Morton, Yoshinori Sato, Rich Felker, linux-sh
Cc: linux-kernel, Masahiro Yamada, Dan Williams, David Hildenbrand,
Logan Gunthorpe, Michal Hocko, Mike Rapoport, Oscar Salvador,
Thomas Gleixner
The closing parenthesis is missing.
Fixes: bfeb022f8fe4 ("mm/memory_hotplug: add pgprot_t to mhp_params")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/sh/mm/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c
index b9de2d4fa57e..8d2a68aea1fc 100644
--- a/arch/sh/mm/init.c
+++ b/arch/sh/mm/init.c
@@ -412,7 +412,7 @@ int arch_add_memory(int nid, u64 start, u64 size,
unsigned long nr_pages = size >> PAGE_SHIFT;
int ret;
- if (WARN_ON_ONCE(params->pgprot.pgprot != PAGE_KERNEL.pgprot)
+ if (WARN_ON_ONCE(params->pgprot.pgprot != PAGE_KERNEL.pgprot))
return -EINVAL;
/* We only have ZONE_NORMAL, so this is easy.. */
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] sh: fix build error in mm/init.c
2020-04-13 1:47 [PATCH] sh: fix build error in mm/init.c Masahiro Yamada
@ 2020-04-13 7:42 ` Geert Uytterhoeven
2020-04-13 15:43 ` Logan Gunthorpe
2020-04-19 20:46 ` Masahiro Yamada
2 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-04-13 7:42 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Andrew Morton, Yoshinori Sato, Rich Felker, Linux-sh list,
Linux Kernel Mailing List, Dan Williams, David Hildenbrand,
Logan Gunthorpe, Michal Hocko, Mike Rapoport, Oscar Salvador,
Thomas Gleixner
On Mon, Apr 13, 2020 at 7:44 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> The closing parenthesis is missing.
>
> Fixes: bfeb022f8fe4 ("mm/memory_hotplug: add pgprot_t to mhp_params")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/arch/sh/mm/init.c
> +++ b/arch/sh/mm/init.c
> @@ -412,7 +412,7 @@ int arch_add_memory(int nid, u64 start, u64 size,
> unsigned long nr_pages = size >> PAGE_SHIFT;
> int ret;
>
> - if (WARN_ON_ONCE(params->pgprot.pgprot != PAGE_KERNEL.pgprot)
> + if (WARN_ON_ONCE(params->pgprot.pgprot != PAGE_KERNEL.pgprot))
> return -EINVAL;
>
> /* We only have ZONE_NORMAL, so this is easy.. */
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sh: fix build error in mm/init.c
2020-04-13 1:47 [PATCH] sh: fix build error in mm/init.c Masahiro Yamada
2020-04-13 7:42 ` Geert Uytterhoeven
@ 2020-04-13 15:43 ` Logan Gunthorpe
2020-04-13 16:04 ` Masahiro Yamada
2020-04-19 20:46 ` Masahiro Yamada
2 siblings, 1 reply; 6+ messages in thread
From: Logan Gunthorpe @ 2020-04-13 15:43 UTC (permalink / raw)
To: Masahiro Yamada, Andrew Morton, Yoshinori Sato, Rich Felker, linux-sh
Cc: linux-kernel, Dan Williams, David Hildenbrand, Michal Hocko,
Mike Rapoport, Oscar Salvador, Thomas Gleixner
On 2020-04-12 7:47 p.m., Masahiro Yamada wrote:
> The closing parenthesis is missing.
>
> Fixes: bfeb022f8fe4 ("mm/memory_hotplug: add pgprot_t to mhp_params")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
Oh, oops, I thought I compile checked all the arches. Must have been a
last minute change. I'm also surprised the kbuild robot didn't catch this.
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Andrew, can this be squashed into the existing patch?
Thanks,
Logan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sh: fix build error in mm/init.c
2020-04-13 15:43 ` Logan Gunthorpe
@ 2020-04-13 16:04 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2020-04-13 16:04 UTC (permalink / raw)
To: Logan Gunthorpe
Cc: Andrew Morton, Yoshinori Sato, Rich Felker, Linux-sh list,
Linux Kernel Mailing List, Dan Williams, David Hildenbrand,
Michal Hocko, Mike Rapoport, Oscar Salvador, Thomas Gleixner
On Tue, Apr 14, 2020 at 12:43 AM Logan Gunthorpe <logang@deltatee.com> wrote:
>
>
>
> On 2020-04-12 7:47 p.m., Masahiro Yamada wrote:
> > The closing parenthesis is missing.
> >
> > Fixes: bfeb022f8fe4 ("mm/memory_hotplug: add pgprot_t to mhp_params")
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
>
> Oh, oops, I thought I compile checked all the arches. Must have been a
> last minute change. I'm also surprised the kbuild robot didn't catch this.
>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
>
> Andrew, can this be squashed into the existing patch?
The offending commit is already in Linus' tree.
I was also surprised that no bot or human
complained about this breakage before it was merged.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sh: fix build error in mm/init.c
2020-04-13 1:47 [PATCH] sh: fix build error in mm/init.c Masahiro Yamada
2020-04-13 7:42 ` Geert Uytterhoeven
2020-04-13 15:43 ` Logan Gunthorpe
@ 2020-04-19 20:46 ` Masahiro Yamada
2020-04-19 20:49 ` Masahiro Yamada
2 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2020-04-19 20:46 UTC (permalink / raw)
To: Linus Torvalds
Cc: Linux Kernel Mailing List, Dan Williams, David Hildenbrand,
Logan Gunthorpe, Michal Hocko, Mike Rapoport, Oscar Salvador,
Thomas Gleixner, Linux-sh list, Yoshinori Sato, Rich Felker,
Andrew Morton
Hi Linus,
On Mon, Apr 13, 2020 at 10:48 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> The closing parenthesis is missing.
>
> Fixes: bfeb022f8fe4 ("mm/memory_hotplug: add pgprot_t to mhp_params")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Will you pick up this directly ?
The SuperH subsystem is inactive these days.
https://lore.kernel.org/patchwork/patch/1223032/
This is easy to review, and ARCH=sh build is apparently broken.
Thanks.
> ---
>
> arch/sh/mm/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c
> index b9de2d4fa57e..8d2a68aea1fc 100644
> --- a/arch/sh/mm/init.c
> +++ b/arch/sh/mm/init.c
> @@ -412,7 +412,7 @@ int arch_add_memory(int nid, u64 start, u64 size,
> unsigned long nr_pages = size >> PAGE_SHIFT;
> int ret;
>
> - if (WARN_ON_ONCE(params->pgprot.pgprot != PAGE_KERNEL.pgprot)
> + if (WARN_ON_ONCE(params->pgprot.pgprot != PAGE_KERNEL.pgprot))
> return -EINVAL;
>
> /* We only have ZONE_NORMAL, so this is easy.. */
> --
> 2.25.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sh: fix build error in mm/init.c
2020-04-19 20:46 ` Masahiro Yamada
@ 2020-04-19 20:49 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2020-04-19 20:49 UTC (permalink / raw)
To: Linus Torvalds
Cc: Linux Kernel Mailing List, Dan Williams, David Hildenbrand,
Logan Gunthorpe, Michal Hocko, Mike Rapoport, Oscar Salvador,
Thomas Gleixner, Linux-sh list, Yoshinori Sato, Rich Felker,
Andrew Morton
On Mon, Apr 20, 2020 at 5:46 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Hi Linus,
>
> On Mon, Apr 13, 2020 at 10:48 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > The closing parenthesis is missing.
> >
> > Fixes: bfeb022f8fe4 ("mm/memory_hotplug: add pgprot_t to mhp_params")
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
>
>
> Will you pick up this directly ?
> The SuperH subsystem is inactive these days.
>
> https://lore.kernel.org/patchwork/patch/1223032/
>
>
> This is easy to review, and ARCH=sh build is apparently broken.
>
> Thanks.
Sorry, I take it back.
Guenter's one is already queued up in linux-next.
Somebody will fix it eventually.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-19 20:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-13 1:47 [PATCH] sh: fix build error in mm/init.c Masahiro Yamada
2020-04-13 7:42 ` Geert Uytterhoeven
2020-04-13 15:43 ` Logan Gunthorpe
2020-04-13 16:04 ` Masahiro Yamada
2020-04-19 20:46 ` Masahiro Yamada
2020-04-19 20:49 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).